1 Changelog V1.21.4
Forgejo Actions edited this page 2026-09-25 16:38:07 +00:00

v1.21.4

Date: 2026-07-18 PR: #639

Bug Fixes

  • Text-based search broken in assign-person dialog — suggestSimilarInstances() in ClassInstanceDiscoveryService.java did embedding-first matching then post-filtered by name. When no embeddings existed (V115 wipe or new person), returned empty before name filter ever ran. Fixed: when embedding results empty AND query non-blank, fall back to direct ILIKE name search. Embedding matches (real similarity) come first, name-only matches (similarity=0) after.
  • class-instances people branch ignored q param — DiscoveryController.java people branch called classInstanceService.people(userId) which hardcoded query=null. Fixed: new people(UUID, String) overload forwards query to instances(userId, "people", "active", query).
  • No debounce on suggestion input — MediaDetailViewer.svelte and EditMarkerLabelDialog.svelte fired API call on every keystroke. Fixed: 300ms debounce in both (legacy $: syntax + Svelte 5 runes respectively).

Follow-Up

  • Add class_key filter to fallback SQL for cross-domain consistency
  • Unit tests for: fallback path, null/blank query guard, embedding-filter-to-empty
  • people(UUID, String) delegation test