1 Changelog V1.21.27
Forgejo Actions edited this page 2026-09-25 16:38:07 +00:00

v1.21.27

Date: 2026-09-07

Bug Fixes

  • owner-face-embeddings endpoint now returns known-person faces → face similarity suggestions work again. Root cause: V117 state transition excluded accepted faces — the accepted branch filtered discovery_results.state = 'owner_tentative' only, but accepted faces transition owner_tentative → owner_recognized via the V117 backfill + ClassInstanceDiscoveryService once their occurrence is accepted, so the worker only ever saw still-tentative faces, producing empty similarity suggestions. Fix: accepted branch filter now state IN ('owner_tentative','owner_recognized') (one line). Pending branch unchanged. No response-shape change, no dedup/ranking change, workers/people untouched.

Notes

  • PR #714 (squash commit 44db0e0a), branch fix/face-embeddings-known-persons, run #2403. No spec task claimed this change (S035T007 pending is the separate dedicated DiscoveryController embedding endpoint — not this PR).
  • Delivered: OwnerFaceEmbeddingsControllerTest (Testcontainers + Flyway): recognized-face returned, tentative face returned, no cross-owner leak, job-payload assignments maps recognized face → person record. Version bump 1.21.26 → 1.21.27 (PR branch, gradle.properties).
  • Data-stock caveat (ISSUE-027, still high/mitigated): persons with zero embeddings (Rikke, Jesper — 2 persons) remain unmatched — pending-embedding purge deleted >24h-old embeddings even while faces were unassigned; endpoint fix restores suggestions only for faces that still have stored embeddings; regeneration is a separate pending decision.
  • ⚠ CI gap (ISSUE-026, med/open, fix task S014T004 pending): scoped tests skipped in CI for this PR — detect output run_api_tests=false, run_api_people_tests=false (head commit is the version-bump commit, docs-ish; scope detection evaluates only push-head commit) and post-merge test job is excluded on main pushes (workflow if: github.ref != 'refs/heads/main'); JVM tests verified via Test Engineer local run (772 green, Testcontainers) + exact diff review. Needs workflow fix (detect on merge-base diff).