fix(api+web): text-based name search in instance-suggestions + 300ms debounce #639

Merged
chris merged 3 commits from fix/text-suggestions into main 2026-07-18 19:13:55 +02:00
Owner

What

Two fixes for assign-person dialog text search:

1. Backend: name-based fallback in suggestSimilarInstances()

Previously: embedding-first → returns empty if no embeddings exist → name filter never runs.
Now: when embedding results are empty AND query is non-blank, fallback to ILIKE name search. Embedding matches (with real similarity) come first, name-only matches (similarity=0) after.

2. Backend: class-instances people branch now passes q param

Previously: classInstanceService.people(userId) hardcoded query=null.
Now: new people(UUID, String) overload forwards query to instances(userId, "people", "active", query).

3. Frontend: 300ms debounce on face/label suggestion input

Previously: every keystroke fired an API call.
Now: 300ms debounce in both MediaDetailViewer.svelte (legacy $:) and EditMarkerLabelDialog.svelte (Svelte 5 runes).

Test

  • API tests pass
  • Frontend type check 0 errors
  • H2 ILIKE confirmed compatible (MODE=PostgreSQL)

Version

1.21.3 → 1.21.4

Follow-up (not blocking)

  • Add AND ci.class_key = :classKey to fallback query for cross-domain consistency
  • Add unit tests for: fallback path, null/blank query guard, embedding filter to empty
  • Add people(UUID, String) delegation test
## What Two fixes for assign-person dialog text search: ### 1. Backend: name-based fallback in `suggestSimilarInstances()` Previously: embedding-first → returns empty if no embeddings exist → name filter never runs. Now: when embedding results are empty AND query is non-blank, fallback to ILIKE name search. Embedding matches (with real similarity) come first, name-only matches (similarity=0) after. ### 2. Backend: `class-instances` people branch now passes `q` param Previously: `classInstanceService.people(userId)` hardcoded `query=null`. Now: new `people(UUID, String)` overload forwards query to `instances(userId, "people", "active", query)`. ### 3. Frontend: 300ms debounce on face/label suggestion input Previously: every keystroke fired an API call. Now: 300ms debounce in both `MediaDetailViewer.svelte` (legacy `$:`) and `EditMarkerLabelDialog.svelte` (Svelte 5 runes). ## Test - API tests pass - Frontend type check 0 errors - H2 ILIKE confirmed compatible (MODE=PostgreSQL) ## Version 1.21.3 → 1.21.4 ## Follow-up (not blocking) - Add `AND ci.class_key = :classKey` to fallback query for cross-domain consistency - Add unit tests for: fallback path, null/blank query guard, embedding filter to empty - Add `people(UUID, String)` delegation test
fix(web): add 300ms debounce to face/label suggestion input
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 10m58s
f64b1f20cd
fix(api): name-based fallback in suggestSimilarInstances + pass q to people class-instances
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m50s
6f34ad9ba1
chore: bump version 1.21.3 → 1.21.4
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m37s
5bc0a719f1
chris merged commit dff0c7558d into main 2026-07-18 19:13:55 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!639
No description provided.