1 Changelog V1.21.23
Forgejo Actions edited this page 2026-09-25 16:38:07 +00:00

v1.21.23

Date: 2026-07-22

Bug Fixes

  • "Apply retroactively" for People now actually works. Two fundamental bugs fixed:
    1. Retarget was count-only: The "12843 local retargeted" count was misleading — the code only counted pending candidates without doing any retargeting. Now retargetUnnamedCandidatesToNamedPeople() is actually called, creating real class_instance_occurrences for retargeted faces.
    2. Named candidate LIKE join was broken: The query CAST(cic.occurrence_refs AS VARCHAR) LIKE '%dr.id%' always failed because occurrence_refs for face_detection candidates contains only mediaItemId, not faceAnnotationId. Replaced with dr.media_item_id = CAST(media_item_id_from_occurrence_refs(cic.occurrence_refs) AS UUID). Affected 6 SQL queries in ClassInstanceService.java + 1 in MediaMaintenanceService.java.
  • V120 migration adds PG function media_item_id_from_occurrence_refs(jsonb) to safely extract mediaItemId from the candidate's occurrence_refs JSONB array.

Notes

  • Closes #695
  • Impact: 12,843 pending candidates can now actually be retargeted. After deploy, running "Apply retroactively" should produce visible new faces on person pages.
  • Follow-ups: 4 faceAnnotationId LIKE patterns remain (different class, deeper analysis needed) — ClassInstanceService.java:3961, 4428, ClassInstanceDiscoveryService.java:753, DiscoveryService.java:501.