feat(api): constrainedClusteringEnabled setting + ambiguous review-only guard #968

Merged
chris merged 1 commit from feat/constrained-forward-core into main 2026-09-30 08:14:15 +02:00
Owner

Core side of ADR 0100 (constrained density clustering for forward face recognition). Companion worker PR follows.

  • V147: discovery_domains.constrained_clustering_enabled BOOLEAN NOT NULL DEFAULT true (V103/V129 precedent; default true backfills the seeded people row)
  • WorkerJobEnqueueService: threads settings.constrainedClusteringEnabled into owner_face_recognition job payloads (explicit FALSE only disables; idempotency untouched)
  • ClassInstanceDiscoveryService: new isAmbiguousReviewCandidate predicate (people + cluster_person_match + ambiguous=TRUE) guarding all four auto-assign branches — stash shadow + three named-target tiers — so ambiguous candidates stay pending and surface as review carousel cards (ADR 0017 defense-in-depth; weakMatch-only stash behavior unchanged, pinned test still passes)
  • Payload passthrough verified: no whitelist on storage path; ambiguous + conflictingPersonIds stored verbatim (test added)
  • H2 fixture schemas updated for the new column

Tests: full :apps:api suite 1379/1379 green (Testcontainers Postgres available), incl. new V147 migration test, payload threading tests, 5 ambiguous-guard tests.

Core side of ADR 0100 (constrained density clustering for forward face recognition). Companion worker PR follows. - V147: discovery_domains.constrained_clustering_enabled BOOLEAN NOT NULL DEFAULT true (V103/V129 precedent; default true backfills the seeded people row) - WorkerJobEnqueueService: threads settings.constrainedClusteringEnabled into owner_face_recognition job payloads (explicit FALSE only disables; idempotency untouched) - ClassInstanceDiscoveryService: new isAmbiguousReviewCandidate predicate (people + cluster_person_match + ambiguous=TRUE) guarding all four auto-assign branches — stash shadow + three named-target tiers — so ambiguous candidates stay pending and surface as review carousel cards (ADR 0017 defense-in-depth; weakMatch-only stash behavior unchanged, pinned test still passes) - Payload passthrough verified: no whitelist on storage path; ambiguous + conflictingPersonIds stored verbatim (test added) - H2 fixture schemas updated for the new column Tests: full :apps:api suite 1379/1379 green (Testcontainers Postgres available), incl. new V147 migration test, payload threading tests, 5 ambiguous-guard tests.
feat(api): constrainedClusteringEnabled setting + ambiguous review-only guard
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m47s
385bc90418
chris merged commit b9ceb3d2ca into main 2026-09-30 08:14:15 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!968
No description provided.