fix(web): make npm run test:unit self-sufficient (svelte-kit sync) #929

Merged
chris merged 1 commit from feat/049-upload-activity-web into main 2026-09-27 19:54:44 +02:00
Owner

Follow-up to the already-merged feature PR #925 (spec 049 cross-device upload activity UI).

While validating the merged feature on current main I found that npm run test:unit fails on any fresh checkout/worktree: apps/web/tsconfig.json extends the generated .svelte-kit/tsconfig.json, and the new script did not run svelte-kit sync first (it only worked where a prior dev/build/check had generated the file). This mirrors the existing check script.

Validation on this branch (main 439b0266 + this commit):

  • npm run test:unit from a clean state (no .svelte-kit): 18/18 passed (uploadActivityServer.spec.ts 15, uploadActivity.spec.ts 3)
  • npm run check: 0 errors, 20 pre-existing a11y warnings
  • npm run build: success
  • Contract review vs merged backend (UploadActivityController/UploadActivitySession): bare JSON array, derivedStatus, flat camelCase counts, receivingFileNames; SSE upload_activity_changed payload {sessionId} — client matches; no code fixes needed.
  • Playwright e2e not rerun here (requires the live stack).
Follow-up to the already-merged feature PR #925 (spec 049 cross-device upload activity UI). While validating the merged feature on current main I found that `npm run test:unit` fails on any fresh checkout/worktree: apps/web/tsconfig.json extends the generated `.svelte-kit/tsconfig.json`, and the new script did not run `svelte-kit sync` first (it only worked where a prior dev/build/check had generated the file). This mirrors the existing `check` script. Validation on this branch (main 439b0266 + this commit): - `npm run test:unit` from a clean state (no `.svelte-kit`): 18/18 passed (uploadActivityServer.spec.ts 15, uploadActivity.spec.ts 3) - `npm run check`: 0 errors, 20 pre-existing a11y warnings - `npm run build`: success - Contract review vs merged backend (`UploadActivityController`/`UploadActivitySession`): bare JSON array, `derivedStatus`, flat camelCase counts, `receivingFileNames`; SSE `upload_activity_changed` payload `{sessionId}` — client matches; no code fixes needed. - Playwright e2e not rerun here (requires the live stack).
fix(web): make npm run test:unit self-sufficient (svelte-kit sync)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m52s
3d2ac879e4
The new vitest script failed on any fresh checkout/worktree because tsconfig.json extends the generated .svelte-kit/tsconfig.json. Mirror the existing check script and run svelte-kit sync first. Follow-up to #925 (spec 049).
chris merged commit ba5375af21 into main 2026-09-27 19:54:44 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!929
No description provided.