fix(web): activity badge reflects in-flight processing only #905

Merged
chris merged 1 commit from fix/activity-badge-in-flight into main 2026-09-27 12:28:28 +02:00
Owner

Problem

Follow-up user feedback after #901: the top-menu activity badge showed 999+ with label 0 processing · 1745 failed. The count came from incompleteMediaCount (lifetime: every active media with any failed/expired job ever), and the label leaked the failed count. Additionally, needs-attention-only lanes in the Media activity dialog still displayed their lifetime done count (e.g. 6901 done · … · 6 needs attention).

Fix (frontend only)

  • ProcessingIndicator.svelte + AppShell.svelte: badge count is now incompleteMediaBreakdown.processing (in-flight only); label is N processing / No media processing right now — never mentions failed; failed media no longer keep the pulse/icon alive.
  • ActivityDialog.svelte: lane text includes the done count only when the lane has queued/processing work; needs-attention-only lanes show 0 waiting · 0 processing · N needs attention without the lifetime done number.
  • upload-status.spec.ts: new failed-only-badge test (asserts no 999+/failed/not-fully-processed wording), new needs-attention-only lane assertion, badge-visibility assertions incl. SSE refresh clearing it.

Validation

  • npm run check 0 errors · npm run build ok
  • Playwright upload-status: 11 passed desktop+mobile (1 known unrelated upload-timing flake passed on retry); accessibility/incomplete-media/upload-batch-notifications: 19 passed, 3 expected skips
## Problem Follow-up user feedback after #901: the top-menu activity badge showed `999+` with label `0 processing · 1745 failed`. The count came from `incompleteMediaCount` (lifetime: every active media with any failed/expired job ever), and the label leaked the failed count. Additionally, needs-attention-only lanes in the Media activity dialog still displayed their lifetime done count (e.g. `6901 done · … · 6 needs attention`). ## Fix (frontend only) - `ProcessingIndicator.svelte` + `AppShell.svelte`: badge count is now `incompleteMediaBreakdown.processing` (in-flight only); label is `N processing` / `No media processing right now` — never mentions failed; failed media no longer keep the pulse/icon alive. - `ActivityDialog.svelte`: lane text includes the done count only when the lane has queued/processing work; needs-attention-only lanes show `0 waiting · 0 processing · N needs attention` without the lifetime done number. - `upload-status.spec.ts`: new failed-only-badge test (asserts no 999+/failed/not-fully-processed wording), new needs-attention-only lane assertion, badge-visibility assertions incl. SSE refresh clearing it. ## Validation - `npm run check` 0 errors · `npm run build` ok - Playwright upload-status: 11 passed desktop+mobile (1 known unrelated upload-timing flake passed on retry); accessibility/incomplete-media/upload-batch-notifications: 19 passed, 3 expected skips
fix(web): show only in-flight processing in activity badge and dialog
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 5s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 8m30s
8d63a0fa4f
The top-menu activity badge counted every incomplete media item, so
lifetime failed jobs produced a 999+ badge labelled with failed counts.
The badge now counts only in-flight processing via
incompleteMediaBreakdown.processing and stays hidden when nothing is
processing; failed work no longer keeps the activity icon or pulse alive.

In the Media activity dialog, needs-attention-only lanes no longer show
their lifetime done count; only lanes with queued or processing jobs
include the done number.
chris merged commit a304f4159c into main 2026-09-27 12:28:28 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!905
No description provided.