fix(ci): deploy-api gate needs always() — skipped postgres deploy silently skipped API deploy #837

Merged
chris merged 1 commit from fix/deploy-api-gate into main 2026-09-23 22:13:39 +02:00
Owner

Bug

Since #826, deploy-api has needs: [changes, build-api, deploy-postgres] but WITHOUT always() in its if. In Forgejo/GHA semantics, when a needs-dependency is skipped (deploy-postgres on PRs that don't touch postgres), the job is skipped BEFORE the if expression is evaluated — even though the expression explicitly accepts 'skipped'. Consequence: runs 2742 (#831) and 2753 (#835) built the API image (success) but silently never deployed it — API containers in production stayed on older images while web deployed. User-visible as 404 on the new /unassign endpoint (#835's feature lives in the registry image, not in the running container).

deploy-web and all worker deploys already carry always() — deploy-api was the only one missing it (introduced by #826's needs-chain change).

Fix

if: always() && ... (mirroring deploy-web's pattern). Merging this triggers a full-rebuild workflow run (workflow change = full trigger per policy), which recreates memories-api from the latest image — bringing the undeployed #831/#835 API changes (incl. face unassign) live as a side effect.

## Bug Since #826, deploy-api has needs: [changes, build-api, deploy-postgres] but WITHOUT always() in its if. In Forgejo/GHA semantics, when a needs-dependency is skipped (deploy-postgres on PRs that don't touch postgres), the job is skipped BEFORE the if expression is evaluated — even though the expression explicitly accepts 'skipped'. Consequence: runs 2742 (#831) and 2753 (#835) built the API image (success) but silently never deployed it — API containers in production stayed on older images while web deployed. User-visible as 404 on the new /unassign endpoint (#835's feature lives in the registry image, not in the running container). deploy-web and all worker deploys already carry always() — deploy-api was the only one missing it (introduced by #826's needs-chain change). ## Fix if: always() && ... (mirroring deploy-web's pattern). Merging this triggers a full-rebuild workflow run (workflow change = full trigger per policy), which recreates memories-api from the latest image — bringing the undeployed #831/#835 API changes (incl. face unassign) live as a side effect.
fix(ci): deploy-api needs always() — skipped postgres deploys silently skipped API deploys (runs 2742/2753)
All checks were successful
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m42s
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
cc67973637
chris merged commit 4bf3a35b92 into main 2026-09-23 22:13:39 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!837
No description provided.