fix(web): stabilize albums/map/accessibility E2E specs #784

Merged
chris merged 1 commit from fix/web-ci-failures into main 2026-09-20 21:59:49 +02:00
Owner

Stabilizes the 8 web Playwright failures blocking CI (desktop+mobile), root-caused locally by reproduction:

Root causes

tests/accessibility.spec.ts:123,:152 (mobile) — app bug (a11y regression)
The mobile hamburger button lost aria-expanded during the app-shell/nav extraction: AppShell owns mobileMenuOpen but never passed it to AppHeader. The disclosure button now exposes aria-expanded wired to the drawer state (AppShell -> AppHeader). No visual change.

tests/albums.spec.ts:1778 — test drift (opt-in review context)
The review dialog now loads the timeline lazily only after "Show nearby context" and windows ±2 days around the selected day (start index 1, count 5 for the 2024-08-10 suggestion), revealing 4 days per edge scroll; pre-context there are no scroll hints. Spec still asserted the old always-loaded 8-day window (and could not reach the Accept action on mobile because the modal sat at the same z-index as the BottomNav).

  • App fix: suggestion-review modal z-40 -> z-50 so the mobile BottomNav no longer intercepts taps on the modal footer actions.
  • Spec updated to current behavior, asserting the opt-in contract and that bulk selection stays scoped to loaded context days.

tests/albums.spec.ts:49 (desktop+mobile) — test drift
The selection-bar move action is now an icon-only button with accessible name "Move" (was a "Move..." text button). Spec selector updated.

tests/map.spec.ts:83 (desktop+mobile) — test drift
The removed copy "No visible media with coordinates in this map view." was replaced by the shared EmptyState ("No locations found" / "Photos with GPS data will appear on the map"). Spec asserts the current empty state.

Verification

  • npx playwright test tests/albums.spec.ts tests/map.spec.ts tests/accessibility.spec.ts -> 28 passed, 4 skipped (desktop+mobile)
  • npm run check -> 0 errors (20 pre-existing warnings)

Not env-related: all 8 failed on a clean local run before the fix.

Stabilizes the 8 web Playwright failures blocking CI (desktop+mobile), root-caused locally by reproduction: ## Root causes **tests/accessibility.spec.ts:123,:152 (mobile) — app bug (a11y regression)** The mobile hamburger button lost `aria-expanded` during the app-shell/nav extraction: AppShell owns `mobileMenuOpen` but never passed it to AppHeader. The disclosure button now exposes `aria-expanded` wired to the drawer state (AppShell -> AppHeader). No visual change. **tests/albums.spec.ts:1778 — test drift (opt-in review context)** The review dialog now loads the timeline lazily only after "Show nearby context" and windows ±2 days around the selected day (start index 1, count 5 for the 2024-08-10 suggestion), revealing 4 days per edge scroll; pre-context there are no scroll hints. Spec still asserted the old always-loaded 8-day window (and could not reach the Accept action on mobile because the modal sat at the same z-index as the BottomNav). - App fix: suggestion-review modal `z-40` -> `z-50` so the mobile BottomNav no longer intercepts taps on the modal footer actions. - Spec updated to current behavior, asserting the opt-in contract and that bulk selection stays scoped to loaded context days. **tests/albums.spec.ts:49 (desktop+mobile) — test drift** The selection-bar move action is now an icon-only button with accessible name "Move" (was a "Move..." text button). Spec selector updated. **tests/map.spec.ts:83 (desktop+mobile) — test drift** The removed copy "No visible media with coordinates in this map view." was replaced by the shared EmptyState ("No locations found" / "Photos with GPS data will appear on the map"). Spec asserts the current empty state. ## Verification - `npx playwright test tests/albums.spec.ts tests/map.spec.ts tests/accessibility.spec.ts` -> 28 passed, 4 skipped (desktop+mobile) - `npm run check` -> 0 errors (20 pre-existing warnings) Not env-related: all 8 failed on a clean local run before the fix.
fix(web): stabilize albums/map/accessibility E2E specs
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m31s
06b50728bb
- accessibility: restore aria-expanded on the mobile navigation hamburger
  button, wired to AppShell's drawer state (disclosure a11y regression).
- albums: fix suggestion-review modal stacking so the mobile bottom nav no
  longer intercepts taps on the modal footer actions (z-40 -> z-50).
- albums: update stale selectors/expectations to current UI (icon-only
  "Move" action button; opt-in review context window of +/-2 days around the
  selected day, revealed 4 days per edge scroll).
- map: assert the current empty-state copy ("No locations found") instead of
  the removed timeline placeholder text.
chris merged commit 0ca407f403 into main 2026-09-20 21:59:49 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!784
No description provided.