feat(people): stash away / disband on cluster-person-match cards (spec 039) #771

Merged
chris merged 1 commit from feat/cluster-match-stash-disband into main 2026-09-19 16:12:41 +02:00
Owner

User-reported gap: 'Similar — These N photos look like Helene' cards (cluster_person_match) kept the plain Reject button — the 'not interested in this person' case had no stash path.

Backend: decideCandidate decision=stashed on a pre-linked cluster candidate now ignores the suggested person and creates a fresh unnamed shadow instance (suggested person untouched, faces land on the shadow, proposed displayName dropped — a stash is unnamed by definition). Previously stashed silently accepted into the suggested person (stashInstance no-ops on named targets).

Frontend: isPeopleCluster covers cluster_person_match → cluster card stack, detail dialog and grid render the stash/disband split control.

Tests: new backend case + reworked cluster_person_match card test (split control coverage); full discovery/people suites green, Playwright 62/62.

User-reported gap: 'Similar — These N photos look like Helene' cards (cluster_person_match) kept the plain Reject button — the 'not interested in this person' case had no stash path. Backend: decideCandidate decision=stashed on a pre-linked cluster candidate now ignores the suggested person and creates a fresh unnamed shadow instance (suggested person untouched, faces land on the shadow, proposed displayName dropped — a stash is unnamed by definition). Previously stashed silently accepted into the suggested person (stashInstance no-ops on named targets). Frontend: isPeopleCluster covers cluster_person_match → cluster card stack, detail dialog and grid render the stash/disband split control. Tests: new backend case + reworked cluster_person_match card test (split control coverage); full discovery/people suites green, Playwright 62/62.
feat(people): stash away / disband on cluster-person-match cards (spec 039 refinement)
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 9m18s
7e7bed09d1
User-reported gap: the 'Similar — These N photos look like Helene' cards
(cluster_person_match) still showed the plain Reject button, so the
'not interested in this person' case had no stash path.

Backend: decideCandidate with decision=stashed on a pre-linked cluster
candidate now IGNORES the suggested person and creates a fresh unnamed
shadow instance — the suggested (named) person stays untouched, the
cluster's faces land on the shadow, and any proposed displayName is
dropped (a stash is unnamed by definition; naming via rename unstashes).
Previously 'stashed' on a pre-linked candidate silently accepted into
the suggested person and stashInstance was a no-op there (named → 400).

Frontend: isPeopleCluster now covers cluster_person_match, so the
cluster card stack, detail dialog and non-cluster grid all render the
stash/disband split control instead of plain Reject for these cards.

Tests: new backend case (pre-linked stash → fresh shadow, Helene
untouched); reworked the cluster_person_match card test to cover the
split control (Stash posts stashed, Disband menu posts disbanded) and
restored the dialog-reject test's decision route that a non-unique
replace had corrupted.
chris merged commit f4795e0d29 into main 2026-09-19 16:12:41 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!771
No description provided.