fix(discovery): return full body for retrospective run start endpoint #693

Merged
chris merged 2 commits from fix/retroactive-empty-body into main 2026-07-22 09:36:31 +02:00
Owner

POST /api/discovery/domains/{domainKey}/retrospective-runs was returning 201 with
empty body. Frontend apiClient.request parsed empty string as
ClassInstanceAutoAcceptRetrospectiveRunView → downstream state corruption.

Fix: return run as response body via .body(run) instead of .build().

Commit: 87abdefd3c

POST /api/discovery/domains/{domainKey}/retrospective-runs was returning 201 with empty body. Frontend apiClient.request parsed empty string as ClassInstanceAutoAcceptRetrospectiveRunView → downstream state corruption. Fix: return run as response body via .body(run) instead of .build(). Commit: 87abdefd3c383721bf47c3bfd1e9729330863cab
fix(discovery): return full body for retrospective run start endpoint
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m38s
87abdefd3c
POST /api/discovery/domains/{domainKey}/retrospective-runs was returning 201 with
empty body. Frontend apiClient.request parsed empty string as
ClassInstanceAutoAcceptRetrospectiveRunView → downstream state corruption.

Fix: return run as response body via .body(run) instead of .build().
chore: bump version to v1.21.22
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m47s
315f662a38
chris merged commit bdb8f14b95 into main 2026-07-22 09:36:31 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!693
No description provided.