fix(web): prefer precomputed face crop on person detail page #687

Merged
chris merged 2 commits from fix/detail-page-thumbnail-priority into main 2026-07-21 21:58:17 +02:00
Owner

Summary

Fixes thumbnail priority ordering on the person detail page. Previously, the CSS bbox crop (representativeBbox + representativeThumbnailUrl) was checked first, even when a precomputed cropped thumbnail (representativeCroppedThumbnailUrl) was available. This caused unnecessary client-side cropping and inconsistent rendering compared to the explore page.

What changed

Swapped the first two conditions in DiscoveryInstanceDetail.svelte so that representativeCroppedThumbnailUrl is checked first — matching the explore page behavior. The CSS bbox crop fallback is preserved for domains without precomputed crops.

Checklist

  • svelte-check passes (0 errors, pre-existing warnings only)
  • Single file changed: apps/web/src/lib/components/DiscoveryInstanceDetail.svelte
  • No new imports needed (all helpers already in scope)
  • CSS bboxCrop fallback preserved for domains without precomputed crops
  • Version bump deferred to Senior Engineer
## Summary Fixes thumbnail priority ordering on the person detail page. Previously, the CSS bbox crop (`representativeBbox` + `representativeThumbnailUrl`) was checked first, even when a precomputed cropped thumbnail (`representativeCroppedThumbnailUrl`) was available. This caused unnecessary client-side cropping and inconsistent rendering compared to the explore page. ## What changed Swapped the first two conditions in `DiscoveryInstanceDetail.svelte` so that `representativeCroppedThumbnailUrl` is checked **first** — matching the explore page behavior. The CSS bbox crop fallback is preserved for domains without precomputed crops. ## Checklist - [x] `svelte-check` passes (0 errors, pre-existing warnings only) - [x] Single file changed: `apps/web/src/lib/components/DiscoveryInstanceDetail.svelte` - [x] No new imports needed (all helpers already in scope) - [x] CSS bboxCrop fallback preserved for domains without precomputed crops - [x] Version bump deferred to Senior Engineer
fix(web): prefer precomputed face crop on person detail page
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 7s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 3m59s
635964ad57
Aligns detail page with explore page behavior. Both pages now use
representativeCroppedThumbnailUrl when available. CSS bboxCrop remains
as fallback for domains without precomputed crops.
chore: bump version to v1.21.20
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 2m55s
a7ef31e653
chris merged commit 7a510965a5 into main 2026-07-21 21:58:17 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!687
No description provided.