refactor(discovery): unify thumbnail pipeline under single generic job type #666
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/generic-discovery-thumbnail"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
PR 2 of the generic discovery thumbnail pipeline. PR 1 (merged, v1.21.16) backfilled face bbox into occurrence_ref.scope. This PR makes the pipeline fully generic.
What changed
Generic enqueue (
WorkerJobEnqueueService):enqueueMissingDiscoveryThumbnailJobs[ForMedia]()— queriesclass_instance_occurrences.occurrence_reffor scope/bbox. Works for any domain.enqueueMissingFaceThumbnailJobsandenqueueMissingPlantThumbnailJobs.Generic worker handler (
MediaJobHandlers):generateDiscoveryThumbnail()dispatches ongenerate_discovery_thumbnailjob type.renderFaceThumbnailJpeg→renderRegionThumbnailJpeg(method was already generic).generateFaceThumbnailandgeneratePlantThumbnail.Generic result acceptance (
WorkerResultService):acceptDiscoveryThumbnail()stores derived asset withderived_type = 'discovery_thumbnail'.acceptFaceCandidates,acceptDiscoveryCandidate,acceptClassInstanceCandidatenow call generic enqueue method.acceptFaceThumbnailandacceptPlantThumbnail.Generic endpoint (
DerivedAssetController):GET /api/media/{mediaItemId}/instances/{classInstanceId}/thumbnail— domain-agnostic.Explore page: Removed
bboxCropStyleon cards — uses precomputed crop URLs only.URL fix:
ClassInstanceDiscoveryServicerepCroppedUrl now uses/instances/endpoint for all domains.Tests: Updated
MLResultAcceptanceTestandMediaMaintenanceServiceTestto match generic pipeline.Docs: Updated ADR 0094 and design spec with generic pipeline architecture section.
Files changed (13)
WorkerJobEnqueueService.javaMediaJobHandlers.javaWorkerResultService.javaDerivedAssetController.javaClassInstanceDiscoveryService.javaMediaMaintenanceService.javaWorkerResultBackfillRunner.javaexplore/+page.svelteMLResultAcceptanceTest.javaMediaMaintenanceServiceTest.java0094-*.json2026-07-20-*.mdgradle.propertiesVerification
./gradlew :apps:api:compileJava— BUILD SUCCESSFUL./gradlew :apps:worker-media:compileJava— BUILD SUCCESSFUL./gradlew :apps:api:test— 728 tests, 0 failuresnpx svelte-check— 0 errors (20 pre-existing warnings)PR 2 of the generic discovery thumbnail pipeline. - Add generic enqueue method: enqueueMissingDiscoveryThumbnailJobs[ForMedia]() queries class_instance_occurrences.occurrence_ref for scope/bbox. Replaces per-domain face/plant enqueue methods. - Add generic worker handler: generateDiscoveryThumbnail dispatches on 'generate_discovery_thumbnail' job type. - Add generic result acceptance: acceptDiscoveryThumbnail stores derived asset with derived_type='discovery_thumbnail'. - Add generic endpoint: GET /api/media/{id}/instances/{id}/thumbnail - Replace per-domain triggers in acceptFaceCandidates, acceptDiscoveryCandidate, acceptClassInstanceCandidate with generic enqueueMissingDiscoveryThumbnailJobsForMedia. - Replace per-domain triggers in MediaMaintenanceService with generic method. - Replace per-domain backfill in WorkerResultBackfillRunner with generic method. - Rename renderFaceThumbnailJpeg -> renderRegionThumbnailJpeg (method already generic). - Update explore page: remove bboxCropStyle on cards, use precomputed crop URLs only. - Fix repCroppedUrl to use /instances/ endpoint for all domains. - Deprecate old domain-specific methods (kept functional for in-flight jobs). - Update ADR 0094 and design spec with generic pipeline architecture. - Bump version to 1.21.17.