fix(ci): daily tests build + sequential web build + UUID join in suggestSimilarInstances #638

Merged
chris merged 3 commits from fix/suggestions-and-ci into main 2026-07-18 17:25:06 +02:00
Owner

What

Three fixes for two production issues:

1. CI: Daily Full Tests failing (run 1611)

Added npm run build before npm run test in .forgejo/workflows/daily-full-tests.yml:54. Playwright preview server needs build output.

2. CI: Post-merge build OOM (run 1613)

Made build-web depend on build-api in .forgejo/workflows/build-deploy.yml to prevent concurrent Gradle+Vite builds exhausting runner memory.

3. "No face match yet" bug (Spec 037)

suggestSimilarInstances() in ClassInstanceDiscoveryService.java had UUID mismatch: frontend passes faceAnnotationId (= discovery_results.id) but backend queried class_occurrence_embeddings.occurrence_id (= class_instance_occurrences.id). Fixed by JOIN through class_instance_occurrences using occurrence_key (TEXT column = discovery_results.id as VARCHAR).

Test

  • API tests pass
  • YAML validates
  • Compile clean

Version

1.21.2 → 1.21.3

Post-merge

After merge, deploy auto-runs. Verify suggestions dialog returns matches for faces in UI.

## What Three fixes for two production issues: ### 1. CI: Daily Full Tests failing (run 1611) Added `npm run build` before `npm run test` in `.forgejo/workflows/daily-full-tests.yml:54`. Playwright preview server needs build output. ### 2. CI: Post-merge build OOM (run 1613) Made `build-web` depend on `build-api` in `.forgejo/workflows/build-deploy.yml` to prevent concurrent Gradle+Vite builds exhausting runner memory. ### 3. "No face match yet" bug (Spec 037) `suggestSimilarInstances()` in `ClassInstanceDiscoveryService.java` had UUID mismatch: frontend passes `faceAnnotationId` (= `discovery_results.id`) but backend queried `class_occurrence_embeddings.occurrence_id` (= `class_instance_occurrences.id`). Fixed by JOIN through `class_instance_occurrences` using `occurrence_key` (TEXT column = `discovery_results.id` as VARCHAR). ## Test - API tests pass - YAML validates - Compile clean ## Version 1.21.2 → 1.21.3 ## Post-merge After merge, deploy auto-runs. Verify suggestions dialog returns matches for faces in UI.
fix(ci): add build step to daily tests + sequential web build
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 2m0s
d81c75d5a8
- daily-full-tests.yml: add 'npm run build' before 'npm run test' in Check web step
  (Playwright preview server needs build output)
- build-deploy.yml: make build-web depend on build-api to prevent concurrent OOM
  (sequential Gradle bootJar + Vite build avoids memory exhaustion)
fix(api): join class_instance_occurrences in suggestSimilarInstances to map faceAnnotationId
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m46s
d2b2b65df4
Frontend passes discovery_results.id as sourceOccurrenceId but old SQL
queried class_instance_occurrences.id directly. Added JOIN through
occurrence_key (VARCHAR) to resolve the UUID mismatch. Fixes step 0
(self-exclusion) and step 1 (source embedding lookup).
chore: bump version 1.21.2 → 1.21.3
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m37s
b45f8967d8
chris merged commit e075c0282c into main 2026-07-18 17:25:06 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!638
No description provided.