feat: generic instance suggestions API (Spec 037) #636

Merged
chris merged 2 commits from feat/037-instance-suggestions into main 2026-07-18 00:15:49 +02:00
Owner

Summary

  • New suggestSimilarInstances() in ClassInstanceDiscoveryService — domain-agnostic embedding similarity search
  • GET /api/discovery/domains/{domainKey}/instance-suggestions endpoint
  • OccurrenceCreatedEvent generalized with domainKey + classKey (backward-compatible 4-arg constructor deprecated)
  • PendingEmbeddingFlushListener now uses event params instead of hardcoded 'people'/'person'
  • Frontend: getFacePersonSuggestions() replaced with getInstanceSuggestions(domainKey, sourceOccurrenceId, opts)
  • personSuggestionsForFace() deprecated for removal

Test Results

  • ./gradlew :apps:api:test — all pass
  • svelte-check — 0 errors, 20 pre-existing warnings
## Summary - New `suggestSimilarInstances()` in `ClassInstanceDiscoveryService` — domain-agnostic embedding similarity search - `GET /api/discovery/domains/{domainKey}/instance-suggestions` endpoint - `OccurrenceCreatedEvent` generalized with `domainKey` + `classKey` (backward-compatible 4-arg constructor deprecated) - `PendingEmbeddingFlushListener` now uses event params instead of hardcoded `'people'`/`'person'` - Frontend: `getFacePersonSuggestions()` replaced with `getInstanceSuggestions(domainKey, sourceOccurrenceId, opts)` - `personSuggestionsForFace()` deprecated for removal ## Test Results - `./gradlew :apps:api:test` — all pass - `svelte-check` — 0 errors, 20 pre-existing warnings
feat: generic instance suggestions API (Spec 037)
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 22m33s
80f23f6934
- New suggestSimilarInstances() in ClassInstanceDiscoveryService
- GET /api/discovery/domains/{domainKey}/instance-suggestions endpoint
- OccurrenceCreatedEvent generalized with domainKey + classKey
- PendingEmbeddingFlushListener generalized for all domains
- Frontend: replace getFacePersonSuggestions() with getInstanceSuggestions()
- personSuggestionsForFace() deprecated for removal
fix: address review issues in generic suggestions
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m51s
e48f28d1f2
- Exclude self-matching in candidate query
- Clamp limit to [1, 100]
- Add domain_key filter to source embedding query
- Remove dead pattern variable
- Add representativePreviewUrl to suggestion results
chris merged commit e92080b0a0 into main 2026-07-18 00:15:49 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!636
No description provided.