fix: JDBC stream leak causing connection pool exhaustion #615

Merged
chris merged 4 commits from fix/connection-pool-leak into main 2026-07-14 20:08:45 +02:00
Owner

Problem

OwnerFaceEmbeddingsController.getOwnerFaceEmbeddings() used .stream() on JDBC query result (line 52), which opens a JDBC cursor that is never closed. This leaks connections until HikariCP pool is exhausted (50/50 active), causing HTTP 500 on ALL API endpoints including worker job claim.

Fix

Replace .stream().findFirst().orElse(null) with .optional().orElse(null) — avoids JDBC streaming entirely.

Codebase audit

Searched all .stream() calls across apps/api/src/. Every other usage is on .listOfRows() or .list() results (connection already closed before streaming). No other unmanaged JDBC streams found.

Version

Bump 1.09 → 1.10

## Problem `OwnerFaceEmbeddingsController.getOwnerFaceEmbeddings()` used `.stream()` on JDBC query result (line 52), which opens a JDBC cursor that is never closed. This leaks connections until HikariCP pool is exhausted (50/50 active), causing HTTP 500 on ALL API endpoints including worker job claim. ## Fix Replace `.stream().findFirst().orElse(null)` with `.optional().orElse(null)` — avoids JDBC streaming entirely. ## Codebase audit Searched all `.stream()` calls across `apps/api/src/`. Every other usage is on `.listOfRows()` or `.list()` results (connection already closed before streaming). No other unmanaged JDBC streams found. ## Version Bump 1.09 → 1.10
chris force-pushed fix/connection-pool-leak from fd7c1981fa
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Run scoped PR tests (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
to 717c9baefc
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Run scoped PR tests (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
2026-07-14 19:30:02 +02:00
Compare
test: trigger CI re-run after scope detection fix
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 2m22s
7b49491b21
chris merged commit 3643500e7d into main 2026-07-14 20:08:45 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!615
No description provided.