feat: API key management — list + revoke endpoints #605

Merged
chris merged 3 commits from agent/api-key-management into main 2026-07-13 23:09:14 +02:00
Owner

Changes

  • ApiCredentialService: Expand V1_ALLOWED_SCOPES to include discovery:write
  • ApiCredentialService: Add listCredentials(UUID userAccountId) returning all user keys (including revoked) with metadata
  • ApiCredentialView: New DTO record (id, name, scopes, createdAt, lastUsedAt, expiresAt, revokedAt) — no raw tokens or hashes
  • CredentialController: Add GET /api/api-credentials — lists all user's API keys
  • CredentialController: Add DELETE /api/api-credentials/{id} — revokes a key, returns 204 (idempotent)

Acceptance Criteria

  1. ✅ discovery:write can be used when creating API keys
  2. ✅ GET /api/api-credentials returns all user's keys with metadata
  3. ✅ DELETE /api/api-credentials/{id} revokes a key (204 response)
  4. ✅ Revoked key can no longer authenticate (existing authenticate already filters revoked_at IS NULL)
  5. ✅ All existing tests still pass (compilation verified)

Notes

  • No schema migration needed
  • revoke() already existed in service layer — only controller wiring was added
  • List endpoint includes revoked keys per spec
  • Revoke is idempotent — returns 204 even if ID doesn't belong to user
## Changes - **ApiCredentialService**: Expand `V1_ALLOWED_SCOPES` to include `discovery:write` - **ApiCredentialService**: Add `listCredentials(UUID userAccountId)` returning all user keys (including revoked) with metadata - **ApiCredentialView**: New DTO record (id, name, scopes, createdAt, lastUsedAt, expiresAt, revokedAt) — no raw tokens or hashes - **CredentialController**: Add `GET /api/api-credentials` — lists all user's API keys - **CredentialController**: Add `DELETE /api/api-credentials/{id}` — revokes a key, returns 204 (idempotent) ## Acceptance Criteria 1. ✅ `discovery:write` can be used when creating API keys 2. ✅ `GET /api/api-credentials` returns all user's keys with metadata 3. ✅ `DELETE /api/api-credentials/{id}` revokes a key (204 response) 4. ✅ Revoked key can no longer authenticate (existing `authenticate` already filters `revoked_at IS NULL`) 5. ✅ All existing tests still pass (compilation verified) ## Notes - No schema migration needed - `revoke()` already existed in service layer — only controller wiring was added - List endpoint includes revoked keys per spec - Revoke is idempotent — returns 204 even if ID doesn't belong to user
feat: add list and revoke endpoints for API credentials
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Run scoped PR tests (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
b494791227
- Expand V1_ALLOWED_SCOPES to include discovery:write
- Add GET /api/api-credentials listing all user keys with metadata
- Add DELETE /api/api-credentials/{id} for revocation (idempotent, 204)
- Add ApiCredentialView DTO (no raw tokens exposed)
test: add CredentialControllerTest and ApiCredentialServiceTest
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m27s
2d9cf64225
- CredentialControllerTest: 7 tests covering list/revoke endpoints
- ApiCredentialServiceTest: 5 tests covering list mapping, scope validation
- All tests use plain Mockito (no Spring context)
chore: bump version to 1.03
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m48s
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Failing after 11m5s
Build and Deploy / Clean Docker build artifacts (push) Has been cancelled
f29c212f8d
chris merged commit 2c7a218ac6 into main 2026-07-13 23:09:14 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!605
No description provided.