fix(web): show clustering max-distance section for all semisupervised methods (v1-v5) #1497

Merged
chris merged 3 commits from fix/admin-distance-visible-v5 into main 2026-11-13 08:53:50 +01:00
Owner

Problem

Production runs clustering_method = semisupervised-v5, but the Admin → Discovery → Faces & Clustering tab hid the Clustering-Maximaldistanz section entirely for v3/v4/v5: isSemisupervisedActive hardcoded ['semisupervised-v1','semisupervised-v2']. The single clustering parameter (clustering_max_distance, spec 050 / ADR 0101, one endpoint for all semisupervised methods) was therefore not changeable from the UI at all while v5 is active.

Fix

  • AdminDiscoveryTab.svelte: visibility predicate is now a prefix check (startsWith('semisupervised-')), preserving the draft-else-stored resolution semantics. Covers v1–v5 and future semisupervised methods.
  • Copy: dropped the hardcoded (semisupervised-v1) suffix from adminClusteringDistanceTitle in de/en/da.
  • Test: Playwright assertion that the section is visible and prefilled when semisupervised-v5 is the stored method (the production scenario; the dropdown itself still lists only v1/v2 — noted as follow-up).
  • KNOWN_ISSUES: logged as ISSUE-227 (med, area:web), including the dropdown/type-union gap as explicit follow-up.

Validation

  • npm run check in apps/web: 0 errors (pre-existing a11y warnings untouched)
## Problem Production runs `clustering_method = semisupervised-v5`, but the Admin → Discovery → Faces & Clustering tab hid the **Clustering-Maximaldistanz** section entirely for v3/v4/v5: `isSemisupervisedActive` hardcoded `['semisupervised-v1','semisupervised-v2']`. The single clustering parameter (`clustering_max_distance`, spec 050 / ADR 0101, one endpoint for all semisupervised methods) was therefore not changeable from the UI at all while v5 is active. ## Fix - `AdminDiscoveryTab.svelte`: visibility predicate is now a prefix check (`startsWith('semisupervised-')`), preserving the draft-else-stored resolution semantics. Covers v1–v5 and future semisupervised methods. - Copy: dropped the hardcoded `(semisupervised-v1)` suffix from `adminClusteringDistanceTitle` in **de/en/da**. - Test: Playwright assertion that the section is visible and prefilled when `semisupervised-v5` is the **stored** method (the production scenario; the dropdown itself still lists only v1/v2 — noted as follow-up). - KNOWN_ISSUES: logged as **ISSUE-227** (med, area:web), including the dropdown/type-union gap as explicit follow-up. ## Validation - `npm run check` in apps/web: 0 errors (pre-existing a11y warnings untouched)
fix(web): show clustering max-distance section for all semisupervised methods (v1-v5)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 5m31s
f61c2f9ec5
Production runs semisupervised-v5, whose hardcoded v1/v2 visibility check hid
the only control for its clustering_max_distance parameter.
docs: ISSUE-227 known issue + Danish title suffix dropped (follow-up to distance-visibility fix)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 11m49s
6c9a19e250
fix(web): list semisupervised-v3/v4/v5 in clustering-method dropdown
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 10m55s
c8ae411873
The backend allowlist (PeopleClusteringResetController.ALLOWED_CLUSTERING_METHODS)
already accepted these three methods; the admin UI dropdown did not list them.
Production runs semisupervised-v5 (set via the DB so far), so the value was
unreachable from the UI.

Also bumps the option-count assertion in the existing dropdown test from 5 to 8
and adds dropdown-path coverage: selecting semisupervised-v5 reveals the
distance section.
chris merged commit 42415f571e into main 2026-11-13 08:53:50 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1497
No description provided.