refactor(api): WorkerResultService splittet — ét handler-objekt per resultattype (review fase 4C) #1493

Merged
chris merged 2 commits from refactor/worker-result-registry into main 2026-11-12 17:32:09 +01:00
Owner

WorkerResultService (3.649 linjer) reduceret til 470: submitResult's 16-grenede resultType-diskriminator og den tredje typeliste-kopi (supportedResultType) erstattet af et fail-fast handler-registry, samme mønster som 4B's MediaJobHandlers-split.

Nye klasser (15 handlers + 6 delt plumbing + interface):

  • WorkerResultHandler (interface: resultType(), aliases(), accept())
  • DerivedAssetResultHandler (derived_asset + profile_photo_crop/profile_photo-aliases)
  • MetadataCandidateResultHandler / PerceptualHashResultHandler
  • ThumbnailResultHandlers: Plant-, Discovery- (inkl. face-crop-gren), FaceScopeThumbnailHandler
  • VisualConceptCandidateResultHandler / SemanticEmbeddingResultHandler
  • DiscoveryCandidateResultHandler / AlbumShapeProposalResultHandler (2 typer)
  • ClassInstanceCandidateResultHandler (spec 050/ADR 0101-0116 envelope-matrix flyttet ordret)
  • BackfillResultHandlers: OwnerFaceEmbedding- (ISSUE-049) + OwnerFaceAttributeBackfillHandler
  • ModelConversionResultHandler / IssueResultHandler
  • Delt: WorkerResultPayload, WorkerResultJobContext, WorkerResultGuards, WorkerResultDerivedAssetWriter, WorkerResultEmbeddingWriter, WorkerResultLandmarks

Transaktionsgrænser 1:1: handlers er plain method calls inde i submitResult's eksisterende @Transactional — ingen nye grænser. Semisupervised-stien bevarer rækkefølgen: envelope-validering FØR clustering-reset-barriere FØR staleness-læsning FØR persistens. Idempotens-replay, shouldCompleteJob (complete-flag på multi-variant-typer), thumbnails_ready og WorkerJobCompletedEvent uændrede. Ukendt resultType fejler med samme IllegalArgument-message (registry'et ER allow-listen nu — kopien slettet).

Kompatibilitet: den gamle 10-arg konstruktør bevaret (bygger produktion-handlers) så de ~16 H2-testfixtures kører uændrede; Spring bruger ny @Autowired List-konstruktør.

Tests: eksisterende WorkerResult-suite grøn uændret (kun 3 refleksions-pins flyttet mekanisk til de nye hjem). Ny WorkerResultHandlerRegistryTest: ukendt type → historisk besked + ingen persistens; dublet-registrering → fail-fast; alias → samme handler-instans. Fuld :apps:api:test: 2572 tests, 0 failures, 0 errors, 9 skipped. :apps:worker-media:compileJava grøn (API-kontrakt uændret).

Afvigelse/opfølgning: SemisupervisedMethod-enum (metode→kontraktversion-matrix spejlet mellem WorkerResultService og WorkerJobEnqueueService + ClassInstanceDiscoveryService.isSemisupervisedMethod) IKKE udført — kræver kryds-package-koordinering med discovery/ og offentlige konstanter der bruges af Postgres-tests; anbefales som egen opfølgning.

WorkerResultService (3.649 linjer) reduceret til 470: submitResult's 16-grenede resultType-diskriminator og den tredje typeliste-kopi (supportedResultType) erstattet af et fail-fast handler-registry, samme mønster som 4B's MediaJobHandlers-split. **Nye klasser (15 handlers + 6 delt plumbing + interface):** - WorkerResultHandler (interface: resultType(), aliases(), accept()) - DerivedAssetResultHandler (derived_asset + profile_photo_crop/profile_photo-aliases) - MetadataCandidateResultHandler / PerceptualHashResultHandler - ThumbnailResultHandlers: Plant-, Discovery- (inkl. face-crop-gren), FaceScopeThumbnailHandler - VisualConceptCandidateResultHandler / SemanticEmbeddingResultHandler - DiscoveryCandidateResultHandler / AlbumShapeProposalResultHandler (2 typer) - ClassInstanceCandidateResultHandler (spec 050/ADR 0101-0116 envelope-matrix flyttet ordret) - BackfillResultHandlers: OwnerFaceEmbedding- (ISSUE-049) + OwnerFaceAttributeBackfillHandler - ModelConversionResultHandler / IssueResultHandler - Delt: WorkerResultPayload, WorkerResultJobContext, WorkerResultGuards, WorkerResultDerivedAssetWriter, WorkerResultEmbeddingWriter, WorkerResultLandmarks **Transaktionsgrænser 1:1:** handlers er plain method calls inde i submitResult's eksisterende @Transactional — ingen nye grænser. Semisupervised-stien bevarer rækkefølgen: envelope-validering FØR clustering-reset-barriere FØR staleness-læsning FØR persistens. Idempotens-replay, shouldCompleteJob (complete-flag på multi-variant-typer), thumbnails_ready og WorkerJobCompletedEvent uændrede. Ukendt resultType fejler med samme IllegalArgument-message (registry'et ER allow-listen nu — kopien slettet). **Kompatibilitet:** den gamle 10-arg konstruktør bevaret (bygger produktion-handlers) så de ~16 H2-testfixtures kører uændrede; Spring bruger ny @Autowired List<WorkerResultHandler>-konstruktør. **Tests:** eksisterende WorkerResult-suite grøn uændret (kun 3 refleksions-pins flyttet mekanisk til de nye hjem). Ny WorkerResultHandlerRegistryTest: ukendt type → historisk besked + ingen persistens; dublet-registrering → fail-fast; alias → samme handler-instans. Fuld :apps:api:test: 2572 tests, 0 failures, 0 errors, 9 skipped. :apps:worker-media:compileJava grøn (API-kontrakt uændret). **Afvigelse/opfølgning:** SemisupervisedMethod-enum (metode→kontraktversion-matrix spejlet mellem WorkerResultService og WorkerJobEnqueueService + ClassInstanceDiscoveryService.isSemisupervisedMethod) IKKE udført — kræver kryds-package-koordinering med discovery/ og offentlige konstanter der bruges af Postgres-tests; anbefales som egen opfølgning.
submitResult's 16-grenede string-diskriminator og supportedResultType-kopien
(#3 af samme typeliste) erstattet af et fail-fast handler-registry
(Map<String, WorkerResultHandler> bygget fra Spring-samlet List — dubletter
er en wiring-bug, samme mønster som worker-side MediaJobDispatcher).

Nye handler-klasser (én per resultattype, 18 wire-typer inkl. aliases):
- DerivedAssetResultHandler (derived_asset + profile_photo_crop/profile_photo)
- MetadataCandidateResultHandler, PerceptualHashResultHandler
- ThumbnailResultHandlers.{Plant,Discovery,FaceScope}ThumbnailHandler
- VisualConceptCandidateResultHandler, SemanticEmbeddingResultHandler
- DiscoveryCandidateResultHandler, AlbumShapeProposalResultHandler
  (album_shape_proposal_result + album_shape_model_result)
- ClassInstanceCandidateResultHandler (spec 050 envelope-matrix flyttet 1:1)
- BackfillResultHandlers.{OwnerFaceEmbedding,OwnerFaceAttribute}BackfillHandler
- ModelConversionResultHandler, IssueResultHandler

Delt plumbing: WorkerResultPayload (payload-læsning/JSON), WorkerResultJobContext
(job/artifact-læsning), WorkerResultGuards (ownership/representant),
WorkerResultDerivedAssetWriter (upsert + filesystem backend),
WorkerResultEmbeddingWriter (coe/pending), WorkerResultLandmarks.

Adfærd 1:1: submitResult bevarer idempotens, lease/staleness-guards,
shouldCompleteJob, thumbnails_ready og completed-events; handlers kører som
plain calls i samme @Transactional-grænse. Ukendt type fejler med samme
IllegalStateException-tekst (tidligere via allow-listen — registry'et ER
listen nu). 10-arg konstruktøren bevaret som convenience der bygger
produktion-handlers; Spring bruger den nye List-baserede @Autowired.

Tests: WorkerResultHandlerRegistryTest (ukendt type → historisk besked og
ingen persistens, dublet → fail-fast, alias → samme handler-instans).
Tre refleksions-pins flyttet mekanisk til deres nye hjem
(jsonFromObject → WorkerResultPayload, upsert/buffer → WorkerResultEmbeddingWriter,
supportedResultType → resultType() på ModelConversionResultHandler).
WorkerResultService: 3649 → 470 linjer.
chore: version 1.21.114
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 2m19s
71138c19a1
chris merged commit 1ec3bdf248 into main 2026-11-12 17:32:09 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1493
No description provided.