feat(android): filter-only search + people empty-state timing fix #1462

Merged
chris merged 2 commits from feat/android-filter-only-search into main 2026-10-31 14:25:32 +01:00
Owner

Filter-only search (Android ≙ Web)

Auf dem Web kann man in der Suche nach Jahr filtern, ohne Suchtext einzugeben. Auf Android verweigerte die Suche bisher: die Chips (Jahr/Favorit/Person) erzeugten nur dann eine Anfrage, wenn mindestens zwei Zeichen im Feld standen.

  • Server-Seite war längst fertig: SearchService durchstöbert die gefilterte Menge (neueste zuerst), wenn kein Text übrig bleibt (bestehende Filter-only-Legs).
  • Contract core-api.openapi.yaml: q bleibt Pflicht, aber minLength: 2 → 1; Beschreibung dokumentiert Filter-only-Browsing mit Parametern.
  • Android: buildSearchRequest baut bei aktiven Chips und leerem/zu kurzem Feld eine Anfrage mit q="" + Filter-Parametern; ohne Filter bleibt es bei null. SearchViewModel/SearchScreen steuern den Hinweis („Tippe mindestens zwei Buchstaben …“) über hasRunnableSearch.
  • Der getippte year:/from:/to:-Token-Guard gilt unverändert auf dem Volltext-Pfad.

Tests: SearchQueryTest/SearchViewModelTest/HttpSearchApiTest erweitert (q=""-Roundtrip, Chip-only-Suchen, Räum-Verhalten); API-Seite neuer SearchServiceTest emptyQueryWithYearParamBrowsesThatYearNewestFirst. ./gradlew :app:testDebugUnitTest :core:test → 92 Suites, 0 Fehler; rtk ./gradlew :apps:api:test --tests dev.memories.api.search.* → 115 Tests, 0 Fehler.

People empty state

Der Leerzustand-Text behauptete weiterhin, die Erkennung dauere nach dem Upload eine Weile — meist dauert es nur Minuten. Statt die Angabe zu korrigieren, ist sie komplett entfernt (de/en/da); die Erklärung zum Gruppieren-Schwellenwert bleibt. Stale KDoc in EmptyPeople angepasst.

Kein versionName-Bump (separater release-Commit wie üblich).

## Filter-only search (Android ≙ Web) Auf dem Web kann man in der Suche nach Jahr filtern, ohne Suchtext einzugeben. Auf Android verweigerte die Suche bisher: die Chips (Jahr/Favorit/Person) erzeugten nur dann eine Anfrage, wenn mindestens zwei Zeichen im Feld standen. - Server-Seite war längst fertig: `SearchService` durchstöbert die gefilterte Menge (neueste zuerst), wenn kein Text übrig bleibt (bestehende Filter-only-Legs). - Contract `core-api.openapi.yaml`: `q` bleibt Pflicht, aber `minLength: 2 → 1`; Beschreibung dokumentiert Filter-only-Browsing mit Parametern. - Android: `buildSearchRequest` baut bei aktiven Chips und leerem/zu kurzem Feld eine Anfrage mit `q=""` + Filter-Parametern; ohne Filter bleibt es bei null. `SearchViewModel`/`SearchScreen` steuern den Hinweis („Tippe mindestens zwei Buchstaben …“) über `hasRunnableSearch`. - Der getippte `year:`/`from:`/`to:`-Token-Guard gilt unverändert auf dem Volltext-Pfad. **Tests:** SearchQueryTest/SearchViewModelTest/HttpSearchApiTest erweitert (q=""-Roundtrip, Chip-only-Suchen, Räum-Verhalten); API-Seite neuer SearchServiceTest `emptyQueryWithYearParamBrowsesThatYearNewestFirst`. `./gradlew :app:testDebugUnitTest :core:test` → 92 Suites, 0 Fehler; `rtk ./gradlew :apps:api:test --tests dev.memories.api.search.*` → 115 Tests, 0 Fehler. ## People empty state Der Leerzustand-Text behauptete weiterhin, die Erkennung dauere nach dem Upload eine Weile — meist dauert es nur Minuten. Statt die Angabe zu korrigieren, ist sie komplett entfernt (de/en/da); die Erklärung zum Gruppieren-Schwellenwert bleibt. Stale KDoc in `EmptyPeople` angepasst. Kein versionName-Bump (separater release-Commit wie üblich).
Selecting a year, favourite or person with an empty search box now browses
the filtered set newest-first, matching web behaviour. The server already
browses filter-only queries; the contract keeps q required but relaxes
minLength to 1, and the Android client sends q="" alongside the filter
parameters instead of refusing to search. The two-letter hint only shows
when neither a query nor a filter is runnable.
fix(android): people empty state drops the recognition timing claim
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 9m40s
Build and Deploy / Android unit tests and debug APK (push) Successful in 4m14s
881f99a5d3
The copy still told family members that recognition takes time after
upload — it usually finishes within minutes, so the time statement is
removed entirely rather than corrected. The grouping-threshold
explanation stays; the stale EmptyPeople KDoc now matches.
chris merged commit ec90e75cb0 into main 2026-10-31 14:25:32 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1462
No description provided.