fix(discovery): dead manual pin falls through instead of blanking the thumbnail; stabilize representative test #1441
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/representative-thumbnail-flake"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes the intermittent
PersonRelationServicePostgresTest.theChosenRepresentativeWinsOverTheLatestOccurrencefailure that flaked CI on PR #1437 (run 5937) — verified pre-existing on clean main (2-of-4 fresh-rerun failure matrix on a pristine origin/main worktree, unrelated to the search branch).Root cause — three stacked defects
representative_occurrence_idpointer without themanual_selectionprovenance pair, so the resolver never honored it — the test always exercised the terminal fallback ladder.cio.id DESCtiebreak → coin flip.unresolved.isEmpty()early return skipped rules 2/3, blanking the thumbnail across every surface. Violates the documented ADR-0114 contract (never blank on a dead pin).Fix
resolveValidatedPinnedOccurrencesreturns rejected-pin ids;resolveChunkre-queues them into the unresolved candidate set so rules 2/3 run. Pinned still always wins while resolvable.deadManualPinFallsThroughInsteadOfBlankingTheThumbnail— red on unpatched resolver.Validation
10/10 consecutive green
--rerunruns of the target class;dev.memories.api.people.*+ representative/face/self-person suites green; compile clean. Issue logged as ISSUE-223.