fix(web): grid refresh after suggestion decisions no longer flashes skeletons #1439
Open
chris
wants to merge 2 commits from
fix/suggestion-grid-skeleton-flash into main
pull from: fix/suggestion-grid-skeleton-flash
merge into: chris:main
chris:main
chris:docs/issue-237-resolve
chris:fix/android-viewer-rotation-empty
chris:chore/release-android-0.10.25
chris:fix/android-timeline-filter-ux
chris:fix/android-video-playback
chris:chore/release-upload-session
chris:feat/activity-cards-vB
chris:feat/upload-session-operations
chris:feat/upload-planned-count
chris:chore/release-notes-convention
chris:chore/release-android-0.10.23
chris:feat/settings-power-exemption
chris:chore/android-r8-minify
chris:docs/android-changelog-compact
chris:release/android-0.10.21
chris:fix/android-timeline-thumb-refresh
chris:fix/android-upload-filename-peritem
chris:fix/android-filter-chips
chris:test/stale-upload-session-acceptance
chris:chore/review-deploy-070-trigger
chris:spec/070-stale-upload-sessions
chris:specs/stale-upload-sessions
chris:docs/listing-tagline
chris:fix/feature-graphic-cards
chris:feat/play-feature-tagline
chris:fix/play-icon-generator
chris:docs/logo-generation
chris:feat/play-graphics
chris:docs/play-enus-convention
chris:feat/v6-pool-sharpness-floor
chris:docs/adr-0123-sharpness-floor
chris:feat/v6-pool-emission-quality-gate
chris:docs/adr-0123-pool-quality-gate
chris:feat/v6-gated-cv-sweep
chris:feat/v6-medoid-representatives
chris:docs/adr-0120-multi-medoid-representatives
chris:feat/web-anchor-min-confidence
chris:fix/web-v6-dropdown
chris:feat/semisupervised-v6-anchor-gate
chris:docs/adr-0119-anchor-quality-gate
chris:docs/issue228-worker-result-outage
chris:fix/worker-result-handler-beans
chris:fix/admin-distance-visible-v5
chris:ui/remove-most-similar-badge
chris:refactor/batch3-embedding-semisupervised
chris:refactor/row-helpers
chris:refactor/worker-result-registry
chris:refactor/media-visibility-sql
chris:fix/on-this-day-card-separation
chris:refactor/media-job-handlers-split
chris:docs/known-issue-226-dialog-overflow
chris:feat/on-this-day-years-back-web
chris:feat/on-this-day-years-back
chris:fix/e2e-flaky-playwright
chris:chore/review-phase3-di-convention
chris:fix/review-phase1-correctness
chris:chore/review-phase2-dead-code
chris:fix/gradle-properties-markers
chris:fix/carousel-append-resync
chris:feat/similar-first-suggestion-ranking
chris:feat/timeline-selection-download
chris:docs/issue-230-ci-runner-cache
chris:chore/spec-070-complete
chris:feat/media-ownership-transfer
chris:fix/suggestions-carousel-empty-page
chris:spec/070-media-ownership-transfer
chris:fix/069-gendered-partner-labels
chris:docs/spec-069-complete
chris:fix/stranded-tentative-cards
chris:feat/069-person-attributes
chris:feat/068-gate-partitioner
chris:fix/issue225-known-issue
chris:fix/media-viewer-ambiguous-confirm
chris:feat/068-mivolo-v2-age-model
chris:feat/auto-backup-triggers
chris:feat/android-filter-only-search
chris:fix/activity-system-operations-aggregate
chris:fix/attribute-backfill-capability
chris:feat/068-generation-gap-gate
chris:fix/processing-summary-duplicate-operation-keys
chris:docs/known-issues-flake-close-2026-10-31
chris:fix/tentative-refresh-dom-identity
chris:refactor/split-timeline
chris:refactor/split-discovery-review
chris:feat/068-birth-year-profiles
chris:feat/web-selection-shrink
chris:feat/068-age-attribute-backfill
chris:refactor/e2e-shared-shell-mocks
chris:docs/known-issues-flake-audit-2026-10-30
chris:fix/scope-zoom-asset-day-wall
chris:fix/e2e-hydration-gate
chris:ci/playwright-artifacts-flake-detection
chris:feat/068-core-age-persistence
chris:feat/068-age-gender-profiles
chris:fix/people-fallback-occurrence-scope
chris:fix/representative-thumbnail-flake
chris:fix/stale-suggestion-invalidation
chris:feat/search-filename-web
chris:feat/search-filename-token
chris:feat/remove-tile-overlays
chris:docs/issue216-ci-flake-family
chris:feat/score-tentative-actions
chris:docs/issue220-resolve
chris:fix/mobile-scroll-in-selection
chris:docs/issue-registry-upload-timeout
chris:ui/remove-suggestions-background-banner
chris:fix/ambiguous-suggestion-copy
chris:docs/issue217-close
chris:fix/suggestions-similar-copy
chris:feat/hac-average-registry
chris:fix/score-wall-shift-range
chris:feat/landmark-regression-api
chris:fix/backfill-superseded-arm
chris:feat/backfill-pending-faces
chris:fix/backfill-box-doubleencode
chris:feat/face-backfill-source-pair
chris:feat/face-alignment-api
chris:feat/face-landmark-alignment
chris:fix/web-favicon-cache-bust
chris:fix/web-favicon-background
chris:feat/web-favicon-dark
chris:feat/android-timeline-live-updates
chris:fix/face-marker-assigned-border
chris:feat/android-map-reset-view
chris:release/logo-changelog
chris:release/0.10.18
chris:fix/backup-retry-backoff
chris:feature/app-logo-v3
chris:fix/known-issues-renumber-211
chris:fix/upload-receive-connection-leak
chris:fix/android-timeline-refresh-after-backup
chris:fix/map-empty-viewport-clamp
chris:release/android-0.10.15
chris:release/1.21.83
chris:fix/backup-button-stuck-enqueued
chris:feature/people-empty-state-hint
chris:feat/processing-operations
chris:feat/activity-dialog-causes
chris:release/android-0.10.13
chris:backup-tab-settings
chris:feat/activity-dialog-rows
chris:release/android-0.10.12
chris:fix/android-battery-exemption
chris:fix/android-media-location-request
chris:docs/android-01011-changelog-wizard
chris:feat/android-onboarding-wizard
chris:docs/nicht-in-memories-design
chris:docs/known-issues-audit
chris:docs/avd-media-scan
chris:feature/app-logo
chris:release/android-0.10.0-version
chris:release/android-0.10.0
chris:feature/parity-android-usability
chris:docs/sanitize-infra-details
chris:docs/data-safety-deletion-fix
chris:docs/signin-listing-fix
chris:fix/review-model-seed-busybox
chris:feat/review-people-worker
chris:feat/review-reseed
chris:feat/activity-active-only
chris:feat/review-real-photos
chris:feat/review-ml-worker
chris:fix/review-local-tls
chris:feat/cv-highest-valid-cut-v2
chris:fix/review-deploy-trigger
chris:fix/review-seed-env
chris:fix/review-seed-mount
chris:fix/review-seed-dependency
chris:feat/play-review-instance
chris:docs/privacy-contact-alias
chris:docs/privacy-policy-wiki
chris:docs/privacy-policy
chris:release/android-v0.9.4
chris:android-release-signing
chris:android-play-readiness
chris:docs/adr-0116-highest-valid-cut
chris:fix/v4-margin-demotion-envelope-shape
chris:feat/semisupervised-v4-worker
chris:feat/semisupervised-v4-api
chris:docs/adr-0116-identity-aware-hac
chris:feat/assignment-cv-v4-identity-hac
chris:docs/spec-066-task-bookkeeping
chris:spec/066-share-access-log-web
chris:spec/066-share-access-log-api
chris:fix/android-711-media-permission
chris:chore/issue-172-status
chris:fix/video-rotation-dims
chris:fix/065-zip-original-key
chris:chore/issue-170-ci-registry-flake
chris:feat/065-share-download-toggle
chris:feat/065-share-viewer-ux
chris:fix/065-share-contract
chris:feat/065-album-public-share-web
chris:feat/065-album-public-share-links-web
chris:feat/trash-empty
chris:fix/cleanup-hub-trash-loadmore
chris:fix/nav-cleanup-order
chris:feat/duplicates-keep-prefill-hover
chris:fix/activity-dialog-transparency
chris:feat/duplicates-group-date-sort
chris:feature/duplicate-hash-v2
chris:fix/duplicate-threshold
chris:feat/cleanup-nav
chris:feat/cleanup-ui
chris:feat/cleanup-duplicates-backend
chris:release/0.9.0
chris:release/1.21.82
chris:docs/adr-0114-accepted-only
chris:spec/064-complete-status
chris:spec/064-artifacts
chris:spec/064-android
chris:spec/064-web
chris:spec/064-api
chris:feat/rep-thumb-api
chris:feat/rep-thumb-worker
chris:fix/android-access-media-location
chris:feat/representative-thumbnail
chris:fix/album-window-recent-first
chris:docs/adr-0113-v6-measurement
chris:fix/gps-null-island
chris:feature/album-suggestion-auto-trigger
chris:feat/rep-cache-worker
chris:feat/rep-cache-api
chris:docs/adr-0113-accepted
chris:docs/adr-0113-g4-results
chris:fix/release-tentative-canonical-uuid
chris:feat/album-suggestion-date-order
chris:fix/v3-contract-version-stamps
chris:docs/adr-0113-g1-adjudication
chris:docs/adr-0113-g1-results
chris:feat/assignment-cv-graph-mode
chris:feat/semisupervised-v3-worker
chris:feat/semisupervised-v3-api
chris:docs/spec-063-tasks
chris:feat/mobile-header-declutter
chris:feat/representative-density-graph-prototype
chris:docs/adr-0113-representative-graph
chris:feat/063-multilevel-derived
chris:fix/face-suggest-slow
chris:fix/face-suggest-perf-thumbs
chris:fix/worker-jobs-retention-summary-cost
chris:docs/spec-063-derived
chris:feat/063-derived-relations
chris:ux/face-assign-dialog-copy
chris:chore/api-heap-cap
chris:fix/face-suggest-self-exclusion
chris:feat/063-relations-carousel
chris:fix/album-suggestion-min-size
chris:feat/063-neutral-relations
chris:fix/album-suggestion-thumbnails
chris:feat/063-person-picker-filter
chris:docs/spec-063-complete
chris:docs/spec-063-bookkeeping
chris:feat/063-person-relations-web
chris:feat/063-person-relations-api
chris:release/0.8.0
chris:feat/062-viewer-autoplay
chris:docs/spec-060-062-bookkeeping
chris:release/0.7.0
chris:feat/061-cast-crop-api
chris:feat/061-cast-crop-android
chris:feat/android-cast-ux-round2
chris:fix/media-token-serializable
chris:release/0.6.0
chris:release/1.21.81
chris:feature/060-cast-api
chris:feature/060-cast-android
chris:docs/android-cast-chromecast
chris:feat/059-video-backfill
chris:release/1.21.80
chris:ux/topbar-place-enter-pick
chris:feat/059-video-support
chris:fix/topbar-place-search-refocus
chris:release/0.5.4
chris:fix/map-viewer-sidebar-items
chris:release/0.5.3
chris:feat/map-sidebar-date-sections
chris:fix/viewer-zoom-neighbor
chris:release/v0.66
chris:fix/upload-spec-check
chris:feature/i18n-extraction-wave5
chris:release/0.5.2
chris:feat/place-search-ui
chris:ux/map-split-zoom
chris:feat/android-ci-image
chris:release/0.5.1
chris:ux/map-overlay-controls
chris:feat/place-search-api
chris:ux/map-tablet-split-layout
chris:feat/android-releases
chris:ux/map-tap-zoom
chris:perf/map-viewport-api
chris:feature/i18n-extraction-wave3
chris:feature/i18n-extraction-wave4
chris:feature/i18n-switcher-design
chris:feature/i18n-extraction-wave2
chris:feature/i18n-locale-sync
chris:fix/main-e2e-preexisting-failures
chris:feature/i18n-paraglide-infra
chris:feature/i18n-user-locale
chris:ux/face-thumbnails-density
chris:ux/map-media-sidebar
chris:feat/search-date-filters
chris:feat/057-avatar-in-app-shell
chris:fix-ci-version-shallow
chris:fix/sticky-header-checkbox-stack
chris:fix/057-photo-picker-gallery
chris:feat/on-this-day-taller-row
chris:docs/057-close-spec
chris:feat/on-this-day-compact-cards
chris:chore/document-profile-photo-crop-complete-protocol
chris:feat/057-self-person-frontend
chris:android/people-sort-by-media-count
chris:feat/057-self-person-worker-crop
chris:docs/manual-face-bbox-design
chris:feat/057-self-person-backend
chris:ci/android-key-onboarding
chris:faces-direct-assign
chris:fix/on-this-day-modal-scroll-chaining
chris:fix/android-stable-debug-keystore
chris:ux-android-map-polish
chris:feat/on-this-day-modal
chris:docs/issue-140-resolved
chris:fix/issue-140-suggest-thumb-latency
chris:docs/issue-112-resolved
chris:fix/issue-112-suggest-similar-thumbnails
chris:spec/057-self-person-identity-and-profile-photo
chris:docs/issue-138-resolved
chris:fix/on-this-day-api-context
chris:docs/spec-056-on-this-day
chris:feat/on-this-day-backend
chris:feat/on-this-day-web
chris:fix/people-discovery-endpoints
chris:feat/search-face-filters
chris:fix/map-marker-thumbnails
chris:feat/person-sticky-header
chris:fix/viewer-vm-scope
chris:fix/toast-mobile-placement
chris:docs/spec-055-android-ux
chris:fix/toast-status-messages
chris:ux-android-upload
chris:fix/people-reconcile-loop
chris:feat/person-score-selection
chris:ux-android-map
chris:ux-android-minsdk
chris:ux-android-people
chris:fix/person-score-tentative-badge
chris:ux-android-albums
chris:ux-android-search
chris:feat/person-score-filters-autoscroll
chris:ux-android-timeline
chris:ux-android-viewer-actions
chris:ux-android-foundation
chris:fix/storage-availability-constructor
chris:feat/person-face-score-sort
chris:ux-android-viewer
chris:feat/search-approval-filter
chris:feat/map-satellite-layer-toggle
chris:feat/map-satellite-tile-provider
chris:tentative-open-media
chris:fix/history-rejected-label
chris:feat/history-rejected-thumbnails
chris:fix/map-location-override
chris:fix/viewer-tentative-gate-buttons
chris:chore/redeploy-main-noop
chris:feat/person-history-rejected-api
chris:spec/052-confirm-reject-tentative-face-assignments
chris:feat/explore-titles-first
chris:feat/person-history-rejected-web
chris:fix/ranking-thumbnail-representative
chris:ci/registry-to-forgejo
chris:chore/fix-stale-centroid-comments
chris:fix/person-ranking-picker-latency
chris:fix/picker-ranking-cache
chris:feat/carousel-append-freeze-only-if-visible
chris:feat/suggestion-id-admin-only
chris:feat/suggestion-id-chip
chris:feat/admin-logs-hscroll
chris:feat/api-multi-representant-ranking
chris:fix/carousel-stored-target-title
chris:feat/multi-representant-person-centroids
chris:experiment/cv-multi-medoid
chris:fix/stale-suggestions-hygiene
chris:experiment/assignment-cross-validation
chris:fix/suggestions-require-named-targets
chris:perf/stash-antijoin-postfilter
chris:perf/carousel-paging-count-skip
chris:fix/carousel-freeze-1s
chris:fix/carousel-button-stability
chris:feat/picker-person-avatars
chris:feat/worker-confidence-target-uncertainty
chris:feat/merge-suggestion-confidence-score
chris:test/pw-worker-tuning
chris:docs/issue-107-archive
chris:feat/admin-cards-oversigt-tab
chris:feat/profile-tabs
chris:feat/face-crops-activity-lane
chris:feat/decision-history-revert
chris:feat/decision-history-api
chris:feat/decision-history-web
chris:docs/spec-053-decision-history
chris:feat/face-scope-crop-web
chris:fix/face-scope-crop-backend
chris:docs/spec-052-face-scope-crops
chris:fix/web-stale-sibling-cards
chris:feat/carousel-face-zoom-web
chris:fix/pending-overlap-mint-guard
chris:feat/carousel-face-zoom-api
chris:fix/stash-occupancy-and-suppression
chris:fix/stash-feedback-web
chris:fix/tentative-badge-consistency
chris:docs/known-issues-tentative-integration
chris:fix/tentative-counts
chris:fix/person-page-tentative-accept
chris:feat/carousel-face-bbox
chris:fix/soft-reset-keep-stashed
chris:fix/person-name-duplicate-hints
chris:docs/known-issues-carousel-blank
chris:fix/recognition-run-ux
chris:docs/known-issues-timeout-loop
chris:fix/core-clustering-method-stamp
chris:fix/quality-score-absolute-c-isolation
chris:fix/hac-scalable-heap-partition
chris:feat/semisupervised-v2-average-linkage
chris:design/linkage-average-proposal
chris:experiment/linkage-comparison
chris:feat/suggestion-quality-score
chris:feat/suggestion-quality-score-ui
chris:docs/known-issues-fallback-triggers
chris:fix/recluster-background-watch
chris:fix/capture-year-guard
chris:feat/tentative-movable-pool
chris:feat/tentative-ui-marking
chris:fix/heic-dimensions-extraction
chris:feat/recluster-status-api
chris:feat/recluster-suggestions-ui
chris:feat/face-zoom-just-fit
chris:feat/tentative-payload-state
chris:fix/score-align-api
chris:fix/score-align-web
chris:fix/edge-face-zoom-centering
chris:fix/instance-remove-in-place-refresh
chris:fix/subset-newperson
chris:feat/vis-omrade-face-zoom
chris:feat/timeline-titles-first
chris:fix/dialog-subset-noop
chris:feat/timeline-days-query-speed
chris:docs/issue-090-consolidate
chris:feat/merge-card-redesign
chris:feat/decision-subset-refs
chris:fix/stash-409-conflict
chris:fix/web-redeploy-spec051
chris:fix/stash-away-already-assigned
chris:docs/agents-codegraph
chris:fix/gradle-cache-lock
chris:feat/timeline-instant-placeholders
chris:chore/redeploy-web-people-worker
chris:docs/issue-089-archive
chris:fix/api-boot-ctor
chris:feat/semisupervised-clustering
chris:fix/instance-confirmation-filter
chris:feat/timeline-desktop-toolbar
chris:fix/api-jackson-string-limit
chris:docs/clustering-known-issues
chris:fix/face-recognition-job-label
chris:fix/face-feed-owner-recognized
chris:fix/people-clustering-run-logs
chris:fix/tentative-icon-buttons-mobile
chris:docs/known-issues-081-082
chris:feat/processing-operations-backend
chris:feat/processing-operations-web
chris:chore/web-redeploy-trigger
chris:hotfix/discovery-executor-qualifier
chris:fix/reprocess-all-batching
chris:feat/constrained-forward-web
chris:feat/constrained-forward-worker
chris:feat/constrained-forward-core
chris:docs/adr0100-constrained-forward
chris:fix/cancelled-upload-visibility
chris:chore/api-deploy-trigger
chris:docs/issue-060-mitigated
chris:docs/issue-076-resolved
chris:fix/deploy-env-file-path
chris:feat/dismiss-interrupted-uploads-web
chris:feat/admin-logs-processing
chris:ci/winterfell-pr-tests
chris:feat/tentative-candidate-region-markers
chris:fix/ci-version-bump-scope
chris:feat/dismiss-interrupted-uploads
chris:feat/ui-filter-scope
chris:feat/thumbnail-sse-web
chris:feat/thumbnail-sse-ready-events
chris:feat/admin-logs-processing-api
chris:feat/ui-filter-ux
chris:docs/issue-073-resolved
chris:fix/people-heif-support
chris:docs/exif-face-migration-issues
chris:fix/media-maintenance-duplicate-usf
chris:fix/face-exif-orientation
chris:fix/face-edit-confirm
chris:docs/timeline-scroll-jump-issue
chris:fix/timeline-jump-drift
chris:feat/history-justified-wall
chris:docs/spec-049-planned-count
chris:fix/049-planned-file-count
chris:feat/history-item-dimensions
chris:feat/history-thumbnails-and-revert
chris:docs/issue-073-double-encoding
chris:fix/049-activity-status
chris:fix/hide-sort-filter-on-history-map
chris:feat/filter-sort-split-buttons
chris:feat/049-upload-activity-web
chris:fix/admin-operator-e2e
chris:docs/known-issues-071-072
chris:feat/049-upload-activity-backend
chris:docs/adr-0098-split-buttons
chris:feat/filter-sort-web
chris:feat/person-detail-history-tab
chris:feat/person-assignment-history-api
chris:spec/049-cross-device-upload-activity
chris:fix/post-914-ci-failures
chris:feat/unified-selection-mode
chris:feat/filter-sort-api
chris:docs/adr-0098-filter-sort-menu
chris:fix/ci-merge-commit-scopes
chris:feat/timeline-axis-polish
chris:fix/newer-days-hydration
chris:feat/person-added-sort-web
chris:docs/adr0099-unified-selection-mode
chris:feat/person-added-sort-api
chris:feat/android-viewer-polish
chris:feat/drag-select-timeline
chris:fix/dismissed-notifications-resurrect
chris:chore/host-disk-incident-071
chris:docs/adr0097-state-only-closeout
chris:spec/048-p3-basis-drop
chris:spec/048-p2-readers-ui
chris:spec/048-accepted-means-confirmed
chris:hotfix/silent-auto-action-size-cap
chris:docs/spec047-whole-band-consensus
chris:spec/047-unified-band-model
chris:docs/issue-073-face-recovery-zombie
chris:hotfix/occurrence-insert-revives-superseded
chris:spec/046-allow-identical-disbanded-cluster-re-proposals
chris:spec/045-stash-p3p4-provenance-hardening
chris:fix/android-token-creation
chris:chore/trigger-main-android-apk
chris:feat/admin-logs-newest-first
chris:feat/ci-apk-release-upload
chris:fix/v139-collision-rename
chris:chore/spec-044-closeout
chris:feat/admin-job-events-api
chris:feat/admin-logs-terminal
chris:spec/045-stash-shadow-auto-assign-with-tentative-basis-and-no-anchor-growth
chris:feat/android-app-ui
chris:feat/android-core-sync-engine
chris:feat/admin-logs-tab
chris:feat/admin-job-runs-api
chris:feat/ci-android-scope
chris:feat/android-app-scaffold
chris:feat/api-token-media-read-scope
chris:fix/s1-upload-session-ownership
chris:spec/044-android-app
chris:docs/android-app-design
chris:fix/search-single-search-bar
chris:feat/face-quality-score
chris:feat/wiki-topic-pages
chris:docs/wiki-topic-pages
chris:fix/wiki-sync-container-local
chris:fix/people-representative-enrichment
chris:fix/wiki-sync-mirror-race
chris:fix/wiki-sync-ci
chris:feat/wiki-setup
chris:feat/face-thumbnail-recency-blend
chris:feat/search-auto-backfill
chris:feat/albums-overlay-url
chris:feat/search-overlay-web
chris:feat/media-overlay-audit-fixes
chris:docs/adr-media-overlay
chris:feat/search-person-multi-web
chris:feat/search-tokens-web
chris:feat/search-tokens-backend
chris:feat/search-person-web
chris:feat/search-person-backend
chris:feat/search-filters-web
chris:feat/search-filters-backend
chris:fix/search-stats-indexes
chris:chore/library-stats-redeploy
chris:feat/search-person-filter
chris:feat/library-stats
chris:fix/api-redeploy-touch
chris:fix/deploy-api-gate
chris:fix/face-unassign
chris:fix/ci-oom-serialization
chris:fix/split-move-dialogs
chris:fix/embedding-map-tight-organic
chris:fix/embedding-map-organic
chris:fix/thumbnail-centrality-order
chris:fix/embedding-map-no-overlap
chris:fix/embedding-map-stable-clusters
chris:docs/issue-065-deploy-timeout
chris:fix/person-selection-checkboxes
chris:feature/pgvector-embedding-index
chris:fix/merge-picker-named-only
chris:fix/people-ci-hygiene
chris:fix/quality-consensus-worker
chris:fix/quality-threshold-api
chris:fix/decision-perf-api
chris:fix/decision-perf-web
chris:feat/embedding-map-cluster
chris:docs/spec-042-close
chris:feat/embedding-map-api
chris:feat/embedding-map-web
chris:fix/no-upscale-bbox-crops
chris:fix/thumbnail-retry-loop
chris:test/stabilize-albums-1308
chris:fix/stashed-grid-like-named
chris:feat/set-thumbnail-face-picker-api
chris:feat/set-thumbnail-face-picker-web
chris:feat/incomplete-media-web
chris:feat/incomplete-media-api
chris:fix/stashed-person-clickable
chris:feat/timeline-live-insert-web
chris:feat/timeline-live-insert-api
chris:fix/discovery-instance-card-type-scale
chris:docs/known-issue-056-auto-accept-contract
chris:fix/class-instance-auto-accept-contract
chris:feat/upload-batch-notifications-web
chris:feat/upload-batch-notifications
chris:fix/instance-thumbnail-spinner
chris:docs/batch-activity-notifications-design
chris:fix/upload-status-steady-uploading
chris:fix/face-naming-409
chris:fix/dialog-live-target
chris:fix/candidate-card-live-target
chris:feat/picker-pin-suggested
chris:fix/person-ranking-best-pair
chris:docs/issue-056-renumber
chris:feat/merge-picker-unnamed-thumbnails
chris:docs/issue-052-ci-port-collision
chris:feat/candidate-card-merge-dropdown
chris:feat/tentative-direct-accept
chris:fix/instance-page-title
chris:fix/remove-people-things
chris:fix/web-ci-stability
chris:feat/instance-split-move
chris:fix/new-person-one-click
chris:feat/domain-tentative-counts
chris:fix/web-ci-failures
chris:fix/same-person-threshold
chris:fix/new-person-instead-persistence
chris:feat/instance-person-ranking
chris:feat/tentative-date-sections
chris:feat/spec-041-tentative-candidates
chris:fix/merge-card-named-pair-reject
chris:chore/v130-suggest-band
chris:feat/single-face-suggestions
chris:feat/cluster-match-stash-disband
chris:feat/merge-card-stash-disband
chris:docs/known-issues-051
chris:fix/dirty-mark-pg-merge
chris:feat/stash-disband-web
chris:feat/stash-disband-api
chris:docs/known-issues-049-050
chris:fix/people-worker-dispatch-indentation
chris:fix/legacy-embedding-space-backfill
chris:docs/known-issues-048-049
chris:fix/decide-candidate-dirty-mark
chris:docs/known-issues-people-merge-suggestion
chris:fix/accept-requires-name
chris:feat/people-merge-suggestions
chris:feat/accept-opens-dialog
chris:fix/face-crop-asset-backfill
chris:feat/candidate-offset-paging
chris:feat/card-tiles-lazyload
chris:feat/picker-similarity-order
chris:feat/person-similarity-ranking
chris:feat/cluster-person-match-suggestions
chris:feat/cluster-match-cards
chris:chore/retrigger-web-deploy
chris:feat/accept-candidate-into-existing
chris:feat/cluster-merge-into-person
chris:fix/match-candidate-uuid-cast
chris:feat/reviewable-person-clusters
chris:feat/cluster-photo-cap
chris:fix/candidate-lifecycle-supersede
chris:feat/duplicate-photo-hint
chris:feat/suggestion-carousel-redesign
chris:feat/suggestion-evidence-previews
chris:feat/domain-suggestions-frontend
chris:fix/merge-suggestion-test-flake
chris:feat/domain-suggestions-backend
chris:fix/discovery-domain-thumbnails
chris:fix/api-keys-active-only
chris:feat/instance-rename-from-list
chris:feat/discovery-selection-click-ux
chris:hotfix/cids-di-constructor
chris:feat/people-select-toolbar
chris:feat/people-select-toolbar-ui
chris:fix/people-recognition-followup
chris:fix/people-recognition-convergence
chris:fix/people-worker-thread-cap
chris:fix/face-recovery-endpoint
chris:fix/face-pipeline-embedding-flush
chris:fix/face-pipeline-b1b2-locks
chris:fix/core-face-legacy-removal
chris:docs/standard-agent-workflow
chris:fix/suggestions-zero-match
chris:feature/face-crop-revival
chris:fix/face-suggestion-thumbnail-404
chris:fix/face-suggestions-empty
chris:docs/changelog-v1.21.24
chris:docs/changelog-v1.21.19
chris:fix/processing-summary-include-discovery-thumb
chris:fix/media-worker-token-v2
chris:fix/worker-credential-job-types
chris:fix/worker-capabilities-compose
chris:fix/worker-capabilities-discovery-thumbnail
chris:chore/trigger-worker-media-deploy
chris:docs/changelog-v1.21.16
chris:docs/changelog-v1.21.15
chris:fix/discovery-thumbnail-crop
chris:docs/changelog-v1.21.14
chris:fix/face-thumbnail-404
chris:fix/preview-url-for-zoom
chris:fix/thumb-zoom-transform
chris:fix/no-distortion-thumbnails
chris:fix/people-rep-bbox-without-thumbnail
chris:fix/instance-detail-face-crop
chris:fix/e2e-test-selectors
chris:fix/people-browse-lifecycle-state
chris:feat/037-instance-suggestions
chris:fix/face-assign-thumbnail
chris:fix/owner-face-embeddings-pgobject-cast
chris:fix/explore-people-and-processing-window
chris:fix/processing-summary-remove-time-window
chris:fix/people-pipeline-coupled-fixes
chris:fix/v115-predelete-status
chris:fix/face-embedding-batch
chris:fix/reprocess-scheduler-ratelimit
chris:fix/people-worker-poll-metadata
chris:fix/v115-fk-worker
chris:fix/v115-worker-job-results-fk
chris:fix/clear-people-domain
chris:fix/ci-scope-detection
chris:docs/embedding-incident-rca
chris:fix/discovery-double-prefix
chris:feature/api-key-ui
chris:agent/api-key-management
chris:feat/people-periodic-scan
chris:agent/periodic-recognition-scan
chris:agent/backfill-embeddings
chris:fix/people-worker-result-type
chris:fix/scrfd-detection-v2
chris:fix/people-worker-face-detection
chris:fix/face-overlay-include-owner-tentative
chris:fix/face-tentative-to-accepted
chris:fix/worker-job-owner-id-injection
chris:fix/people-worker-class-instance-candidate
chris:fix/face-pipeline-box-dim-mismatch
chris:fix-5-assertions
chris:fix/h2-class-occurrence-embeddings
chris:fix/face-pipeline-unique-constraint
chris:fix/faces-query-domain-filter
chris:fix/confidence-column-alias
chris:fix/scope-to-bounding-box-alias
chris:fix/people-checks-use-overlays
chris:fix/media-faces-endpoint
chris:fix/remove-people-class-occurrence-overlays
chris:fix/domain-key-people
chris:fix/redeploy-web-frontend
chris:fix/worker-credential-pgarray
chris:fix/flyway-out-of-order
chris:fix/retrospective-column-name
chris:fix/remaining-people-sql
chris:spec/036-t005-frontend
chris:spec/036-t003-automation
chris:spec/036-t004-jobtypes
chris:spec/036-phase2-people-to-classinstance
chris:fix/test-schemas-face-to-discovery
chris:spec/036-phase1-face-to-discovery
chris:spec/036-phase0-schema-cleanup
chris:spec/035-cleanup
chris:feature/gradle-remote-cache
chris:spec/035-matching
chris:spec/035-infra
chris:spec/034-drop-face-embeddings
chris:docs/issue-008-flaky-tests
chris:docs/safe-file-policy
chris:fix/explore-sort-domains
chris:fix/test-mocks-45
chris:fix/contextual-domain-toggles
chris:fix/face-marker-visibility-gating
chris:fix/flyway-auto-repair
chris:fix/ci-test-schema-columns
chris:fix/activity-scroll
chris:fix/delete-markers-visible
chris:fix/cio-edit-mode
chris:fix/delete-cross-style
chris:fix/plant-ui-bugs
chris:trigger/ci-workflow-test
chris:fix/migration-v096
chris:fix/plants-thumbnails-domain
chris:fix/plants-instance-browse
chris:fix/web-retry-smoke
chris:fix/web-trigger-rebuild
chris:feature/003-album-ml-training
chris:fix/sidebar-dead-ui-cleanup
chris:fix/web-clean-builder-cache
chris:fix/web-stale-cache
chris:fix/plantclef-final2
chris:fix/plantclef-debug
chris:trigger/plant-worker-redeploy
chris:fix/plantclef-input-size
chris:fix/plantclef-torch-load
chris:fix/discovery-state-accepted
chris:chore/web-build-on-pr
chris:fix/registry-token
chris:fix/deploy-pull
chris:feat/agent-state
chris:001-v1-baseline
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set
Reference
chris/memories!1439
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/suggestion-grid-skeleton-flash"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Every Accept/Reject (and merge) in the suggestions carousel refetches the people grid below it. That refetch flipped
loading = true, which swaps the whole grid for the 12-tile pulsating skeleton row until the response lands — person thumbnails + labels blink away and back on every decision. The carousel itself already behaves correctly (optimistic card removal + silent re-sync, no flash); only the grid refresh below was never ported to that pattern.Fix (
DiscoveryDomainInstances.svelte, one component)refetchInstances(withloadingflip) →silentRefetchInstances: same coalescing (one fetch in flight, one queued trailing rerun) and same parallel stashed listing, but it never touchesloading/error. The keyed grid re-renders in place from the fresh list, so existing cards keep their mounted DOM and images until the new list swaps in.onchangedpath and the two stashed-action error fallbacks (previouslyrefetchInstances).errorsurface is untouched.Verification
svelte-check: 0 errors, same 20 pre-existing warnings as baseline.tests/discovery-domain-instances.spec.ts+tests/discovery-stashed-people.spec.ts: 25/25 green.tests/discovery-review.spec.ts(95 tests incl. the carousel decision flows): green.accepting a card never swaps the people grid to the skeleton row: holds the post-decision refetch back and asserts the grid card stays visible with zero.animate-pulsenodes. Proven red against the old behavior (reintroducedloading = trueon a fresh build → test fails exactly at the skeleton assertion), green with the fix.Notes
PersonRelationServicePostgresTest(unrelated, API) — logged as ISSUE-222 in the second commit.Accepting/rejecting a suggestion-card decision (or a stashed-action error fallback) refetched the people grid with `loading = true`, swapping every person thumbnail + label for the 12-tile pulsating skeleton row until the response landed — a visible blink on every single decision. The carousel itself already removes its card optimistically and re-syncs silently ("no skeleton flash"); the grid below now does the same: `silentRefetchInstances` keeps the keyed grid mounted, so Svelte 5 re-renders it in place and existing cards never remount. Coalescing (one in flight + one queued trailing rerun) and the parallel stashed listing are unchanged. A failed silent refresh keeps the last good list (initial-load errors remain the only error surface). Regression test: while the post-decision refetch is held back the grid card must still be visible with zero `.animate-pulse` nodes — red with the old behavior (asserted on a fresh build), green now.View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.