feat(web): remove tile overlay buttons — keep images fully visible #1436

Merged
chris merged 2 commits from feat/remove-tile-overlays into main 2026-10-29 13:35:02 +01:00
Owner

What

Removes every overlay from media-wall tiles so even small thumbnails are fully visible:

  • Per-tile selection checkboxes (SelectionControl circles) — gone. Selection state shows as a ring per tile; selection happens via tap/long-press/drag-sweep and the section-title controls.
  • Per-tile action buttons — gone: person-page Accept/Reject/Move, map "center on photo".
  • Badge chips — gone: Score %, amber Tentative chip, album-suggestion role labels.

Kept: selection rings, section-title group select/deselect, bottom SelectionActionBar with all global actions, hover meta row, the axis-locked touch sweep from #1432. Tentative tiles keep a persistent amber ring via itemClass (visible on touch); Score % stays in the decile section headers; album-suggestion roles keep their color rings.

Dead API removed from MediaGrid: alwaysShowSelectionControls, itemAction, itemActions, itemBadge (+ their consumer usages).

Behavior notes

  • Occurrence-level "reject single face" is no longer reachable from the wall (user accepted): reject the media in the viewer, or use the toolbar's media-scoped remove. "Move to person" and "Accept" are covered by the toolbar (Split/Move dialog, Approve tentative — same endpoints the tile buttons used).
  • Desktop entry points to selection survive: mouse long-press, section-title control, Shift-click ranges, toolbar "Select loaded".
  • Map "center on photo" has no replacement (viewer has no map focus) — cheapest loss; noted.

Validation (@designer lane, re-verified by orchestrator)

  • npm run check: 0 errors (20 pre-existing warnings)
  • npm run test:unit: 45 files / 370 tests passed
  • Playwright desktop+mobile across touched specs: 270 passed, 16 skipped, 1 flaky (ISSUE-221 family), 1 pre-existing failure (timeline scroll stability mobile — proven failing on clean base in #1432's review too)
  • Review: no dead props left, data-selected attribute added for non-occluding test targeting, SelectionControl still used by section titles only

Version

v1.21.93 (gradle.properties + apps/web/package.json + changelog).

## What Removes every overlay from media-wall tiles so even small thumbnails are fully visible: - Per-tile selection checkboxes (SelectionControl circles) — gone. Selection state shows as a ring per tile; selection happens via tap/long-press/drag-sweep and the section-title controls. - Per-tile action buttons — gone: person-page Accept/Reject/Move, map "center on photo". - Badge chips — gone: Score %, amber Tentative chip, album-suggestion role labels. Kept: selection rings, section-title group select/deselect, bottom SelectionActionBar with all global actions, hover meta row, the axis-locked touch sweep from #1432. Tentative tiles keep a persistent amber ring via `itemClass` (visible on touch); Score % stays in the decile section headers; album-suggestion roles keep their color rings. Dead API removed from MediaGrid: `alwaysShowSelectionControls`, `itemAction`, `itemActions`, `itemBadge` (+ their consumer usages). ## Behavior notes - Occurrence-level "reject single face" is no longer reachable from the wall (user accepted): reject the media in the viewer, or use the toolbar's media-scoped remove. "Move to person" and "Accept" are covered by the toolbar (Split/Move dialog, Approve tentative — same endpoints the tile buttons used). - Desktop entry points to selection survive: mouse long-press, section-title control, Shift-click ranges, toolbar "Select loaded". - Map "center on photo" has no replacement (viewer has no map focus) — cheapest loss; noted. ## Validation (@designer lane, re-verified by orchestrator) - `npm run check`: 0 errors (20 pre-existing warnings) - `npm run test:unit`: 45 files / 370 tests passed - Playwright desktop+mobile across touched specs: 270 passed, 16 skipped, 1 flaky (ISSUE-221 family), 1 pre-existing failure (`timeline scroll stability` mobile — proven failing on clean base in #1432's review too) - Review: no dead props left, `data-selected` attribute added for non-occluding test targeting, `SelectionControl` still used by section titles only ## Version v1.21.93 (gradle.properties + apps/web/package.json + changelog).
chore: release 1.21.93
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 8m43s
811d6bd92f
chris merged commit 785726bb51 into main 2026-10-29 13:35:02 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1436
No description provided.