fix(android): search filter bar usable on empty results #1378
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/search-filter-empty-state"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Root cause (one sentence)
The report's mechanism — a filter bar living inside the branch the empty state replaces — does not exist in
SearchScreen(verified: input + chips are composed unconditionally above the weighted content box, and an empty answer never clobbers theSearchUiStatebehind them), but it exists verbatim in the Photos timeline, where the screen-levelwhenswapped the wholeTimelineGrid(header + search entry + filter chips) for a full-screenMessageBoxwhenever a filter/scope reload emptieddays, leaving only Refresh — which re-runs the same filter.Changes
TimelineStateContent, which fills the content area only. Picker header likewise stays on screen in every state (loading, results, empty, error).search_no_results_filtered("Keine Fotos für diesen Filter") instead of blaming the typed words; the empty body stays inside the content box — never a takeover (comment added stating the invariant).search_no_results_filtered.med/resolved/area:search(ISSUE-203 already claimed by open PR #1377).Sibling surfaces checked — no identical flaw
PeopleScreen, AlbumListScreen, AlbumDetailScreen, TrashScreen and MapScreen keep their headers/search inputs outside the empty-state branch (or have no on-screen filter bar); the web search page's filters sit above the results section as well.
Validation
rtk ./gradlew :app:testDebugUnitTest(ANDROID_HOME set), run twice on the final tree: 693 tests, 0 failures, 0 errors, 0 skipped.