fix(workers): v4 margin-demoted cards carry compatiblePersonIds (ADR 0116 V6) #1315
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/v4-margin-demotion-envelope-shape"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Third live-launch seam for v4 (ISSUE-169): the first live v4 run (job
fc05c137, 2026-10-19, ~31 min of HAC work) was rejected at submission — Core's semisupervised envelope validator requires every ambiguous candidate to carry BOTHconflictingPersonIdsAND acompatiblePersonIdsarray; the v4 margin demotion (ADR 0116 V6) set only the former.Fix (worker-side, minimal): the compatible set of a margin-demoted card is its own suggested target — v4 has no wholeGroup concept, the runner-up already lives in
conflictingPersonIds(sorted winner + runner-up). Demotion fixtures extended to pin the field.Also fixed on the way: the earlier forensics commit's classification bug (ID-vs-NAME comparison — report addendum committed separately on the eval branch) is unrelated to this fix; this PR contains only the envelope-shape change + fixture pins + ISSUE-169.
Test plan
PYTHONPATH=workers/people/src .venv/bin/python -m pytest workers/people/tests/ -q→ 437 passed (41 v4 G-B fixtures incl. the extended demotion assertions).semisupervised-v4).