fix(workers): v4 margin-demoted cards carry compatiblePersonIds (ADR 0116 V6) #1315

Merged
chris merged 1 commit from fix/v4-margin-demotion-envelope-shape into main 2026-10-19 23:05:37 +02:00
Owner

Summary

Third live-launch seam for v4 (ISSUE-169): the first live v4 run (job fc05c137, 2026-10-19, ~31 min of HAC work) was rejected at submission — Core's semisupervised envelope validator requires every ambiguous candidate to carry BOTH conflictingPersonIds AND a compatiblePersonIds array; the v4 margin demotion (ADR 0116 V6) set only the former.

Fix (worker-side, minimal): the compatible set of a margin-demoted card is its own suggested target — v4 has no wholeGroup concept, the runner-up already lives in conflictingPersonIds (sorted winner + runner-up). Demotion fixtures extended to pin the field.

Also fixed on the way: the earlier forensics commit's classification bug (ID-vs-NAME comparison — report addendum committed separately on the eval branch) is unrelated to this fix; this PR contains only the envelope-shape change + fixture pins + ISSUE-169.

Test plan

  • PYTHONPATH=workers/people/src .venv/bin/python -m pytest workers/people/tests/ -q → 437 passed (41 v4 G-B fixtures incl. the extended demotion assertions).
  • After merge+deploy the v4 live run is re-triggered on the owner domain (semisupervised-v4).
## Summary Third live-launch seam for v4 (ISSUE-169): the first live v4 run (job `fc05c137`, 2026-10-19, ~31 min of HAC work) was rejected at submission — Core's semisupervised envelope validator requires every ambiguous candidate to carry BOTH `conflictingPersonIds` AND a `compatiblePersonIds` array; the v4 margin demotion (ADR 0116 V6) set only the former. **Fix (worker-side, minimal):** the compatible set of a margin-demoted card is its own suggested target — v4 has no wholeGroup concept, the runner-up already lives in `conflictingPersonIds` (sorted winner + runner-up). Demotion fixtures extended to pin the field. **Also fixed on the way:** the earlier forensics commit's classification bug (ID-vs-NAME comparison — report addendum committed separately on the eval branch) is unrelated to this fix; this PR contains only the envelope-shape change + fixture pins + ISSUE-169. ## Test plan - `PYTHONPATH=workers/people/src .venv/bin/python -m pytest workers/people/tests/ -q` → **437 passed** (41 v4 G-B fixtures incl. the extended demotion assertions). - After merge+deploy the v4 live run is re-triggered on the owner domain (`semisupervised-v4`).
fix(clustering): v4 margin-demoted cards carry compatiblePersonIds (ADR 0116 V6)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Run scoped PR tests (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
f868ae00e9
The first live v4 run (job fc05c137, 2026-10-19, ~31 min of HAC work) was
rejected at submission: Core's semisupervised envelope validator requires
every ambiguous candidate to carry BOTH conflictingPersonIds AND a
compatiblePersonIds array — the v4 margin demotion set only the former.

Fix: the compatible set of a margin-demoted card is its own suggested
target (v4 has no wholeGroup concept; the runner-up lives in
conflictingPersonIds). Demotion fixtures extended to pin the field.

KNOWN_ISSUES: ISSUE-169 (resolved).

Full worker suite: 437 passed.
chris merged commit 7c9d0809d5 into main 2026-10-19 23:05:37 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1315
No description provided.