fix(discovery): only self-exclude live occurrences in instance suggestions #1244

Merged
chris merged 1 commit from fix/face-suggest-self-exclusion into main 2026-10-15 22:22:44 +02:00
Owner

Problem

In GET /api/discovery/domains/{domainKey}/instance-suggestions (ClassInstanceDiscoveryService.suggestSimilarInstances), step 0 resolves the source face's own instance for self-exclusion from class_instance_occurrences without a state filter. A revoked assignment leaves the occurrence row with state='removed' still pointing at the previous person, so that person was excluded from all three suggestion paths:

  1. embedding candidate ranking
  2. typed-name ILIKE fallback
  3. blank-query named listing

Verified live: for unassigned faces the previously assigned person never appeared in the "Assign person" dropdown — even typing their name yielded an empty list.

Fix

Resolve excludeInstanceId only from a LIVE occurrence (cio.state IN ('accepted','tentative')). A removed/superseded row is history: the face is unassigned and the previous person is exactly what the user wants to re-tag.

Currently accepted- or tentatively-assigned faces keep excluding their own instance exactly as before.

Tests

Four new regression tests in ClassInstanceDiscoveryServiceTest:

  • suggestSimilarInstancesSuggestsPreviouslyAssignedPersonAfterAssignmentRemoved — removed occurrence: previous person is ranked (embedding path, pending source embedding) and findable via a typed name query. Fails on unfixed code.
  • suggestSimilarInstancesNameFallbacksSuggestPreviouslyAssignedPersonAfterAssignmentRemoved — removed occurrence with no embeddings: person appears in blank-query named listing and typed ILIKE fallback. Fails on unfixed code.
  • suggestSimilarInstancesStillExcludesCurrentlyAssignedInstance — accepted occurrence: own instance still excluded from all paths.
  • suggestSimilarInstancesStillExcludesTentativelyAssignedInstance — tentative occurrence: own instance still excluded.

Verification: rtk ./gradlew :apps:api:test --tests '*ClassInstanceDiscoveryServiceTest*' — 333 tests, 0 failures. Full rtk ./gradlew :apps:api:test — BUILD SUCCESSFUL (8m27s).

## Problem In `GET /api/discovery/domains/{domainKey}/instance-suggestions` (`ClassInstanceDiscoveryService.suggestSimilarInstances`), step 0 resolves the source face's own instance for self-exclusion from `class_instance_occurrences` **without a state filter**. A revoked assignment leaves the occurrence row with `state='removed'` still pointing at the previous person, so that person was excluded from all three suggestion paths: 1. embedding candidate ranking 2. typed-name ILIKE fallback 3. blank-query named listing Verified live: for unassigned faces the previously assigned person never appeared in the "Assign person" dropdown — even typing their name yielded an empty list. ## Fix Resolve `excludeInstanceId` only from a LIVE occurrence (`cio.state IN ('accepted','tentative')`). A `removed`/`superseded` row is history: the face is unassigned and the previous person is exactly what the user wants to re-tag. Currently accepted- or tentatively-assigned faces keep excluding their own instance exactly as before. ## Tests Four new regression tests in `ClassInstanceDiscoveryServiceTest`: - `suggestSimilarInstancesSuggestsPreviouslyAssignedPersonAfterAssignmentRemoved` — removed occurrence: previous person is ranked (embedding path, pending source embedding) and findable via a typed name query. **Fails on unfixed code.** - `suggestSimilarInstancesNameFallbacksSuggestPreviouslyAssignedPersonAfterAssignmentRemoved` — removed occurrence with no embeddings: person appears in blank-query named listing and typed ILIKE fallback. **Fails on unfixed code.** - `suggestSimilarInstancesStillExcludesCurrentlyAssignedInstance` — accepted occurrence: own instance still excluded from all paths. - `suggestSimilarInstancesStillExcludesTentativelyAssignedInstance` — tentative occurrence: own instance still excluded. Verification: `rtk ./gradlew :apps:api:test --tests '*ClassInstanceDiscoveryServiceTest*'` — 333 tests, 0 failures. Full `rtk ./gradlew :apps:api:test` — BUILD SUCCESSFUL (8m27s).
fix(discovery): only self-exclude live occurrences in instance suggestions
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 7m28s
a5e506c101
The 'Assign person' dialog resolves the source face's own instance for
self-exclusion from class_instance_occurrences without filtering on
state. A revoked assignment leaves the occurrence row with
state='removed' still pointing at the previous person, so that person
was excluded from all three suggestion paths (embedding ranking, typed
ILIKE fallback, blank-query named listing) — the user could not re-tag
an unassigned face back to the person it was previously assigned to,
even by typing their name.

Resolve excludeInstanceId only from LIVE occurrences
(state IN ('accepted','tentative')). removed/superseded rows no longer
suppress the old person; currently accepted- or tentatively-assigned
faces keep excluding their own instance exactly as before.
chris force-pushed fix/face-suggest-self-exclusion from a5e506c101
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 7m28s
to 3482e21798
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 18m17s
2026-10-15 22:03:43 +02:00
Compare
chris merged commit f76a558194 into main 2026-10-15 22:22:44 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1244
No description provided.