feat(i18n): wave 5 final extraction sweep + hardcoded-string guard (spec 058) #1197
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/i18n-extraction-wave5"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Final i18n extraction sweep (spec 058 wave 5) plus a permanent hardcoded-string guard for the web app.
Keys
fd7f06ed: 1640 → 2164 per locale at this PR's tip; tree total 2173 = 2164 + 9 concurrent map/place-search keys main added during the rebase — no key collisions).EXTRACTION.mdconvention 8; en written from context.Extraction scope (census-driven)
src/lib/components+src/routes: profile page body + profile section components,EmbeddingMap.svelte(Danish source → da verbatim, en/de authored),DomainInstanceDialogs(43 messages),DiscoveryDomainInstances(28), root timeline, discovery media, albums detail, explore, shared-people person page,ActivityDialog,TimelineAxis,AddToAlbumDialog,OnThisDay*,MediaGrid, chrome/attr/ternary stragglers.EXTRACTION.md.Guard (new)
src/lib/i18n/hardcodedGuard.ts+hardcodedGuard.spec.ts(4 tests incl. a synthetic-failure proof) + committedhardcoded-baseline.json(empty, 0 findings).<script>bodies blanked for markup rules, Tailwind/CSS/brand/camelCase/UPPERCASE filters; findings deduped byfile:line:literal.HARDCODED_BASELINE_WRITE=1 npm run test:unit.Post-rebase fidelity fixes
instance(s)literal.AppHeader.sveltere-extracted onto main's new place-search disclosure structure; its newClose searchbutton becameheaderCloseSearch.Tests
embedding-map.spec.ts+profile-decision-history.spec.ts: Danish locale pinned via the existing storageState cookie pattern (they assert Danish-source copy that wave 5 localized); media-overlay locators now use the localized aria-label.profile-tabs.spec.ts: panel-heading expectations updated to the now-localized Danish values (locale already pinned da).Spec / known issues
confirm()strings (root timeline trash confirm, decision-history revert confirm) stayed hardcoded — census + guard blind spot, follow-up micro-pass.Verification
npm run check: 0 errors, 18 warnings (baseline unchanged)npm run build: exit 0npm run test:unit: 211/211 passed (29 files; guard 4/4)npx playwright test: 980 passed, 13 flaky, 2 failed, 23 skipped, 4 did not run (serial-chain poisoning)origin/main:backup-export.spec.tssafe-modeOn(ISSUE-148 verbatim) andupload-status.spec.tsfolder-upload hydration race (ISSUE-072 class — verified by running both specs detached atorigin/main, where they also fail attempt 1 and pass on retry). No deterministic failures attributable to this branch.Notes for review
main.vitest guard scanning .svelte/.ts under src/lib/components and src/routes with the same categories as the wave-5 census (text nodes, visible attrs, {…}/ternary literals, confirm/alert/toast literals). Any multi-word literal not in src/lib/i18n/hardcoded-baseline.json and not an m.* call fails the unit suite; the baseline is empty today. Refresh only with a reviewed extraction/exclusion: HARDCODED_BASELINE_WRITE=1 npm run test:unitMerging with --no-require-ci — documented evidence that red CI is not from this branch:
decc309a,0810c39f). Root-cause flake hardening stays tracked under ISSUE-072.