feat(web): on-this-day card opens full-day modal with viewer navigation #1148

Merged
chris merged 1 commit from feat/on-this-day-modal into main 2026-10-12 17:12:54 +02:00
Owner

Summary

Changes the On-this-day carousel interaction (spec 056 T005, replaces the timeline jump from #1138 per user decision): a card click now opens a modal with all media of that day in a wall layout, larger than the card mini-wall.

  • New OnThisDayModal.svelte: fetches the day via getTimelineDayItems (loading / error+retry / empty states), headline mirrors the card (eyebrow, human date, true count), justified wall at modal width via the shared wallRowHeights table, scroll-capped; dialog shell, ESC/backdrop close, focus trap + restore.
  • Tile click opens the existing MediaDetailViewer hosted inside the modal, navigation built from the fetched day items (page timeline may not have hydrated the day); viewer close → modal → page.
  • OnThisDayCarousel: card is a button with aria-haspopup="dialog", focus returns to the card on close; jumpToOnThisDay retired from +page.svelte (spec-051 targeted-day helpers kept).
  • Vitest /navigation stub; design doc amendment dated 2026-10-12.

Tests

Unit 127 passed (10 new modal tests). Playwright on-this-day.spec.ts rewritten: 14 passed desktop+mobile (open/headline/close, error retry, tile→viewer→back, empty-day auto-close, empty/error entries). svelte-check 0 errors.

## Summary Changes the On-this-day carousel interaction (spec 056 T005, replaces the timeline jump from #1138 per user decision): a card click now opens a modal with **all** media of that day in a wall layout, larger than the card mini-wall. - New `OnThisDayModal.svelte`: fetches the day via `getTimelineDayItems` (loading / error+retry / empty states), headline mirrors the card (eyebrow, human date, true count), justified wall at modal width via the shared `wallRowHeights` table, scroll-capped; dialog shell, ESC/backdrop close, focus trap + restore. - Tile click opens the existing `MediaDetailViewer` hosted inside the modal, navigation built from the fetched day items (page timeline may not have hydrated the day); viewer close → modal → page. - `OnThisDayCarousel`: card is a button with `aria-haspopup="dialog"`, focus returns to the card on close; `jumpToOnThisDay` retired from `+page.svelte` (spec-051 targeted-day helpers kept). - Vitest `/navigation` stub; design doc amendment dated 2026-10-12. ## Tests Unit 127 passed (10 new modal tests). Playwright `on-this-day.spec.ts` rewritten: 14 passed desktop+mobile (open/headline/close, error retry, tile→viewer→back, empty-day auto-close, empty/error entries). svelte-check 0 errors.
feat(web): open on-this-day card in full-day modal with viewer navigation
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 8m17s
30e9f670f4
Replace the timeline jump on On this Day card click with OnThisDayModal:
fetches the selected day via getTimelineDayItems, shows a justified
full-day wall (shared wallRowHeights breakpoints), and opens
MediaDetailViewer with day-scoped navigation. Modal follows the existing
dialog a11y pattern (ESC/backdrop close, focus trap, focus restore to
the card). Removes jumpToOnThisDay from +page.svelte; spec-051
targeted-day helpers remain for the timeline.

Adds unit specs for the modal, updates carousel click wiring tests,
rewrites tests/on-this-day.spec.ts for the modal flow, and amends the
2026-10-12 carousel design spec.
chris merged commit 1a3b4491b4 into main 2026-10-12 17:12:54 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1148
No description provided.