feat(android): Phase 0 IA shell — honest nav, settings, login polish #1114
Loading…
Reference in a new issue
No description provided.
Delete branch "ux-android-foundation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
The Android app shipped as a flat list of screens with a logout button dangling in the album-selection header. Family members could not answer the two questions that matter — "are my photos safe?" and "how do I sign out?" — without stumbling. This lands the spec-055 Phase 0 information architecture and the login/settings polish that make the app honest about what it does.
Information architecture: before → after
Before — four improvised tabs (Timeline, Albums, Status, plus an inline logout icon in the Albums header). Albums and Status were two halves of one idea split across two destinations, and logout hid inside a screen about picking folders.
After — three honest tabs a family member can reason about:
What family members gain
Notes for review
SettingsViewModelis wired through the existingAppViewModelFactory+AppContainer. No Hilt, per the phase-0 constraint.StoredSessioncarries no email, so the account block shows display name (falling back to owner ID) and server URL rather than inventing an email field.material-icons-extendedadded for the nav icons (PhotoLibrary / Backup / MoreHoriz).Verification
./gradlew :app:testDebugUnitTest :app:assembleDebuggreen — 105 tests, including newSettingsViewModelTest(6 cases covering account mapping, the display-name fallback, and logout revoking the credential).mainbefore pushing; no divergence.Known lint failures (pre-existing, out of scope)
lintDebugfails on two classes of error that this PR does not introduce and does not fix, to keep the diff scoped to the IA work:UnsafeOptInUsageErrorinui/timeline/ViewerPage.kt— introduced by the media-viewer PR #1112, a file untouched here.MissingTranslationforapp_name— the launcher label has been intentionally untranslated since before the viewer work; lint is not wired into CI.If either should be cleaned up, it is better done as its own focused change.
Out of scope (tracked elsewhere)
Server albums, people/explore tabs, timeline day sections, viewer changes (T002), pull-to-refresh (T004), and the full i18n migration of untouched files (T003).