docs(web): drop stale single-centroid rationale from ranking comments #1090

Merged
chris merged 1 commit from chore/fix-stale-centroid-comments into main 2026-10-10 15:58:28 +02:00
Owner

What

Comment-only cleanup of two stale references to the pre-ADR-0109 single-centroid ranking in DomainSuggestionsCarousel.svelte (lines ~2429 and ~3150), previously flagged as out-of-scope follow-up during the picker-latency review.

The gating claim itself is still correct — liveTopNamedRow returns null whenever a stored target name exists (line 769), so a named stored target always wins. Only the rationale ("the live ranking still uses the old single-centroid metric — ADR 0108 mismatch") predates ADR 0109 multi-representant ranking and is now wrong.

Why now

The web build/deploy run for PR #1088 (f00cedf7) was orphaned server-side (run 3981: first job never assigned to either runner in ~35 min, both runners idle) and was cancelled. This push re-triggers scope detection → build web → smoke web → deploy web for the picker cache fix, using an honest, independently useful change as the trigger rather than an empty commit.

Verification

  • Diff is comment-only: 1 file, +5/−5, no behavior change.
  • No test run required (no executable code touched); scoped CI runs on this PR anyway.

Scope

Docs/comments only. No schema, no API, no runtime changes.

## What Comment-only cleanup of two stale references to the pre-ADR-0109 single-centroid ranking in `DomainSuggestionsCarousel.svelte` (lines ~2429 and ~3150), previously flagged as out-of-scope follow-up during the picker-latency review. The gating claim itself is still correct — `liveTopNamedRow` returns `null` whenever a stored target name exists (line 769), so a named stored target always wins. Only the *rationale* ("the live ranking still uses the old single-centroid metric — ADR 0108 mismatch") predates ADR 0109 multi-representant ranking and is now wrong. ## Why now The web build/deploy run for PR #1088 (`f00cedf7`) was orphaned server-side (run 3981: first job never assigned to either runner in ~35 min, both runners idle) and was cancelled. This push re-triggers scope detection → build web → smoke web → deploy web for the picker cache fix, using an honest, independently useful change as the trigger rather than an empty commit. ## Verification - Diff is comment-only: 1 file, +5/−5, no behavior change. - No test run required (no executable code touched); scoped CI runs on this PR anyway. ## Scope Docs/comments only. No schema, no API, no runtime changes.
docs(web): drop stale single-centroid rationale from ranking comments
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m50s
b5e8103d19
liveTopNamedRow is gated on the stored target name, so a named stored
target always wins regardless of which metric the live ranking uses.
The old '(single-centroid) / ADR 0108 mismatch' wording predated ADR
0109 multi-representant ranking.
chris merged commit 0461b5fc96 into main 2026-10-10 15:58:28 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1090
No description provided.