fix(web): merge dialog subset selection actually submits on action #1010

Merged
chris merged 2 commits from fix/dialog-subset-noop into main 2026-10-03 20:09:31 +02:00
Owner

Root Cause — warum „nichts passiert"

Datei:Zeile: apps/web/src/lib/components/DomainSuggestionsCarousel.svelte, acceptCandidateIntoExisting() (vor dem Fix: Zeile 442–472).

  1. Vertragsverstoß (#1007 vs. Frontend): ClassInstanceDiscoveryService.java:3218–3222 verlangt, wenn selectedOccurrenceRefs gesendet wird, dass createNewInstance present ist (!= null oder details.createdAsNew). Die Dialog-Pfade schickten Subset + existingInstanceId, aber kein createNewInstance → Backend 400 "Invalid request: selectedOccurrenceRefs requires createNewInstance" → kein Merge.
  2. Fehler verschluckt: Der Catch schrieb das in mergePickerError (Zeile 473 alt) bzw. mergeTargetPickerError (Zeile 691 alt) — beide rendern nur mit offenem Picker (Zeile 1845 alt / 2610 alt). Über den normalen „Merge"-Button (Picker zu) landete der 400 in einer Variablen, die nichts rendert → kein Request-Erfolg, keine Meldung, actionError blieb leer. Auch: der Catch feuerte loadAll(), das die Card sofort wiederherstellte — die UI wirkte wie „Klick tut nichts".

createNewInstance: true-Pfade („Create (new) person") haben das Flag korrekt gesetzt — deshalb lautete der Bug-Bericht „Auswahl treffen → Merge-Button" und nicht das Anlegen neuer Personen.

Fix (ausschließlich apps/web)

  • createNewInstance: false mit dem Subset in acceptCandidateIntoExisting (Dialog-Primär- und Picker-Confirm-Pfad), acceptCandidateIntoPickedTarget (Modal-Picker) und acceptCandidate (Dialog-Merge mit Live-Target) — nur wenn tatsächlich ein Subset gesendet wird, nie statt des createNewInstance: true der New-Person-Pfade (bestehende Bodies der Card-Aktionen unverändert). createNewInstance = false gilt lt. ClassInstanceDiscoveryService.java:3141–3144 als present but not requested.
  • Fehler sichtbar: Decision-Action-Failures aus allen Merge-Pfaden landen in actionError (immer gerenderter Dialog-Footer-Alert, Zeile 1783) statt in picker-lokalen Variablen; openDetail/openMergeTargetPicker räumen ihn auf (= „0").
  • Kein stiller No-Op mehr: Bei fehlendem existingInstanceId (nur Name, keine Id, und live ranking leer) zeigt der Dialog-Primär-Button jetzt No merge target available — the suggestion list was refreshed. Try again. und ruft loadAll() auf, statt still return zu machen.

Testnachweis (apps/web)

  • Reproduktion vor dem Fix (per git stash-A/B, gleiche Specs): 1/5/6 der neuen Tests roten — Chain/Body/Alert-Beweise jeweils exakt am beschriebenen Punkt; „Deselect all"-Bestandstest als Kontrolle grün.
  • Nach dem Fix: npm run check → 0 errors (22 vorab-Warnings), npm run build ok, npm run test:unit → 60/60.
  • Playwright tests/discovery-review.spec.ts: 94/94 (3 neue Tests), zusammen mit discovery-domain-instance-detail.spec.ts 142/142 — Runner-Timeout vom vollen Lauf (Fails in unberührten Specs) reproduziert sich hier NICHT.
  • Voller Suite-Lauf: 723 passed / 23 skipped / 6 Fails in unberührten Specs (Rename, Merge, shift+click, groups by UTC date) — alle 6 mit --last-failed --workers=1 sofort grün (Timeout-Waiting-Pattern). Keine Scope-relevanten Rückwirkungen.

Neue Tests

  • dialog subset merge posts createNewInstance:false next to the subset (PR #1007 contract) — Body-Beweis (createNewInstance: false).
  • subset merge rejection surfaces at the dialog footer, dialog and card stay for retry — sichtbarer 400-Alert, Card + Dialog bleiben, decisionBodies Length-0-Beweis (kein Still-Posten auf 404-seitigem Mock).
  • missing merge target surfaces an error instead of silently doing nothing — existingInstanceId:null, Ranking fehlgeschlagen → exakte Fehlermeldung, Dialog offen, Card da, kein POST.
## Root Cause — warum „nichts passiert" **Datei:Zeile:** `apps/web/src/lib/components/DomainSuggestionsCarousel.svelte`, `acceptCandidateIntoExisting()` (vor dem Fix: Zeile 442–472). 1. **Vertragsverstoß (#1007 vs. Frontend):** `ClassInstanceDiscoveryService.java:3218–3222` verlangt, wenn `selectedOccurrenceRefs` gesendet wird, dass `createNewInstance` **present** ist (`!= null` oder `details.createdAsNew`). Die Dialog-Pfade schickten Subset + `existingInstanceId`, aber **kein `createNewInstance`** → Backend `400 "Invalid request: selectedOccurrenceRefs requires createNewInstance"` → kein Merge. 2. **Fehler verschluckt:** Der Catch schrieb das in `mergePickerError` (Zeile 473 alt) bzw. `mergeTargetPickerError` (Zeile 691 alt) — beide rendern **nur mit offenem Picker** (Zeile 1845 alt / 2610 alt). Über den normalen „Merge"-Button (Picker zu) landete der 400 in einer Variablen, die nichts rendert → kein Request-Erfolg, keine Meldung, `actionError` blieb leer. Auch: der Catch feuerte `loadAll()`, das die Card sofort wiederherstellte — die UI wirkte wie „Klick tut nichts". `createNewInstance: true`-Pfade („Create (new) person") haben das Flag korrekt gesetzt — deshalb lautete der Bug-Bericht „Auswahl treffen → Merge-Button" und nicht das Anlegen neuer Personen. ## Fix (ausschließlich `apps/web`) - **`createNewInstance: false` mit dem Subset** in `acceptCandidateIntoExisting` (Dialog-Primär- und Picker-Confirm-Pfad), `acceptCandidateIntoPickedTarget` (Modal-Picker) und `acceptCandidate` (Dialog-Merge mit Live-Target) — nur wenn tatsächlich ein Subset gesendet wird, nie statt des `createNewInstance: true` der New-Person-Pfade (bestehende Bodies der Card-Aktionen unverändert). `createNewInstance` = `false` gilt lt. `ClassInstanceDiscoveryService.java:3141–3144` als *present but not requested*. - **Fehler sichtbar:** Decision-Action-Failures aus allen Merge-Pfaden landen in `actionError` (immer gerenderter Dialog-Footer-Alert, Zeile 1783) statt in picker-lokalen Variablen; `openDetail`/`openMergeTargetPicker` räumen ihn auf (= „0"). - **Kein stiller No-Op mehr:** Bei fehlendem `existingInstanceId` (nur Name, keine Id, und live ranking leer) zeigt der Dialog-Primär-Button jetzt `No merge target available — the suggestion list was refreshed. Try again.` und ruft `loadAll()` auf, statt still `return` zu machen. ## Testnachweis (`apps/web`) - Reproduktion vor dem Fix (per `git stash`-A/B, gleiche Specs): 1/5/6 der neuen Tests roten — Chain/Body/Alert-Beweise jeweils exakt am beschriebenen Punkt; „Deselect all"-Bestandstest als Kontrolle grün. - Nach dem Fix: `npm run check` → 0 errors (22 vorab-Warnings), `npm run build` ok, `npm run test:unit` → **60/60**. - Playwright `tests/discovery-review.spec.ts`: **94/94** (3 neue Tests), zusammen mit `discovery-domain-instance-detail.spec.ts` **142/142** — Runner-Timeout vom vollen Lauf (Fails in unberührten Specs) reproduziert sich hier NICHT. - Voller Suite-Lauf: 723 passed / 23 skipped / **6 Fails in unberührten Specs** (`Rename`, `Merge`, `shift+click`, `groups by UTC date`) — alle 6 mit `--last-failed --workers=1` **sofort grün** (Timeout-Waiting-Pattern). Keine Scope-relevanten Rückwirkungen. ## Neue Tests - `dialog subset merge posts createNewInstance:false next to the subset (PR #1007 contract)` — Body-Beweis (`createNewInstance: false`). - `subset merge rejection surfaces at the dialog footer, dialog and card stay for retry` — sichtbarer 400-Alert, Card + Dialog bleiben, `decisionBodies` Length-0-Beweis (kein Still-Posten auf 404-seitigem Mock). - `missing merge target surfaces an error instead of silently doing nothing` — `existingInstanceId:null`, Ranking fehlgeschlagen → exakte Fehlermeldung, Dialog offen, Card da, kein POST.
fix(web): dialog subset merge now submits under the PR #1007 contract
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m15s
9ae6757b89
Root cause of "dialog merge does nothing": after #1007 the decision
endpoint requires the createNewInstance flag to be present whenever
selectedOccurrenceRefs is sent, and the dialog merge-into-existing paths
(sent subset + existingInstanceId, no flag) get a 400 instead — plus the
error was stored in mergePickerError/mergeTargetPickerError, which only
render while their picker is open, so the normal primary-button path
failed completely silently.

- merge-into-existing dialog/picker paths now post
  createNewInstance:false together with any subset (never overwriting
  the createNewInstance:true of new-person paths)
- decision action failures surface as actionError in the dialog footer
  (always rendered), both pickers clear it on open
- missing existingInstanceId no longer no-ops: visible error + reload
- new tests: subset POST carries createNewInstance:false; 400 surfaces
  as a visible dialog alert instead of hiding the failure

Verified: check 0 errors, build ok, unit 60/60, discovery-review +
discovery-domain-instance-detail 142/142; full Playwright suite green
(6 unrelated flukes pass immediately with --last-failed).
Merge main into fix/dialog-subset-noop
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m36s
b3f8a54a83
chris merged commit 42c501fe3a into main 2026-10-03 20:09:31 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1010
No description provided.