fix(web): stabilize albums/map/accessibility E2E specs #784
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/web-ci-failures"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stabilizes the 8 web Playwright failures blocking CI (desktop+mobile), root-caused locally by reproduction:
Root causes
tests/accessibility.spec.ts:123,:152 (mobile) — app bug (a11y regression)
The mobile hamburger button lost
aria-expandedduring the app-shell/nav extraction: AppShell ownsmobileMenuOpenbut never passed it to AppHeader. The disclosure button now exposesaria-expandedwired to the drawer state (AppShell -> AppHeader). No visual change.tests/albums.spec.ts:1778 — test drift (opt-in review context)
The review dialog now loads the timeline lazily only after "Show nearby context" and windows ±2 days around the selected day (start index 1, count 5 for the 2024-08-10 suggestion), revealing 4 days per edge scroll; pre-context there are no scroll hints. Spec still asserted the old always-loaded 8-day window (and could not reach the Accept action on mobile because the modal sat at the same z-index as the BottomNav).
z-40->z-50so the mobile BottomNav no longer intercepts taps on the modal footer actions.tests/albums.spec.ts:49 (desktop+mobile) — test drift
The selection-bar move action is now an icon-only button with accessible name "Move" (was a "Move..." text button). Spec selector updated.
tests/map.spec.ts:83 (desktop+mobile) — test drift
The removed copy "No visible media with coordinates in this map view." was replaced by the shared EmptyState ("No locations found" / "Photos with GPS data will appear on the map"). Spec asserts the current empty state.
Verification
npx playwright test tests/albums.spec.ts tests/map.spec.ts tests/accessibility.spec.ts-> 28 passed, 4 skipped (desktop+mobile)npm run check-> 0 errors (20 pre-existing warnings)Not env-related: all 8 failed on a clean local run before the fix.
- accessibility: restore aria-expanded on the mobile navigation hamburger button, wired to AppShell's drawer state (disclosure a11y regression). - albums: fix suggestion-review modal stacking so the mobile bottom nav no longer intercepts taps on the modal footer actions (z-40 -> z-50). - albums: update stale selectors/expectations to current UI (icon-only "Move" action button; opt-in review context window of +/-2 days around the selected day, revealed 4 days per edge scroll). - map: assert the current empty-state copy ("No locations found") instead of the removed timeline placeholder text.