feat(web): move stash action from card to instance-detail overflow menu #1229
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/stash-action-to-menu"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner redesign of PR #1226 (stash-away for named people): the eye-off icon on the people grid card is gone — "Stash away" now lives in the instance-detail ⋮ menu, next to Dissolve, in the menu's existing danger styling.
Behavior
globalThis.confirmpattern withddiStashNamedConfirm— the text names the cost explicitly: the name is lost.stashClassInstanceAPI client (unchanged), then the dissolve navigation pattern (back to the people list) plus addiStashedPersonsuccess toast. The person shows up in the Stashed section as unnamed.describeApiErroras an error toast (role=alert) — never silent, page stays put for a retry. Menu entry disables while in flight (stashBusy).Changes
DiscoveryDomainInstances.svelte: removed the stash card action +stashNamedPerson+ its import (Stashed section untouched)DiscoveryInstanceDetail.svelte:handleStashAway+ menu entryddiStashPersonAction/ddiStashNamedConfirm/ddiStashedPersonreused as-isTests (
discovery-stashed-people.spec.ts, 4 card-icon tests replaced by 5 menu tests)stash-personon grid cards)Validation (local)
npm run check: 0 errors (18 pre-existing warnings)npm run build: okdiscovery-stashed-people.spec.ts: 20/20 (desktop + mobile)discovery-domain-instances,-instance-detail,-rename,-selection,discovery-instance-tentative,share-target-autocomplete→ 206/206;instance-remove-mode,instance-split-move,instance-detail-face-crop,explore-people→ 48 passed / 4 pre-existing skips