feat(web): stash action for named people (name is discarded) #1226

Merged
chris merged 1 commit from feat/stash-named-person-web into main 2026-10-14 22:14:05 +02:00
Owner

Spec 039 (stash-away), web part: a NAMED person in the people grid can now be turned into a stashed (unnamed) person.

UX

  • New stash action on named person cards in DiscoveryDomainInstances, following the existing hover-revealed card-action pattern (icon button next to the rename affordance). Always visible on coarse pointers (touch has no hover), never rendered for unnamed cards or on non-people domains — stashed people already live in the Stashed section with Curate/Unstash/Disband.
  • Confirm dialog (globalThis.confirm, same pattern as Disband) names the cost explicitly: the name is lost.
  • On success: card leaves the grid optimistically, the person joins the Stashed list as unnamed (displayName: null, like the API response), the Stashed section opens itself, and a success message states the name is gone. On failure: describeApiError alert + refetch fallback, card stays put.

Changes

  • apps/web/src/lib/components/DiscoveryDomainInstances.svelte — stashNamedPerson() (reuses existing stashClassInstance API client, no API change) + card action button
  • i18n ddiStashPersonAction / ddiStashNamedConfirm / ddiStashedPerson in en/de/da

Tests (apps/web/tests/discovery-stashed-people.spec.ts, +4)

  • stash → confirm mentions lost name → card gone from grid, present in Stashed as unnamed, success message shown
  • declining the confirm: no API call, card stays
  • stashed cards expose Curate/Unstash/Disband only — no stash action on themselves
  • failed stash: card stays in grid, API error surfaced

Validation (local)

  • npm run check (svelte-check): 0 errors, warnings pre-existing
  • npm run build: ok
  • Playwright discovery-stashed-people.spec.ts: 18/18 (desktop + mobile)
  • Playwright discovery-domain-instances + -rename + -selection: 72/72 (no regressions)
  • Verified pointer-coarse devices render the action at full opacity without hover
Spec 039 (stash-away), web part: a NAMED person in the people grid can now be turned into a stashed (unnamed) person. **UX** - New stash action on named person cards in `DiscoveryDomainInstances`, following the existing hover-revealed card-action pattern (icon button next to the rename affordance). Always visible on coarse pointers (touch has no hover), never rendered for unnamed cards or on non-people domains — stashed people already live in the Stashed section with Curate/Unstash/Disband. - Confirm dialog (`globalThis.confirm`, same pattern as Disband) names the cost explicitly: the name is lost. - On success: card leaves the grid optimistically, the person joins the Stashed list as unnamed (displayName: null, like the API response), the Stashed section opens itself, and a success message states the name is gone. On failure: `describeApiError` alert + refetch fallback, card stays put. **Changes** - `apps/web/src/lib/components/DiscoveryDomainInstances.svelte` — `stashNamedPerson()` (reuses existing `stashClassInstance` API client, no API change) + card action button - i18n `ddiStashPersonAction` / `ddiStashNamedConfirm` / `ddiStashedPerson` in en/de/da **Tests** (`apps/web/tests/discovery-stashed-people.spec.ts`, +4) - stash → confirm mentions lost name → card gone from grid, present in Stashed as unnamed, success message shown - declining the confirm: no API call, card stays - stashed cards expose Curate/Unstash/Disband only — no stash action on themselves - failed stash: card stays in grid, API error surfaced **Validation (local)** - `npm run check` (svelte-check): 0 errors, warnings pre-existing - `npm run build`: ok - Playwright `discovery-stashed-people.spec.ts`: 18/18 (desktop + mobile) - Playwright `discovery-domain-instances` + `-rename` + `-selection`: 72/72 (no regressions) - Verified `pointer-coarse` devices render the action at full opacity without hover
feat(web): stash action for named people (name is discarded)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 10m34s
187cc9faa7
Named person cards in the people grid get a stash-away action (spec 039).
The confirm dialog states explicitly that the name is lost; on success the
card leaves the grid optimistically and the person joins the Stashed list
as unnamed, with the section opening itself. Failures keep the card and
surface describeApiError like the other stash-list operations.

Action is hover-revealed next to the rename affordance, always visible on
coarse pointers, and only rendered for named people on the people domain.
chris merged commit d0aa7eff4b into main 2026-10-14 22:14:05 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1226
No description provided.