feat(android): Phase 0 IA shell — honest nav, settings, login polish #1114

Merged
chris merged 1 commit from ux-android-foundation into main 2026-10-11 15:51:19 +02:00
Owner

Why

The Android app shipped as a flat list of screens with a logout button dangling in the album-selection header. Family members could not answer the two questions that matter — "are my photos safe?" and "how do I sign out?" — without stumbling. This lands the spec-055 Phase 0 information architecture and the login/settings polish that make the app honest about what it does.

Information architecture: before → after

Before — four improvised tabs (Timeline, Albums, Status, plus an inline logout icon in the Albums header). Albums and Status were two halves of one idea split across two destinations, and logout hid inside a screen about picking folders.

After — three honest tabs a family member can reason about:

Tab Before After
FOTOS "Timeline" tab Timeline, now the start destination. Correct photo icon, localized label.
SICHERUNG Split across "Albums" (folder selection) + "Status" (run state) One coherent tab: pending/uploaded/failed counts, last-run card, backup-now / pause / retry-failed, charging-only toggle, and device-album selection — sections in one place.
MEHR Logout icon hidden in the Albums header A settings hub: signed-in account (name + server URL), theme follows the system, app version, and a clearly destructive LOGOUT behind a confirmation dialog.

What family members gain

  • "Is my stuff safe?" is answerable on one screen. The counts, the last run, and the album selection now live together instead of being split across two tabs.
  • Signing out is discoverable and safe. It lives in MEHR where people expect it, is error-tinted so it reads as consequential, and requires a confirmation tap — no more accidental logout from a stray icon tap while choosing folders.
  • The app speaks their language. Every user-visible string is a resource with a German default and Danish/English translations. Previously, Danish users saw German copy and English copy mixed arbitrarily; now the tabs, empty states, errors, and settings all localize.
  • Login stops fighting the keyboard. The form lifts above the keyboard (imePadding), tabs in the right order (server → email → password), and the keyboard's Done key submits. Failure messages come from translated resources instead of hardcoded text.
  • Fewer dead ends. Loading, empty, and error states on every touched screen give friendly, actionable copy with a retry — and a background refresh keeps your place in the grid instead of blanking it behind a spinner.

Notes for review

  • Manual DI only — SettingsViewModel is wired through the existing AppViewModelFactory + AppContainer. No Hilt, per the phase-0 constraint.
  • StoredSession carries no email, so the account block shows display name (falling back to owner ID) and server URL rather than inventing an email field.
  • Theme follows the system — there is no toggle, and dark mode works throughout. This is intentional for phase 0.
  • material-icons-extended added for the nav icons (PhotoLibrary / Backup / MoreHoriz).

Verification

  • ./gradlew :app:testDebugUnitTest :app:assembleDebug green — 105 tests, including new SettingsViewModelTest (6 cases covering account mapping, the display-name fallback, and logout revoking the credential).
  • Rebased onto the latest main before pushing; no divergence.

Known lint failures (pre-existing, out of scope)

lintDebug fails on two classes of error that this PR does not introduce and does not fix, to keep the diff scoped to the IA work:

  1. 8 × UnsafeOptInUsageError in ui/timeline/ViewerPage.kt — introduced by the media-viewer PR #1112, a file untouched here.
  2. 1 × MissingTranslation for app_name — the launcher label has been intentionally untranslated since before the viewer work; lint is not wired into CI.

If either should be cleaned up, it is better done as its own focused change.

Out of scope (tracked elsewhere)

Server albums, people/explore tabs, timeline day sections, viewer changes (T002), pull-to-refresh (T004), and the full i18n migration of untouched files (T003).

## Why The Android app shipped as a flat list of screens with a logout button dangling in the album-selection header. Family members could not answer the two questions that matter — "are my photos safe?" and "how do I sign out?" — without stumbling. This lands the spec-055 Phase 0 information architecture and the login/settings polish that make the app honest about what it does. ## Information architecture: before → after **Before** — four improvised tabs (Timeline, Albums, Status, plus an inline logout icon in the Albums header). Albums and Status were two halves of one idea split across two destinations, and logout hid inside a screen about picking folders. **After** — three honest tabs a family member can reason about: | Tab | Before | After | |-----|--------|-------| | **FOTOS** | "Timeline" tab | Timeline, now the start destination. Correct photo icon, localized label. | | **SICHERUNG** | Split across "Albums" (folder selection) + "Status" (run state) | One coherent tab: pending/uploaded/failed counts, last-run card, backup-now / pause / retry-failed, charging-only toggle, and device-album selection — sections in one place. | | **MEHR** | Logout icon hidden in the Albums header | A settings hub: signed-in account (name + server URL), theme follows the system, app version, and a clearly destructive LOGOUT behind a confirmation dialog. | ## What family members gain - **"Is my stuff safe?"** is answerable on one screen. The counts, the last run, and the album selection now live together instead of being split across two tabs. - **Signing out is discoverable and safe.** It lives in MEHR where people expect it, is error-tinted so it reads as consequential, and requires a confirmation tap — no more accidental logout from a stray icon tap while choosing folders. - **The app speaks their language.** Every user-visible string is a resource with a German default and Danish/English translations. Previously, Danish users saw German copy and English copy mixed arbitrarily; now the tabs, empty states, errors, and settings all localize. - **Login stops fighting the keyboard.** The form lifts above the keyboard (imePadding), tabs in the right order (server → email → password), and the keyboard's Done key submits. Failure messages come from translated resources instead of hardcoded text. - **Fewer dead ends.** Loading, empty, and error states on every touched screen give friendly, actionable copy with a retry — and a background refresh keeps your place in the grid instead of blanking it behind a spinner. ## Notes for review - **Manual DI only** — `SettingsViewModel` is wired through the existing `AppViewModelFactory` + `AppContainer`. No Hilt, per the phase-0 constraint. - **`StoredSession` carries no email**, so the account block shows display name (falling back to owner ID) and server URL rather than inventing an email field. - **Theme follows the system** — there is no toggle, and dark mode works throughout. This is intentional for phase 0. - **`material-icons-extended`** added for the nav icons (PhotoLibrary / Backup / MoreHoriz). ## Verification - `./gradlew :app:testDebugUnitTest :app:assembleDebug` green — 105 tests, including new `SettingsViewModelTest` (6 cases covering account mapping, the display-name fallback, and logout revoking the credential). - Rebased onto the latest `main` before pushing; no divergence. ### Known lint failures (pre-existing, out of scope) `lintDebug` fails on two classes of error that this PR does not introduce and does not fix, to keep the diff scoped to the IA work: 1. **8 × `UnsafeOptInUsageError`** in `ui/timeline/ViewerPage.kt` — introduced by the media-viewer PR #1112, a file untouched here. 2. **1 × `MissingTranslation`** for `app_name` — the launcher label has been intentionally untranslated since before the viewer work; lint is not wired into CI. If either should be cleaned up, it is better done as its own focused change. ## Out of scope (tracked elsewhere) Server albums, people/explore tabs, timeline day sections, viewer changes (T002), pull-to-refresh (T004), and the full i18n migration of untouched files (T003).
feat(android): Phase 0 IA shell — honest 3-tab nav, settings, login polish
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4s
Build and Deploy / Android unit tests and debug APK (push) Successful in 5m4s
08697af57f
Replace the improvised album/status/timeline tabs with a bottom-nav shell a
family member can actually reason about, and move logout behind a confirmed
settings screen.

Information architecture
- Three honest tabs: FOTOS (timeline, start destination), SICHERUNG (device
  backup), MEHR (settings). Correct icons + localized labels, content
  descriptions from resources.
- Merge the old Albums (device album selection) and BackupStatus (run state,
  counts, backup-now/pause/retry, charging toggle) screens into one coherent
  SICHERUNG tab with sections; drop the tiny logout icon from the albums
  header now that logout lives in MEHR.
- Add MEHR/Settings: signed-in account (display name, server URL — StoredSession
  carries no email), theme follows the system (no toggle, dark works), app
  version via AppInfo/PackageManager, and LOGOUT behind an error-tinted,
  confirmation-gated button (>=48dp, semantics label). Manual DI only:
  SettingsViewModel wired through AppViewModelFactory + AppContainer, no Hilt.

Login polish
- Keyboard avoidance via imePadding, FocusRequester tab order (server -> email
  -> password), ImeAction Next/Done with Done submitting. Existing per-field
  error logic kept.
- Move login failure copy into strings.xml: failureMessage() selects the
  resource (JVM-testable), messageFor() resolves it in Compose.

Copy + accessibility
- All user-visible strings become resources with German default and da/en
  translations; no hardcoded literals in touched code. LoadingBox announces
  itself; ErrorBox/ViewerTopBar take localized labels.
- Friendly loading/empty/error states on every touched screen. A refresh keeps
  content on screen instead of swapping it for a spinner (pull-to-refresh is
  T004). Timeline renders localized session-expired copy instead of the VM's
  hardcoded message.
- material-icons-extended added for the nav icons.

Verification: :app:testDebugUnitTest + :app:assembleDebug green (105 tests).
lintDebug still reports pre-existing, out-of-scope errors: 8
UnsafeOptInUsageError in ViewerPage.kt (PR #1112) and the untranslated
app_name launcher label.
chris merged commit dc6bbd717d into main 2026-10-11 15:51:19 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1114
No description provided.