fix(api): method-agnostic face-recognition job label #989

Merged
chris merged 2 commits from fix/face-recognition-job-label into main 2026-10-02 18:36:18 +02:00
Owner

Summary

The admin operator job log displayed "Face recognition (DBSCAN clustering)" for `owner_face_recognition`. That label claimed a specific clustering method, but the method is now owner-configurable (constrained-dbscan default, anchored-hybrid selectable via admin; the actual method rides in the job payload `settings.clusteringMethod`).

Replaces the hardcoded label with the method-agnostic "Face recognition (clustering)" in both static label maps:

  • `JobRunsService` (GET /api/admin/job-runs)
  • `JobEventsService` (GET /api/admin/job-events)

The configured method is deliberately not rendered into the label — per-run method logging landed separately in the worker (PR #988).

Test updates

All pinned occurrences updated so the suite stays green:

  • `JobRunsServiceTest`, `JobRunsControllerTest`, `JobEventsServiceTest`, `JobEventsControllerTest`
  • `apps/web/tests/admin-operator.spec.ts` (jobLabel/label fixtures + the log-line assertion `Face recognition (clustering): running`)

Verification

  • API: `rtk ./gradlew :apps:api:test --tests 'dev.memories.api.operator.*'` (4 operator classes) — pass
  • Web: playwright `tests/admin-operator.spec.ts` in `mcr.microsoft.com/playwright:v1.59.1-noble` (CI's image, npm ci + build + filtered run) — 12 passed (6 tests × desktop/mobile)
  • Grep sweep: no user-visible label or test pin with "DBSCAN clustering" remains (only worker algorithm docstrings in `workers/people`)
  • Version bump: 1.21.60 → 1.21.61
## Summary The admin operator job log displayed **"Face recognition (DBSCAN clustering)"** for \`owner_face_recognition\`. That label claimed a specific clustering method, but the method is now owner-configurable (constrained-dbscan default, anchored-hybrid selectable via admin; the actual method rides in the job payload \`settings.clusteringMethod\`). Replaces the hardcoded label with the method-agnostic **"Face recognition (clustering)"** in both static label maps: - \`JobRunsService\` (GET /api/admin/job-runs) - \`JobEventsService\` (GET /api/admin/job-events) The configured method is deliberately **not** rendered into the label — per-run method logging landed separately in the worker (PR #988). ## Test updates All pinned occurrences updated so the suite stays green: - \`JobRunsServiceTest\`, \`JobRunsControllerTest\`, \`JobEventsServiceTest\`, \`JobEventsControllerTest\` - \`apps/web/tests/admin-operator.spec.ts\` (jobLabel/label fixtures + the log-line assertion \`Face recognition (clustering): running\`) ## Verification - API: \`rtk ./gradlew :apps:api:test --tests 'dev.memories.api.operator.*'\` (4 operator classes) — **pass** - Web: playwright \`tests/admin-operator.spec.ts\` in \`mcr.microsoft.com/playwright:v1.59.1-noble\` (CI's image, npm ci + build + filtered run) — **12 passed** (6 tests × desktop/mobile) - Grep sweep: no user-visible label or test pin with "DBSCAN clustering" remains (only worker algorithm docstrings in \`workers/people\`) - Version bump: 1.21.60 → 1.21.61
The operator job-runs/job-events labels claimed "DBSCAN clustering" for
owner_face_recognition, but the clustering method is now
owner-configurable (anchored-hybrid selectable in admin, constrained-
dbscan default; the actual method rides in the job payload
settings.clusteringMethod). A hardcoded DBSCAN label is misleading for
any owner running the alternative method.

Neutral static label "Face recognition (clustering)" in both label maps
(JobRunsService, JobEventsService); the configured method is not
rendered into the label - per-run method logging lands separately in
the worker. Test pins updated in all four operator test classes and the
web admin-operator spec (jobLabel fixtures + the
"Face recognition (clustering): running" log-line assertion).
chore: version bump 1.21.61
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 10m54s
d33bdd7e0e
chris merged commit d20ff8b8e6 into main 2026-10-02 18:36:18 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!989
No description provided.