feat(web): discard interrupted uploads from activity dialog #955

Merged
chris merged 6 commits from feat/dismiss-interrupted-uploads-web into main 2026-09-29 00:11:28 +02:00
Owner

Summary

Web half of the interrupted-uploads cleanup: a Discard action in the media activity dialog for sessions shown as Interrupted (derived status stale only, never label-text matching).

  • API client (uploadActivity.ts): cancelUploadSession() posts to /api/upload-activity/{sessionId}/cancel; any 2xx resolves without parsing the body (empty/malformed-JSON 200s are success — apiClient.request parses before ok, so cancel deliberately uses raw fetch with typed errors: UploadSessionNotFoundError (404), UploadSessionStatusConflictError (409)).
  • Discard controller (uploadSessionDiscard.ts, pure TS, fully unit-tested): per-session phase/error state, duplicate-click guard, immediate store refetch on success (SSE as supplement), exactly one bounded ~2s reconciliation refetch skipped if SSE/poll already removed the session, teardown reset().
  • Dialog (designer handoff implemented 1:1): right-aligned outlined Discard on stale cards only — Discard → Discarding… → Discarded; in-card role=alert error with the dialog's red palette and exact copy for 404/409/network; aria-label Discard interrupted upload, aria-describedby, sr-only polite announcements; no focus manipulation (documented rationale).
  • AppShell owns the controller; reset() on destroy and both logout paths.

Test plan

  • npm run check: 0 errors; npx vitest run: 42/42 (15 new: cancel client 5 + discard controller 10).
  • npm run build: success.
  • Playwright not run locally (needs the backend endpoint of #952); no e2e changes required.

Depends on: #952 (merge first). Until it deploys, Discard clicks show the card's generic retry error. Version bump 1.21.60.

## Summary Web half of the interrupted-uploads cleanup: a Discard action in the media activity dialog for sessions shown as Interrupted (derived status stale only, never label-text matching). - API client (uploadActivity.ts): cancelUploadSession() posts to /api/upload-activity/{sessionId}/cancel; any 2xx resolves without parsing the body (empty/malformed-JSON 200s are success — apiClient.request parses before ok, so cancel deliberately uses raw fetch with typed errors: UploadSessionNotFoundError (404), UploadSessionStatusConflictError (409)). - Discard controller (uploadSessionDiscard.ts, pure TS, fully unit-tested): per-session phase/error state, duplicate-click guard, immediate store refetch on success (SSE as supplement), exactly one bounded ~2s reconciliation refetch skipped if SSE/poll already removed the session, teardown reset(). - Dialog (designer handoff implemented 1:1): right-aligned outlined Discard on stale cards only — Discard → Discarding… → Discarded; in-card role=alert error with the dialog's red palette and exact copy for 404/409/network; aria-label Discard interrupted upload, aria-describedby, sr-only polite announcements; no focus manipulation (documented rationale). - AppShell owns the controller; reset() on destroy and both logout paths. ## Test plan - npm run check: 0 errors; npx vitest run: 42/42 (15 new: cancel client 5 + discard controller 10). - npm run build: success. - Playwright not run locally (needs the backend endpoint of #952); no e2e changes required. Depends on: #952 (merge first). Until it deploys, Discard clicks show the card's generic retry error. Version bump 1.21.60.
- POST /api/upload-activity/{sessionId}/cancel client: any 2xx resolves
  without parsing the body (empty/malformed included), 404/409 map to
  typed errors, network and other statuses reject unchanged
- testable discard controller: per-session phase/error state, stale-only
  gate keyed on derivedStatus, duplicate-click guard, immediate store
  refetch on success plus one bounded ~2s reconciliation attempt
feat(web): discard interrupted uploads from activity dialog
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 57s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 2m27s
cbc5307e01
- Discard action on stale/interrupted session cards only, right-aligned
  beneath metadata (border-neutral-700 outline, 44px min height, 8px
  radius, emerald focus ring, aria-label 'Discard interrupted upload')
- Discard -> Discarding… -> Discarded phases with native disabled state;
  typed card errors (404/409/other) via the dialog's red error palette
  with role=alert and aria-describedby wiring; polite live announcement
- AppShell owns the discard controller (cancel + immediate refetch +
  single bounded 2s reconciliation); no list surgery, the authoritative
  store refetch reconciles; focus intentionally untouched (comment)
chore: version bump 1.21.60
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m19s
be81da3ef1
merge: resolve version bump conflict (1.21.60)
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Has been cancelled
d936cea5d9
Merge remote-tracking branch 'origin/main' into feat/dismiss-interrupted-uploads-web
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 16s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m36s
55d4bfcac1
merge: resolve version bump conflict (1.21.60)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 5s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 3m48s
9e94610821
chris merged commit 88fb8ccb6f into main 2026-09-29 00:11:28 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!955
No description provided.