feat(web): split filter/sort buttons + in-place wall refetch (no page reload) #926

Merged
chris merged 3 commits from feat/filter-sort-split-buttons into main 2026-09-27 19:43:37 +02:00
Owner

Refines the merged FilterSortMenu (ADR 0098 as amended in #923).

Summary

  • The combined button becomes TWO separate standard buttons: sort (lucide arrow-up-down) and filter (lucide filter, placed right of sort), each with its own popover and active badge (sort badges only on non-default sort; filter shows active-filter count + emerald border). Sort button hidden on timeline and domain media list (no sort exists there).
  • Popovers are mutually exclusive via explicit toggle handlers (fixed a buggy $effect that closed the newly opened popover when clicking the sibling trigger).
  • NO full page reload on sort/filter change anywhere: wall data refetches in place on all five surfaces (URL unchanged, page chrome/header/timeline axis persist, scroll anchor preserved, SkeletonGrid inline loading). e2e asserts URL-stability and chrome persistence.
  • data-testids: sort-trigger/sort-menu/sort-badge, filter-trigger/filter-menu/filter-badge. Version 0.0.25.

Tests

  • svelte-check 0 errors; build green; Playwright 206 passed / 0 failed across filter-sort, discovery-domain-instance-detail, search-filters, timeline, albums, discovery-media-list.
Refines the merged FilterSortMenu (ADR 0098 as amended in #923). ## Summary - The combined button becomes TWO separate standard buttons: sort (lucide arrow-up-down) and filter (lucide filter, placed right of sort), each with its own popover and active badge (sort badges only on non-default sort; filter shows active-filter count + emerald border). Sort button hidden on timeline and domain media list (no sort exists there). - Popovers are mutually exclusive via explicit toggle handlers (fixed a buggy $effect that closed the newly opened popover when clicking the sibling trigger). - NO full page reload on sort/filter change anywhere: wall data refetches in place on all five surfaces (URL unchanged, page chrome/header/timeline axis persist, scroll anchor preserved, SkeletonGrid inline loading). e2e asserts URL-stability and chrome persistence. - data-testids: sort-trigger/sort-menu/sort-badge, filter-trigger/filter-menu/filter-badge. Version 0.0.25. ## Tests - svelte-check 0 errors; build green; Playwright 206 passed / 0 failed across filter-sort, discovery-domain-instance-detail, search-filters, timeline, albums, discovery-media-list.
chore(web): bump version to 0.0.25
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 7m38s
50845414ff
Merge remote-tracking branch 'origin/main' into feat/filter-sort-split-buttons
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 4m53s
0406129c2d
chris merged commit 439b026695 into main 2026-09-27 19:43:37 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!926
No description provided.