fix(web): keep timeline scroll stable across SSE refreshes and axis jumps #895

Merged
chris merged 3 commits from fix/timeline-scroll-stability into main 2026-09-27 02:20:16 +02:00
Owner

Summary

  • Serialize SSE refresh cycles with a sequence token: stale in-flight cycles can no longer mutate days/items or restore scroll
  • Capture the scroll anchor at mutation time (not fetch time) — fixes the viewport being yanked back after a timeline-axis jump
  • Anchor-aware hydrateDays merge (previously the only unanchored mutation path)
  • Restore fallback: media element → containing day section → no-op; removed the absolute scrollTo(previousScrollY) fallback that landed on wrong content after top-inserts
  • Axis jumps invalidate in-flight refreshes and schedule a follow-up refresh for events missed during the jump

Bugs fixed

  1. Uploading photos while mid-timeline caused the timeline to jump around (overlapping refresh cycles + unanchored hydration)
  2. Pressing the timeline axis jumped to the target day, then bounced back to the previous position (stale anchor restore)

Test plan

  • svelte-check: 0 errors
  • 2 new Playwright regression tests (mid-scroll SSE refresh, axis-jump revert): fail 3/3 on pre-fix code, pass 6/6 on fixed code
  • Full timeline.spec.ts desktop: 31 passed, 1 skipped, 1 pre-existing flaky (ISSUE-008)
  • apps/web version 0.0.20 → 0.0.21
## Summary - Serialize SSE refresh cycles with a sequence token: stale in-flight cycles can no longer mutate days/items or restore scroll - Capture the scroll anchor at mutation time (not fetch time) — fixes the viewport being yanked back after a timeline-axis jump - Anchor-aware `hydrateDays` merge (previously the only unanchored mutation path) - Restore fallback: media element → containing day section → no-op; removed the absolute `scrollTo(previousScrollY)` fallback that landed on wrong content after top-inserts - Axis jumps invalidate in-flight refreshes and schedule a follow-up refresh for events missed during the jump ## Bugs fixed 1. Uploading photos while mid-timeline caused the timeline to jump around (overlapping refresh cycles + unanchored hydration) 2. Pressing the timeline axis jumped to the target day, then bounced back to the previous position (stale anchor restore) ## Test plan - `svelte-check`: 0 errors - 2 new Playwright regression tests (mid-scroll SSE refresh, axis-jump revert): fail 3/3 on pre-fix code, pass 6/6 on fixed code - Full timeline.spec.ts desktop: 31 passed, 1 skipped, 1 pre-existing flaky (ISSUE-008) - apps/web version 0.0.20 → 0.0.21
chris force-pushed fix/timeline-scroll-stability from 7901564347
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 17s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 13m53s
to 74278c1baf
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 12s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 20m32s
2026-09-27 01:06:56 +02:00
Compare
refactor(web): reset pending refresh flag on load and drop dead includeNearTop option
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 8s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 19m6s
40421f2755
docs(known-issues): record flaky albums CI test under runner load (ISSUE-075)
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 6s
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 10m56s
94adcbff15
chris merged commit 0b4e384258 into main 2026-09-27 02:20:16 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!895
No description provided.