feat(api,web): per-instance tentative candidate counts on domain lists #779

Merged
chris merged 3 commits from feat/domain-tentative-counts into main 2026-09-20 22:44:13 +02:00
Owner
No description provided.
feat(api,web): per-instance tentative candidate counts on domain lists
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 5s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 17m30s
65cd389bec
Domain list instance cards now show the number of pending tentative
candidates next to the photo count (spec 041 detail-page semantics:
unit = candidates, never merged into mediaCount per ADR 0038).

- ClassInstanceView: nullable tentativeCount + back-compat ctor
- instances(): 4th correlated scalar subquery over
  class_instance_occurrence_candidates (pending, non-face_detection,
  owner/domain/class/target matched; target active+unstashed), served
  by the V131 index — aggregate only, no per-instance listing calls
  (ISSUE-054)
- people branch: same count plumbed through ClassInstanceRecordView
  from the generic instances() query (single grouped source, no N+1)
- toInstanceView(): count stays null (detail endpoints unchanged)
- web: badge '· N tentative' on cards, hidden when null/0
- tests: pending/decided/face_detection/foreign-owner/stashed counts,
  controller people-branch plumbing, playwright badge visible/hidden
chris force-pushed feat/domain-tentative-counts from 65cd389bec
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 5s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 17m30s
to ff946dd3ba
Some checks failed
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 15m29s
2026-09-20 22:01:40 +02:00
Compare
Concurrent CI web-test jobs run with host networking and `CI` is not set
inside the Playwright image, so reuseExistingServer reused whichever
preview server bound 127.0.0.1:4173 first: run 2577 executed the whole
discovery suite against a sibling branch's build, whose app predates the
tentative badge (badge spec failed with element-not-found while sibling
tests passed).

- inside containers: always start our own preview server on a stable
  per-container port (hostname = container id) and never reuse; port
  collisions now fail loudly instead of silently testing a foreign build
- outside containers: unchanged local 4173 + reuse workflow
- PLAYWRIGHT_PREVIEW_PORT overrides the port
test(web): assert tentative badge in dedicated spec
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 5m41s
eb24c0f4cc
Restore the card test to its original displayName + mediaCount semantics
and keep the tentative badge visible/hidden assertions in a dedicated
spec, per CI-failure follow-up.
chris merged commit 22e357913d into main 2026-09-20 22:44:13 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!779
No description provided.