fix(people): re-arm face recognition on candidate accept decisions (spec 038) #761

Merged
chris merged 1 commit from fix/decide-candidate-dirty-mark into main 2026-09-19 00:11:31 +02:00
Owner

Follow-up to #760: the candidate decision paths (decideCandidate accept, acceptCandidateForExistingInstance, autoAcceptExistingInstanceCandidate) change the people assignment set but never marked the owner's face_recognition_dirty row — so accepting a suggestion in the review UI did not re-arm recognition (the exact gap observed post-deploy: person edits via suggestions produced no dirty markers, no reconcile job).

Rejections intentionally do NOT mark dirty: they release faces back to owner_tentative, and an immediate re-run would just re-propose the same cluster (re-suggestion spam).

Tests: accept marks dirty (idempotent upsert), reject does not, pets-domain guard holds, policy auto-accept marks. Refs spec:038.

Follow-up to #760: the candidate decision paths (decideCandidate accept, acceptCandidateForExistingInstance, autoAcceptExistingInstanceCandidate) change the people assignment set but never marked the owner's face_recognition_dirty row — so accepting a suggestion in the review UI did not re-arm recognition (the exact gap observed post-deploy: person edits via suggestions produced no dirty markers, no reconcile job). Rejections intentionally do NOT mark dirty: they release faces back to owner_tentative, and an immediate re-run would just re-propose the same cluster (re-suggestion spam). Tests: accept marks dirty (idempotent upsert), reject does not, pets-domain guard holds, policy auto-accept marks. Refs spec:038.
fix(people): re-arm face recognition on candidate accept decisions (spec 038)
All checks were successful
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 5m5s
1ce8ae68ef
Accept paths in decideCandidate, acceptCandidateForExistingInstance and
autoAcceptExistingInstanceCandidate change the people assignment set but
never marked the owner's face_recognition_dirty row — so accepting a
suggestion in the UI did not re-arm recognition, and previously considered
owner_tentative faces stayed unmatched (the exact gap reported after the
spec 038 deploy).

Rejections intentionally do not mark dirty: they release faces back to
owner_tentative and an immediate re-run would just re-propose the same
cluster (re-suggestion spam).

Tests: accept marks dirty (idempotent), reject does not, pets domain
guard holds, policy auto-accept marks.
chris merged commit 3d31417de1 into main 2026-09-19 00:11:31 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!761
No description provided.