fix(discovery): bind missing domainKey and classKey parameters (retrospective) #698

Merged
chris merged 1 commit from fix/domainkey-sql-parameter into main 2026-07-22 18:54:48 +02:00
Owner

Summary

4 methods in the retrospective path had SQL using :domainKey/:classKey but missing .param() calls, causing "No value supplied for the SQL parameter domainKey" errors when "Apply retroactively" tried to find shared person contributions.

Methods Fixed

# Method Line
1 bestNamedSharedInstanceMatch(UUID, ClassInstanceUnnamedCandidateAssignment, double) 1496
2 namedSharedPersonEmbeddingsByKey(UUID) 1600
3 existingAcceptedSharedContribution(UUID, ClassInstanceUnnamedCandidateAssignment) 1859
4 existingAcceptedSharedContributions(UUID, List) 1933 — primary crash point

What Changed

Added .param("domainKey", "people") and .param("classKey", "person") before .query() in each method's JdbcClient chain. Values match the existing pattern used in all other people-domain methods in this file.

Out of Scope

3 other methods in the browse/explore path have the same bug pattern but are not triggered by the retrospective flow. Will be filed as a follow-up issue.

Verification

  • ✅ compileJava — passes
  • ✅ ClassInstanceServiceTest* — all tests pass
  • ✅ Version bumped to 1.21.24
## Summary 4 methods in the retrospective path had SQL using `:domainKey`/`:classKey` but missing `.param()` calls, causing "No value supplied for the SQL parameter domainKey" errors when "Apply retroactively" tried to find shared person contributions. ## Methods Fixed | # | Method | Line | |---|--------|------| | 1 | `bestNamedSharedInstanceMatch(UUID, ClassInstanceUnnamedCandidateAssignment, double)` | 1496 | | 2 | `namedSharedPersonEmbeddingsByKey(UUID)` | 1600 | | 3 | `existingAcceptedSharedContribution(UUID, ClassInstanceUnnamedCandidateAssignment)` | 1859 | | 4 | `existingAcceptedSharedContributions(UUID, List)` | 1933 — primary crash point | ## What Changed Added `.param("domainKey", "people")` and `.param("classKey", "person")` before `.query()` in each method's JdbcClient chain. Values match the existing pattern used in all other people-domain methods in this file. ## Out of Scope 3 other methods in the browse/explore path have the same bug pattern but are not triggered by the retrospective flow. Will be filed as a follow-up issue. ## Verification - ✅ `compileJava` — passes - ✅ `ClassInstanceServiceTest*` — all tests pass - ✅ Version bumped to 1.21.24
fix(discovery): bind missing domainKey and classKey parameters (retrospective)
All checks were successful
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 1m58s
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
919370f142
4 methods in the retrospective path had SQL using :domainKey/:classKey
but missing .param() calls. Caused 'No value supplied for the SQL
parameter domainKey' errors when 'Apply retroactively' tried to find
shared person contributions.

Methods fixed:
- bestNamedSharedInstanceMatch(UUID, ClassInstanceUnnamedCandidateAssignment, double)
- namedSharedPersonEmbeddingsByKey(UUID)
- existingAcceptedSharedContribution(UUID, ClassInstanceUnnamedCandidateAssignment)
- existingAcceptedSharedContributions(UUID, List) [primary crash point]

3 other methods in the browse/explore paths have the same bug pattern
but are out of scope for this PR — will be filed as a follow-up
issue.

Closes #696.
chris merged commit 795c32ab4d into main 2026-07-22 18:54:48 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!698
No description provided.