fix(discovery): bind missing domainKey and classKey parameters (retrospective) #698
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/domainkey-sql-parameter"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
4 methods in the retrospective path had SQL using
:domainKey/:classKeybut missing.param()calls, causing "No value supplied for the SQL parameter domainKey" errors when "Apply retroactively" tried to find shared person contributions.Methods Fixed
bestNamedSharedInstanceMatch(UUID, ClassInstanceUnnamedCandidateAssignment, double)namedSharedPersonEmbeddingsByKey(UUID)existingAcceptedSharedContribution(UUID, ClassInstanceUnnamedCandidateAssignment)existingAcceptedSharedContributions(UUID, List)What Changed
Added
.param("domainKey", "people")and.param("classKey", "person")before.query()in each method's JdbcClient chain. Values match the existing pattern used in all other people-domain methods in this file.Out of Scope
3 other methods in the browse/explore path have the same bug pattern but are not triggered by the retrospective flow. Will be filed as a follow-up issue.
Verification
compileJava— passesClassInstanceServiceTest*— all tests pass