fix(discovery): remove @Transactional from applyAutoApprovalRetrospectively #689
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/retroactive-apply-transactional"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Remove
@Transactionalfrom both overloads ofapplyAutoApprovalRetrospectively().\n\n## Problem\n\n@Transactionalheld a single DB connection for 2-3 minutes during retrospective apply (processing 6825+ candidates). HikariCP leak detection (30s threshold) fired, blocking REQUIRES_NEW progress store updates.\n\n## Fix\n\n- Remove@Transactionalfrom both public overloads\n- Each DB operation auto-commits independently\n- Progress store handles its own REQUIRES_NEW transaction\n- Atomicity intentionally weakened: failed mid-way runs can be retried, onlystate='pending'candidates re-processed\n\n## Production note\n\nThe affected production run was manually unstuck as part of v1.21.21.\n\n## Verification\n\n-compileJava: pass\n-ClassInstanceServiceTest: pass