Fix face URL 404 in ClassInstanceAutomationRunService (sibling of #657) #658

Open
opened 2026-07-20 16:50:02 +02:00 by chris · 0 comments
Owner

Problem\n\nClassInstanceAutomationRunService.java:240 has same bug fixed in PR #657 for ClassInstanceService: unconditional face-crop URL construction without checking if derived_assets row exists. If missing, URL returns 404.\n\n## Root Cause\n\nSame as #657: V108 backfill no-op left ~10,547 faces with NULL thumbnail_derived_asset_id. Code assumes derived asset always exists when constructing face-crop URL.\n\n## Scope\n\nAdmin-only view (automation run detail). Not user-facing explore page (fixed in #657). Severity: med.\n\n## Fix\n\nApply same pattern as #657: check for NULL face_thumbnail_key and fall back to full-photo thumbnail URL.\n\n## References\n\n- PR #657: fix in ClassInstanceService (same root cause)\n- V108 backfill no-op\n- Part B data backfill (follow-up)

## Problem\n\n`ClassInstanceAutomationRunService.java:240` has same bug fixed in PR #657 for `ClassInstanceService`: unconditional face-crop URL construction without checking if `derived_assets` row exists. If missing, URL returns 404.\n\n## Root Cause\n\nSame as #657: V108 backfill no-op left ~10,547 faces with NULL `thumbnail_derived_asset_id`. Code assumes derived asset always exists when constructing face-crop URL.\n\n## Scope\n\nAdmin-only view (automation run detail). Not user-facing explore page (fixed in #657). Severity: med.\n\n## Fix\n\nApply same pattern as #657: check for NULL `face_thumbnail_key` and fall back to full-photo thumbnail URL.\n\n## References\n\n- PR #657: fix in `ClassInstanceService` (same root cause)\n- V108 backfill no-op\n- Part B data backfill (follow-up)
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories#658
No description provided.