fix(api): guard face-thumbnail URL when no derived_asset exists #642
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/people-thumbnail-404"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
People browse page showed 404 errors for all face-crop thumbnails.
Root cause:
ClassInstanceService.enrichPeopleFaces()built face-thumbnail URLs unconditionally even when noface_thumbnailderived_asset existed. Theauto_selectedCTE (line 367) pickedrn=1face without checkingface_thumbnail_key IS NOT NULL— inconsistency withmanual_selectedCTE (line 362) which was already guarded.Fix: Add
AND rf.face_thumbnail_key IS NOT NULLfilter toauto_selectedCTE. When no face has a thumbnail,rebecomes null → falls back togi.representativeThumbnailUrl()(generic media thumbnail, always safe).Changes
apps/api/src/main/java/dev/memories/api/discovery/ClassInstanceService.java— 1 line:AND rf.face_thumbnail_key IS NOT NULLapps/api/src/test/java/dev/memories/api/discovery/ClassInstanceServiceTest.java— 3 regression testsapps/api/src/test/java/dev/memories/api/discovery/H2FaceBoxAreaFunction.java— H2 stub forface_box_areaPG functionTest Results
:apps:api:testpersonWithFaceThumbnailReturnsFaceUrl— happy pathpersonWithoutFaceThumbnailReturnsNullPreviewUrl— bug repropersonWithMixedFacesPicksFaceWithThumbnail— mixed scenarioFrontend
No changes needed.
PeopleBrowser.svelte:666andDiscoveryDomainInstances.svelte:141-156already handle nullrepresentativePreviewUrlwith "No preview" fallback.Audit
Sibling bug audit: no other ROW_NUMBER CTEs in same bug class.
CollaborativeClassInstancePeopleBridgealready guarded.personSummary()already guarded.ClassInstanceAutomationRunServiceis different context (face creation, not browse).Version
v1.21.6 → v1.21.7