fix(android): keep timeline filter chips on one line (scrollable rows) #1522
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/android-filter-chips"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Defect
On the Fotos/Timeline tab the top filter chips row (Alle, Mine, [Familiegruppe], Favoritter, Fotos, Videoer) overflowed on narrow screens: all 5-6 Material3 FilterChips sat in ONE non-scrollable
fillMaxWidthRow, so Compose squeezed the trailing chips until their labels wrapped letter-under-letter — "Videoer" rendered as a vertical V/i/d/e/o/e/r stack. Reported from the running app.Fix
FilterRowsnow matches the web timeline's two-row chip layout: scope chips (Alle/Meine/Familiegruppe) and filter chips (Favoritter + Fotos/Videoer) each render in their own horizontally scrollable Row (horizontalScrollin a Column wrapper). Every chip keeps its intrinsic width; labels stay on one line. Selection semantics untouched: group chip only whengroupScopeAvailable, favorite toggle, media-type two-chip toggle where tapping the selected chip clears to ALL. No string changes (de/da/en labels reused).MapScopeRowhad the same latent overflow class (scope + satellite chips squeezed by the trailing search/cast buttons): the chip segment now scrolls insideweight(1f, fill = false), actions stay pinned to the trailing end.heightIn(min = 48.dp)(Material3 default chip is 32dp tall) andmaxLines = 1. Scrolling makes truncation unnecessary, so labels are never ellipsized.LazyRow(chips keep intrinsic width — no overflow possible, no change needed); BackupSettings interval chips alreadyhorizontalScroll(got the 48dp touch target only). No album/upload chip rows exist.Validation
rtk ./gradlew :app:compileDebugKotlin(fromapps/android, the Android build root) — BUILD SUCCESSFUL, only pre-existing warnings.rtk ./gradlew :app:testDebugUnitTest— BUILD SUCCESSFUL.Resolves [ISSUE-233] (recorded in KNOWN_ISSUES.md; ISSUE-226 as suggested was already taken).
Timeline FilterRows squeezed all 5-6 FilterChips (Alle/Meine/ Familiegruppe/Favoritter/Fotos/Videoer) into a single non-scrollable Row; on narrow screens Compose crushed trailing chips until their labels wrapped letter-under-letter ('Videoer' rendered vertically). - FilterRows now matches the web timeline's two-row chip layout: scope chips and filter chips (Favoritter + Fotos/Videoer) each in their own horizontally scrollable Row, so every chip keeps its intrinsic width and single-line labels. Selection semantics untouched (group chip only when groupScopeAvailable, favorite toggle, media-type tap-selected-clears-to-ALL). - MapScreen MapScopeRow had the same overflow class (chips squeezed by trailing search/cast buttons): chip segment now scrolls inside weight(1f, fill=false), actions stay pinned trailing. - Touched chips gain heightIn(min = 48.dp) - the Material3 default chip is 32dp tall, below the 48dp touch target - and maxLines = 1. - SearchScreen filter row is already a LazyRow (no overflow possible); BackupSettings interval chips already scroll - both only get the 48dp touch target. Resolves [ISSUE-233].