fix(android): keep timeline filter chips on one line (scrollable rows) #1522

Merged
chris merged 2 commits from fix/android-filter-chips into main 2026-11-15 17:39:32 +01:00
Owner

Defect

On the Fotos/Timeline tab the top filter chips row (Alle, Mine, [Familiegruppe], Favoritter, Fotos, Videoer) overflowed on narrow screens: all 5-6 Material3 FilterChips sat in ONE non-scrollable fillMaxWidth Row, so Compose squeezed the trailing chips until their labels wrapped letter-under-letter — "Videoer" rendered as a vertical V/i/d/e/o/e/r stack. Reported from the running app.

Fix

  • TimelineScreen FilterRows now matches the web timeline's two-row chip layout: scope chips (Alle/Meine/Familiegruppe) and filter chips (Favoritter + Fotos/Videoer) each render in their own horizontally scrollable Row (horizontalScroll in a Column wrapper). Every chip keeps its intrinsic width; labels stay on one line. Selection semantics untouched: group chip only when groupScopeAvailable, favorite toggle, media-type two-chip toggle where tapping the selected chip clears to ALL. No string changes (de/da/en labels reused).
  • MapScreen MapScopeRow had the same latent overflow class (scope + satellite chips squeezed by the trailing search/cast buttons): the chip segment now scrolls inside weight(1f, fill = false), actions stay pinned to the trailing end.
  • Touch targets: all touched chips gain heightIn(min = 48.dp) (Material3 default chip is 32dp tall) and maxLines = 1. Scrolling makes truncation unnecessary, so labels are never ellipsized.
  • Checked the other chip rows: SearchScreen filter row is already a LazyRow (chips keep intrinsic width — no overflow possible, no change needed); BackupSettings interval chips already horizontalScroll (got the 48dp touch target only). No album/upload chip rows exist.

Validation

  • rtk ./gradlew :app:compileDebugKotlin (from apps/android, the Android build root) — BUILD SUCCESSFUL, only pre-existing warnings.
  • rtk ./gradlew :app:testDebugUnitTest — BUILD SUCCESSFUL.

Resolves [ISSUE-233] (recorded in KNOWN_ISSUES.md; ISSUE-226 as suggested was already taken).

## Defect On the Fotos/Timeline tab the top filter chips row (Alle, Mine, [Familiegruppe], Favoritter, Fotos, Videoer) overflowed on narrow screens: all 5-6 Material3 FilterChips sat in ONE non-scrollable `fillMaxWidth` Row, so Compose squeezed the trailing chips until their labels wrapped letter-under-letter — "Videoer" rendered as a vertical V/i/d/e/o/e/r stack. Reported from the running app. ## Fix - **TimelineScreen `FilterRows`** now matches the web timeline's two-row chip layout: scope chips (Alle/Meine/Familiegruppe) and filter chips (Favoritter + Fotos/Videoer) each render in their own horizontally scrollable Row (`horizontalScroll` in a Column wrapper). Every chip keeps its intrinsic width; labels stay on one line. **Selection semantics untouched**: group chip only when `groupScopeAvailable`, favorite toggle, media-type two-chip toggle where tapping the selected chip clears to ALL. No string changes (de/da/en labels reused). - **MapScreen `MapScopeRow`** had the same latent overflow class (scope + satellite chips squeezed by the trailing search/cast buttons): the chip segment now scrolls inside `weight(1f, fill = false)`, actions stay pinned to the trailing end. - **Touch targets**: all touched chips gain `heightIn(min = 48.dp)` (Material3 default chip is 32dp tall) and `maxLines = 1`. Scrolling makes truncation unnecessary, so labels are never ellipsized. - **Checked the other chip rows**: SearchScreen filter row is already a `LazyRow` (chips keep intrinsic width — no overflow possible, no change needed); BackupSettings interval chips already `horizontalScroll` (got the 48dp touch target only). No album/upload chip rows exist. ## Validation - `rtk ./gradlew :app:compileDebugKotlin` (from `apps/android`, the Android build root) — BUILD SUCCESSFUL, only pre-existing warnings. - `rtk ./gradlew :app:testDebugUnitTest` — BUILD SUCCESSFUL. Resolves [ISSUE-233] (recorded in KNOWN_ISSUES.md; ISSUE-226 as suggested was already taken).
Timeline FilterRows squeezed all 5-6 FilterChips (Alle/Meine/
Familiegruppe/Favoritter/Fotos/Videoer) into a single non-scrollable
Row; on narrow screens Compose crushed trailing chips until their
labels wrapped letter-under-letter ('Videoer' rendered vertically).

- FilterRows now matches the web timeline's two-row chip layout:
  scope chips and filter chips (Favoritter + Fotos/Videoer) each in
  their own horizontally scrollable Row, so every chip keeps its
  intrinsic width and single-line labels. Selection semantics
  untouched (group chip only when groupScopeAvailable, favorite
  toggle, media-type tap-selected-clears-to-ALL).
- MapScreen MapScopeRow had the same overflow class (chips squeezed
  by trailing search/cast buttons): chip segment now scrolls inside
  weight(1f, fill=false), actions stay pinned trailing.
- Touched chips gain heightIn(min = 48.dp) - the Material3 default
  chip is 32dp tall, below the 48dp touch target - and maxLines = 1.
- SearchScreen filter row is already a LazyRow (no overflow possible);
  BackupSettings interval chips already scroll - both only get the
  48dp touch target.

Resolves [ISSUE-233].
docs(known-issues): record ISSUE-233 android timeline filter-chip overflow fix
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 5s
Build and Deploy / Android unit tests and debug APK (push) Successful in 5m51s
4d459a64de
chris merged commit 75887ca40c into main 2026-11-15 17:39:32 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1522
No description provided.