feat(web): people-specific empty state explains why no persons appear yet #1399

Merged
chris merged 2 commits from feature/people-empty-state-hint into main 2026-10-26 10:02:02 +01:00
Owner

Fresh or small libraries with only a few photos per person never reach the minimum group size for face grouping, so the people page (/discovery/domains/people) showed the generic "No instances discovered yet" empty state — which reads like a bug.

On the people domain (and only there, and only while no search is active) the empty state now explains that faces are grouped into people once enough similar photos exist, and tells the user to add more photos.

  • Reuses the existing EmptyState component (icon users); no styling changes
  • Other discovery domains keep the untouched generic empty state
  • New Paraglide keys ddiPeopleEmptyTitle / ddiPeopleEmptyBody in en/de/da (household wording per spec 007: no clustering/discovery/instance terminology)

Verification: JSON parity of all three bundles (2599 keys each), npm run check in apps/web — 0 errors, only pre-existing warnings; no manual version bump (pipeline-computed).

Fresh or small libraries with only a few photos per person never reach the minimum group size for face grouping, so the people page (`/discovery/domains/people`) showed the generic "No instances discovered yet" empty state — which reads like a bug. On the people domain (and only there, and only while no search is active) the empty state now explains that faces are grouped into people once enough similar photos exist, and tells the user to add more photos. - Reuses the existing `EmptyState` component (icon `users`); no styling changes - Other discovery domains keep the untouched generic empty state - New Paraglide keys `ddiPeopleEmptyTitle` / `ddiPeopleEmptyBody` in en/de/da (household wording per spec 007: no clustering/discovery/instance terminology) Verification: JSON parity of all three bundles (2599 keys each), `npm run check` in apps/web — 0 errors, only pre-existing warnings; no manual version bump (pipeline-computed).
feat(web): people-specific empty state explains why no persons appear yet
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 7m6s
4ef32c064e
Fresh or small libraries with only a few photos per person never reach
the minimum group size, so the people page stayed empty and looked like
a bug. On the people domain (and only there, and only without an active
search) the empty state now explains that faces group into people once
enough similar photos exist and tells the user to add more photos.
Other domains keep the generic empty state unchanged.

New message keys ddiPeopleEmptyTitle/ddiPeopleEmptyBody (en/de/da).
test(web): expect people-specific empty state on people domain
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 7m14s
cc4ee2a55a
discovery-review.spec.ts asserts the empty state after an empty
class-instances response on domainKey=people, which now renders the
explanatory 'No people here yet' state instead of the generic
'No instances discovered yet' wording.
chris merged commit d8b5ca4032 into main 2026-10-26 10:02:02 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1399
No description provided.