feat(web): unify ActivityDialog into expandable progress-row model #1391

Merged
chris merged 2 commits from feat/activity-dialog-rows into main 2026-10-25 21:04:16 +01:00
Owner

Summary

Replaces the five overlapping ActivityDialog sections (upload sessions, local-tab upload card, lifetime processing lanes, people automation, recent operations) with ONE unified list of top-level rows.

  • Each row: title + thin progress bar + inline spinner while active + optional expand/collapse chevron (aria-expanded/aria-controls)
  • Upload-batch row nests cross-device sessions AND in-flight batch lanes (faces, things, thumbnails, ...) as details; reprocess rows claim their matching lifetime lane — nothing appears twice and status signals no longer contradict
  • Local tab upload merges into the upload row ('this device') when its session is listed; otherwise it gets its own row
  • States: running (sky bar + spinner), completed (emerald, collapsed), failed/needs-attention (red accent, expanded), indeterminate (people automation: spinner + pulsing bar)
  • Failed rows carry a red left accent; running/failed rows start expanded, completed collapsed; explicit toggle wins afterwards
  • New pure row model src/lib/activity/activityRows.ts (291 lines, fully unit-tested: 19 cases) + component spec (6 cases); i18n keys added to de/en/da

Discard flow (incl. aria-live announcements), loading skeletons, empty state, header badge and footer actions unchanged. AppShell / ProcessingIndicator / backend untouched.

Validation

  • npm run check: 0 errors (20 pre-existing warnings)
  • vitest: 77/77 passed (activity rows, dialog spec, i18n guards, stores)
## Summary Replaces the five overlapping ActivityDialog sections (upload sessions, local-tab upload card, lifetime processing lanes, people automation, recent operations) with ONE unified list of top-level rows. - Each row: title + thin progress bar + inline spinner while active + optional expand/collapse chevron (aria-expanded/aria-controls) - Upload-batch row nests cross-device sessions AND in-flight batch lanes (faces, things, thumbnails, ...) as details; reprocess rows claim their matching lifetime lane — nothing appears twice and status signals no longer contradict - Local tab upload merges into the upload row ('this device') when its session is listed; otherwise it gets its own row - States: running (sky bar + spinner), completed (emerald, collapsed), failed/needs-attention (red accent, expanded), indeterminate (people automation: spinner + pulsing bar) - Failed rows carry a red left accent; running/failed rows start expanded, completed collapsed; explicit toggle wins afterwards - New pure row model `src/lib/activity/activityRows.ts` (291 lines, fully unit-tested: 19 cases) + component spec (6 cases); i18n keys added to de/en/da Discard flow (incl. aria-live announcements), loading skeletons, empty state, header badge and footer actions unchanged. AppShell / ProcessingIndicator / backend untouched. ## Validation - `npm run check`: 0 errors (20 pre-existing warnings) - `vitest`: 77/77 passed (activity rows, dialog spec, i18n guards, stores)
feat(web): unify ActivityDialog into expandable row model
Some checks failed
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 4s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Failing after 8m13s
abc4892811
Replace the five overlapping sections (upload sessions, local-tab upload
card, lifetime lanes, people automation, recent operations) with ONE list
of rows built by a pure, unit-tested module (src/lib/activity/activityRows).

Dedup rules: batch lanes and cross-device sessions nest inside the
upload-batch row's details; the local tab's upload merges into that row
("this device") when its session is listed, otherwise it gets its own row;
reprocess rows claim their matching lifetime lane; claimed lanes are
excluded from the lifetime section.

Rows carry state (running/completed/failed/indeterminate), a thin progress
bar, an inline spinner while active, and an expand/collapse chevron with
aria-expanded/aria-controls. Failed rows get a red left accent. Header,
footer actions, discard flow (incl. aria-live announcements), loading
skeletons and empty state are unchanged.

New i18n keys (de/en/da): activityRowsSection, activityRowDetailsShow,
activityRowDetailsHide. Tests: activityRows.spec.ts (19 cases) and an
SSR component spec for spinner/state/toggle behaviour.
fix(web): align activity-dialog specs with unified row model
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 3s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Android unit tests and debug APK (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Deploy review instance (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 7m48s
f016a9dfa9
Update the five CI-failing dialog specs to the new structure (single row
list, data-row-state, spinner gating, expanded details) while preserving
each test's original intent: named lane transparency, failed-first order,
lanes surviving alongside operations, upload-batch step resolution with a
dedup guard, and human session titles with the hash sub-line. upload-status
now expands the completed local-upload row before asserting its counts.

Two real regressions found and fixed in the component:
- upload-batch row details lost the operation progress line
  ("72 of 144 processing steps") that the old dialog always showed;
- standalone session rows rendered the session title twice (row header +
  inner card); the inner card now omits the repeated header (compact).
Also restores the session-hash sub-line dropped during the redesign.
chris merged commit d3feac9965 into main 2026-10-25 21:04:16 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1391
No description provided.