feat(web): unify ActivityDialog into expandable progress-row model #1391
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/activity-dialog-rows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Replaces the five overlapping ActivityDialog sections (upload sessions, local-tab upload card, lifetime processing lanes, people automation, recent operations) with ONE unified list of top-level rows.
src/lib/activity/activityRows.ts(291 lines, fully unit-tested: 19 cases) + component spec (6 cases); i18n keys added to de/en/daDiscard flow (incl. aria-live announcements), loading skeletons, empty state, header badge and footer actions unchanged. AppShell / ProcessingIndicator / backend untouched.
Validation
npm run check: 0 errors (20 pre-existing warnings)vitest: 77/77 passed (activity rows, dialog spec, i18n guards, stores)Replace the five overlapping sections (upload sessions, local-tab upload card, lifetime lanes, people automation, recent operations) with ONE list of rows built by a pure, unit-tested module (src/lib/activity/activityRows). Dedup rules: batch lanes and cross-device sessions nest inside the upload-batch row's details; the local tab's upload merges into that row ("this device") when its session is listed, otherwise it gets its own row; reprocess rows claim their matching lifetime lane; claimed lanes are excluded from the lifetime section. Rows carry state (running/completed/failed/indeterminate), a thin progress bar, an inline spinner while active, and an expand/collapse chevron with aria-expanded/aria-controls. Failed rows get a red left accent. Header, footer actions, discard flow (incl. aria-live announcements), loading skeletons and empty state are unchanged. New i18n keys (de/en/da): activityRowsSection, activityRowDetailsShow, activityRowDetailsHide. Tests: activityRows.spec.ts (19 cases) and an SSR component spec for spinner/state/toggle behaviour.Update the five CI-failing dialog specs to the new structure (single row list, data-row-state, spinner gating, expanded details) while preserving each test's original intent: named lane transparency, failed-first order, lanes surviving alongside operations, upload-batch step resolution with a dedup guard, and human session titles with the hash sub-line. upload-status now expands the completed local-upload row before asserting its counts. Two real regressions found and fixed in the component: - upload-batch row details lost the operation progress line ("72 of 144 processing steps") that the old dialog always showed; - standalone session rows rendered the session title twice (row header + inner card); the inner card now omits the repeated header (compact). Also restores the session-hash sub-line dropped during the redesign.