fix(android): request ACCESS_MEDIA_LOCATION and read original bytes so backup keeps GPS EXIF #1275

Merged
chris merged 1 commit from fix/android-access-media-location into main 2026-10-16 23:46:23 +02:00
Owner

Summary

  • Android-appens backup tabte GPS EXIF på alle uploads: MediaProvider redigerer location for apps uden ACCESS_MEDIA_LOCATION, og appen læste via contentResolver.openInputStream(uri) på plain MediaStore-URIs. Uploadede bytes kom frem med GPS-IFD-skelet men alle rationaler 0/0 og tomme refs (verificeret server-side på rigtige filer).
  • Manifest: tilføjer ACCESS_MEDIA_LOCATION (API 29+, protectionLevel dangerous — manifest-linje alene er ikke nok).
  • Læsesti: ContentResolverMediaReader markerer hver Uri med MediaStore.setRequireOriginal(uri) når grant er holdt (SDK >= 29). At holde tilladelsen alene er IKKE nok — opt-in-markeringen er påkrævet ifølge den officielle kontrakt.
  • Runtime-tilladelse: ny two-step flow på SICHERUNG/Backup-skærmen (appens backup-entry). Trin 1 beder om READ_MEDIA_IMAGES+READ_MEDIA_VIDEO (33+) bzw. READ_EXTERNAL_STORAGE (29–32); kun ved all-granted affyres trin 2 som en separat RequestPermission for ACCESS_MEDIA_LOCATION (den hører til ingen permission-group, og batching risikerer at OEM'en auto-deny'er). Alt indenfor SDK_INT >= 29.

Fallback (garanterer at backup aldrig fejler)

Enhver anden sti falder tilbage til den plain (redigerede) læsning: pre-Q short-circuit, ingen grant, og hele original-stien er wrapped i catch (Throwable) (nogle OEM-builds kaster SecurityException i stedet for den dokumenterede UnsupportedOperationException). En fejl i original-stien kan kun degradere til præcis adfærd før ændringen — aldrig bryde en backup.

Validation

  • ANDROID_HOME=~/Android/Sdk rtk ./gradlew :core:test :app:testDebugUnitTest (i apps/android, samme tasks som CI) → BUILD SUCCESSFUL, 552 tests, 0 failures.
  • Ny ContentResolverMediaReaderRobolectricTest (4/4): grant+SDK29 åbner require-original Uri; ingen grant rører den aldrig; OEM SecurityException på original-stien falder tilbage til plain bytes; pre-Q (sdk=28) forsøger aldrig original-stien.

Notes

  • Kun apps/android er rørt — intet :core-interface, ingen server/web/Flyway/spec-ændringer.
  • Bevidst udenfor scope (eksisterende ISSUE-130, ejet af anden lane): pre-Q (API <=28) media-permission-request i SICHERUNG-flowet. Denne flow er gated ved 29+ og hverken forbedrer eller forværrer den.
  • Efter merge: brugeren skal opdatere appen og acceptere den nye placeringstilladelse på SICHERUNG-fanen, så nye backups bevarer GPS. Eksisterende fotos kan genvindes via USB/PC (DCIM/Camera), som bypasser MediaProvider helt.
## Summary - Android-appens backup tabte GPS EXIF på alle uploads: MediaProvider redigerer location for apps uden `ACCESS_MEDIA_LOCATION`, og appen læste via `contentResolver.openInputStream(uri)` på plain MediaStore-URIs. Uploadede bytes kom frem med GPS-IFD-skelet men alle rationaler 0/0 og tomme refs (verificeret server-side på rigtige filer). - **Manifest**: tilføjer `ACCESS_MEDIA_LOCATION` (API 29+, protectionLevel dangerous — manifest-linje alene er ikke nok). - **Læsesti**: `ContentResolverMediaReader` markerer hver Uri med `MediaStore.setRequireOriginal(uri)` når grant er holdt (SDK >= 29). At holde tilladelsen alene er IKKE nok — opt-in-markeringen er påkrævet ifølge den officielle kontrakt. - **Runtime-tilladelse**: ny two-step flow på SICHERUNG/Backup-skærmen (appens backup-entry). Trin 1 beder om `READ_MEDIA_IMAGES`+`READ_MEDIA_VIDEO` (33+) bzw. `READ_EXTERNAL_STORAGE` (29–32); kun ved all-granted affyres trin 2 som en **separat** `RequestPermission` for `ACCESS_MEDIA_LOCATION` (den hører til ingen permission-group, og batching risikerer at OEM'en auto-deny'er). Alt indenfor `SDK_INT >= 29`. ## Fallback (garanterer at backup aldrig fejler) Enhver anden sti falder tilbage til den plain (redigerede) læsning: pre-Q short-circuit, ingen grant, og hele original-stien er wrapped i `catch (Throwable)` (nogle OEM-builds kaster `SecurityException` i stedet for den dokumenterede `UnsupportedOperationException`). En fejl i original-stien kan kun degradere til præcis adfærd før ændringen — aldrig bryde en backup. ## Validation - `ANDROID_HOME=~/Android/Sdk rtk ./gradlew :core:test :app:testDebugUnitTest` (i `apps/android`, samme tasks som CI) → **BUILD SUCCESSFUL, 552 tests, 0 failures**. - Ny `ContentResolverMediaReaderRobolectricTest` (4/4): grant+SDK29 åbner require-original Uri; ingen grant rører den aldrig; OEM `SecurityException` på original-stien falder tilbage til plain bytes; pre-Q (sdk=28) forsøger aldrig original-stien. ## Notes - Kun `apps/android` er rørt — intet `:core`-interface, ingen server/web/Flyway/spec-ændringer. - Bevidst udenfor scope (eksisterende ISSUE-130, ejet af anden lane): pre-Q (API <=28) media-permission-request i SICHERUNG-flowet. Denne flow er gated ved 29+ og hverken forbedrer eller forværrer den. - Efter merge: brugeren skal opdatere appen og acceptere den nye placeringstilladelse på SICHERUNG-fanen, så nye backups bevarer GPS. Eksisterende fotos kan genvindes via USB/PC (DCIM/Camera), som bypasser MediaProvider helt.
fix(android): request ACCESS_MEDIA_LOCATION and read original bytes so backup keeps GPS EXIF
All checks were successful
Wiki Sync / Sync wiki from docs (push) Has been skipped
Build and Deploy / Build Android CI image (push) Has been skipped
Build and Deploy / Detect changed services and test scopes (push) Successful in 2s
Build and Deploy / Smoke API and media worker (push) Has been skipped
Build and Deploy / Smoke web (push) Has been skipped
Build and Deploy / Smoke ML worker (push) Has been skipped
Build and Deploy / Smoke people worker (push) Has been skipped
Build and Deploy / Build postgres image (push) Has been skipped
Build and Deploy / Build plants worker image (push) Has been skipped
Build and Deploy / Build converter worker image (push) Has been skipped
Build and Deploy / Deploy postgres (push) Has been skipped
Build and Deploy / Build API image (push) Has been skipped
Build and Deploy / Build media worker image (push) Has been skipped
Build and Deploy / Build ML worker image (push) Has been skipped
Build and Deploy / Build people worker image (push) Has been skipped
Build and Deploy / Build web image (push) Has been skipped
Build and Deploy / Deploy API (push) Has been skipped
Build and Deploy / Deploy web (push) Has been skipped
Build and Deploy / Deploy media worker (push) Has been skipped
Build and Deploy / Deploy ML worker (push) Has been skipped
Build and Deploy / Deploy plants worker (push) Has been skipped
Build and Deploy / Deploy people worker (push) Has been skipped
Build and Deploy / Deploy converter worker (push) Has been skipped
Build and Deploy / Clean Docker build artifacts (push) Has been skipped
Build and Deploy / Run scoped PR tests (push) Successful in 5s
Build and Deploy / Android unit tests and debug APK (push) Successful in 3m14s
94c2c8f97c
From Q MediaProvider redacts GPS EXIF for apps without a runtime-granted
ACCESS_MEDIA_LOCATION, so backed-up uploads lost their location (skeleton
IFD with zeroed rationals). Declare the permission, request it in its own
prompt on the SICHERUNG tab only after the media reads are granted, and
have ContentResolverMediaReader mark each Uri with
MediaStore.setRequireOriginal when the grant is held — every other path
(no grant, OEM failure, pre-Q) falls back to the plain read so a backup
never breaks over this.
chris merged commit 450b1d6804 into main 2026-10-16 23:46:23 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
chris/memories!1275
No description provided.