fix(web): keep face-suggestion thumbnails person-accurate #1250
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/face-suggest-perf-thumbs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes three related defects in the face-assignment dialog (Person zuweisen):
{#each}, so rows were positionally reused and a row could keep showing the previous list's face. Rows are now keyed byinstanceId.hideWhileLoadingprop, used only by the dialog rows (timeline/people keep their progressive-loading behavior).refreshFaceDialogState()applied a refreshed suggestion list without invalidating in-flight fetches, so a slow debouncedloadFaceSuggestionscould clobber the fresher list. It now bumpsfaceSuggestionRequestIdand guards its own response with the captured id.Also requests the small face rendition (
?size=256, same convention as explore/shared-people; the backend face-thumbnail endpoint honourssize, normalized to 256/512) for the 48px dialog rows instead of the widest/pointer asset.Tests: new Playwright case in timeline.spec.ts asserting row N shows row N's own representativePreviewUrl (+size hint) and that a refetched list leaves no previous row's image src behind; vitest coverage for
faceSuggestionThumbnailUrland thehideWhileLoadingSSR contract.